From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47173C1975A for ; Wed, 25 Mar 2020 08:58:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2822620714 for ; Wed, 25 Mar 2020 08:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727490AbgCYI6z (ORCPT ); Wed, 25 Mar 2020 04:58:55 -0400 Received: from verein.lst.de ([213.95.11.211]:39791 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727372AbgCYI6z (ORCPT ); Wed, 25 Mar 2020 04:58:55 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C17A268AFE; Wed, 25 Mar 2020 09:58:52 +0100 (CET) Date: Wed, 25 Mar 2020 09:58:52 +0100 From: Christoph Hellwig To: Fredrik Noring Cc: Christoph Hellwig , "Maciej W. Rozycki" , Thomas Bogendoerfer , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] MIPS: remove cpu_has_64bit_gp_regs and cpu_has_64bit_addresses Message-ID: <20200325085852.GA23786@lst.de> References: <20200324161525.754181-1-hch@lst.de> <20200324161525.754181-2-hch@lst.de> <20200325083012.GA21605@lst.de> <20200325085524.GA28706@sx9> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325085524.GA28706@sx9> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2020 at 09:55:24AM +0100, Fredrik Noring wrote: > > The only use of cpu_has_64bit_addresses is the choice of the ioremap > > code base. Which ioremap code does the R5900 want to use? If it > > doesn't match CONFIG_64BIT having a config option for the ioremap > > implementation seems much more sensible, and can be added with the > > R5900 patch set (do you have a link to it?). > > I suppose this would be relevant for the n32 ABI, but initially we only > have o32 for the R5900. To enable ABIs you'll need Kconfig symbols, cpu_has_64bit_addresses isn't going to be very useful for that. Which kinda rather was the point of this patch - to use the existing Kconfig symbol rather than two redundant defines that caused a lot weird cargo culting. > The (slightly outdated) patch series under review > is available here: > > https://lore.kernel.org/linux-mips/cover.1567326213.git.noring@nocrew.org/T/ You don't happen to have a git tree available somewhere?