From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] Use SAFE_RUNCMD()
Date: Wed, 25 Mar 2020 16:56:24 +0100 [thread overview]
Message-ID: <20200325155624.GC21800@dell5510> (raw)
In-Reply-To: <1dea6ff2-f32d-c797-b52d-716efe73d4a6@cn.fujitsu.com>
Hi Xu,
> I have seen the history about this problem. We have few C cases to use many
> commands(copy_file_range02.c is a specify case, I ported it from xfstest to
> increase coverage), do we really want to implement need_cmd or
> want_cmds(Usually, we seldom use command in c case and we should avoid this
> for reduce unnecessary dependencies, except user level command such as mkfs
> or makeswap or useradd)? It will give user a mislead.
> ps:copy_file_range02.c should use swapon and swapoff syscall instead of
> command.
Yes, rewriting to C would be an improvement for non-standard linux platforms
(but then you need to deal with other exceptions: e.g. whether
swapon()/swapoff() is even supported on platforms like Android and you might
endup with 1) much more code 2) TCONF anyway for these platforms.
And there is also chattr and mkswap.
Besides this IMHO there will always be a need for running some command via
tst_run_cmd() in the test instead of reimplementing a wheel. Some of other
dependencies:
cat (testcases/cve/stack_clash.c this one could be using C code),
mpdprobe, make, mkswap, quotacheck,
useradd/userdel (I plan to put these into the library, but still it's much
easier to use them than reimplement code in C).
Also library itself (these will not use the flag): insmod, modprobe, rmmod, mkfs.*,
systemd-detect-virt (this one is not a hard dependency).
Kind regards,
Petr
next prev parent reply other threads:[~2020-03-25 15:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 13:49 [LTP] [PATCH 1/2] lib: Implement SAFE_RUN() macro (new API only) Petr Vorel
2020-03-20 13:49 ` [LTP] [PATCH 2/2] Use SAFE_RUNCMD() Petr Vorel
2020-03-23 3:13 ` Yang Xu
2020-03-23 9:04 ` Petr Vorel
2020-03-23 9:10 ` Li Wang
2020-03-23 9:52 ` Yang Xu
2020-03-23 11:37 ` Petr Vorel
2020-03-23 13:42 ` Li Wang
2020-03-23 14:32 ` Li Wang
2020-03-23 16:04 ` Petr Vorel
2020-03-24 23:51 ` Cyril Hrubis
2020-03-24 17:21 ` Petr Vorel
2020-03-25 1:53 ` Cyril Hrubis
2020-03-24 18:55 ` Petr Vorel
2020-03-25 5:56 ` Li Wang
2020-03-25 5:30 ` Li Wang
2020-03-25 17:07 ` Cyril Hrubis
2020-03-25 9:34 ` Petr Vorel
2020-03-25 10:03 ` Cyril Hrubis
2020-03-25 15:40 ` Petr Vorel
2020-03-25 10:42 ` Yang Xu
2020-03-25 15:56 ` Petr Vorel [this message]
2020-03-26 5:27 ` Li Wang
2020-03-26 8:03 ` Yang Xu
2020-03-23 15:49 ` Petr Vorel
2020-03-24 6:27 ` Li Wang
2020-03-23 2:43 ` [LTP] [PATCH 1/2] lib: Implement SAFE_RUN() macro (new API only) Yang Xu
2020-03-23 9:20 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325155624.GC21800@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.