From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29278C1975A for ; Wed, 25 Mar 2020 16:19:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EEF7120409 for ; Wed, 25 Mar 2020 16:19:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEF7120409 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C2036B00B8; Wed, 25 Mar 2020 12:19:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 973106B00BB; Wed, 25 Mar 2020 12:19:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 887B76B00BC; Wed, 25 Mar 2020 12:19:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 6F8606B00B8 for ; Wed, 25 Mar 2020 12:19:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4BF6110FC5 for ; Wed, 25 Mar 2020 16:19:11 +0000 (UTC) X-FDA: 76634394102.18.lunch49_15f01ea43fb3f X-HE-Tag: lunch49_15f01ea43fb3f X-Filterd-Recvd-Size: 2723 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Mar 2020 16:19:10 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 1D52D68B05; Wed, 25 Mar 2020 17:19:06 +0100 (CET) Date: Wed, 25 Mar 2020 17:19:05 +0100 From: Christoph Hellwig To: glider@google.com Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Vegard Nossum , Dmitry Vyukov , Marco Elver , Andrey Konovalov , linux-mm@kvack.org, viro@zeniv.linux.org.uk, adilger.kernel@dilger.ca, akpm@linux-foundation.org, aryabinin@virtuozzo.com, luto@kernel.org, ard.biesheuvel@linaro.org, arnd@arndb.de, hch@infradead.org, darrick.wong@oracle.com, davem@davemloft.net, dmitry.torokhov@gmail.com, ebiggers@google.com, edumazet@google.com, ericvh@gmail.com, gregkh@linuxfoundation.org, harry.wentland@amd.com, herbert@gondor.apana.org.au, iii@linux.ibm.com, mingo@elte.hu, jasowang@redhat.com, axboe@kernel.dk, mark.rutland@arm.com, martin.petersen@oracle.com, schwidefsky@de.ibm.com, willy@infradead.org, mst@redhat.com, mhocko@suse.com, monstr@monstr.eu, pmladek@suse.com, cai@lca.pw, rdunlap@infradead.org, sergey.senozhatsky@gmail.com, rostedt@goodmis.org, tiwai@suse.com, tytso@mit.edu, tglx@linutronix.de, gor@linux.ibm.com, wsa@the-dreams.de Subject: Re: [PATCH v5 34/38] kmsan: dma: unpoison memory mapped by dma_direct_map_page() Message-ID: <20200325161905.GA19868@lst.de> References: <20200325161249.55095-1-glider@google.com> <20200325161249.55095-35-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325161249.55095-35-glider@google.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 05:12:45PM +0100, glider@google.com wrote: > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > index a8560052a915f..63dc1a594964a 100644 > --- a/kernel/dma/direct.c > +++ b/kernel/dma/direct.c > @@ -367,6 +367,7 @@ dma_addr_t dma_direct_map_page(struct device *dev, struct page *page, > &dma_addr, size, *dev->dma_mask, dev->bus_dma_limit); > return DMA_MAPPING_ERROR; > } > + kmsan_handle_dma(page_address(page) + offset, size, dir); This needs to go into dma_map_page so that it also covers IOMMUs. dma_map_sg_atttrs will also need similar treatment. Also the page doesn't have to be mapped into kernel address space, you probably want to pass the page to kmsan_handle_dma and throw in a highmem check there.