From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jH9Zx-00019R-LR for mharc-grub-devel@gnu.org; Wed, 25 Mar 2020 13:12:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57886) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH9Zu-00018w-S1 for grub-devel@gnu.org; Wed, 25 Mar 2020 13:12:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH9Zs-0001fr-Vn for grub-devel@gnu.org; Wed, 25 Mar 2020 13:12:30 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:34307) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.71) (envelope-from ) id 1jH9Zr-0001bA-L7 for grub-devel@gnu.org; Wed, 25 Mar 2020 13:12:28 -0400 Received: from router-fw.i.net-space.pl ([192.168.52.1]:55190 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S1896276AbgCYRMP (ORCPT ); Wed, 25 Mar 2020 18:12:15 +0100 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Wed, 25 Mar 2020 18:12:13 +0100 From: Daniel Kiper To: Patrick Steinhardt Cc: grub-devel@gnu.org, Leif Lindholm , agraf@csgraf.de, pjones@redhat.com, mjg59@google.com, phcoder@gmail.com, Milan Broz Subject: Re: [PATCH v3 0/5] Support Argon2 KDF in LUKS2 Message-ID: <20200325171213.rmkmiw5vydy4o5yp@tomti.i.net-space.pl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 84.10.22.86 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2020 17:12:32 -0000 Hi Patrick, On Tue, Mar 10, 2020 at 07:58:27PM +0100, Patrick Steinhardt wrote: > Hi, > > this is the third version of my patchset to support the Argon2 KDF in > LUKS2. The following things have changed in comparison to v2: > > - Improved the GRUB_UINT_C macros to not use `elif 1` and fixed > indentation. > > - Dropped the upstreamed patch to fix a missing newline. > > - Reworked how we allocate memory on EFI. Previously, we always > targeted to acquire 1/4 of available memory. Now we're always > trying to allocate MAX_HEAP_SIZE (1.6GB) but clamp it to at most > 1/2 of available memory and at least MIN_HEAP_SIZE (100MB). > > So especially the last part is the interesting one. I _think_ that it's > roughly what Leif had in mind, but please do correct me if I'm wrong. So, according to our earlier discussion I am not treating this patchset as a release material. However, I would like to merge fixed version of it after the release. In the meantime I am investigating the legal matter related to this patchset. Daniel