From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EED1C43331 for ; Wed, 25 Mar 2020 23:27:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 192C52073E for ; Wed, 25 Mar 2020 23:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727399AbgCYX1R (ORCPT ); Wed, 25 Mar 2020 19:27:17 -0400 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:36063 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727395AbgCYX1R (ORCPT ); Wed, 25 Mar 2020 19:27:17 -0400 Received: from dread.disaster.area (pa49-195-110-5.pa.nsw.optusnet.com.au [49.195.110.5]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 837887EAE58; Thu, 26 Mar 2020 10:27:15 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1jHFQZ-0005af-0H; Thu, 26 Mar 2020 10:27:15 +1100 Date: Thu, 26 Mar 2020 10:27:14 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH v2 2/4] xfs: validate the realtime geometry in xfs_validate_sb_common Message-ID: <20200325232714.GM10776@dread.disaster.area> References: <158510667039.922633.6138311243444001882.stgit@magnolia> <158510668306.922633.16796248628127177511.stgit@magnolia> <20200325060719.GX29339@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325060719.GX29339@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=UL8WcDbXXJQENuhYI/M0Yg==:117 a=UL8WcDbXXJQENuhYI/M0Yg==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=SS2py6AdgQ4A:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=uSPbgC4QN2py8rnT6hkA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Mar 24, 2020 at 11:07:19PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Validate the geometry of the realtime geometry when we mount the > filesystem, so that we don't abruptly shut down the filesystem later on. > > Signed-off-by: Darrick J. Wong > --- > v2: remove the excess whitespace and unlikely() bits Much nicer! Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com