From: David Miller <davem@davemloft.net>
To: hoang.h.le@dektech.com.au
Cc: netdev@vger.kernel.org, ying.xue@windriver.com,
maloy@donjonn.com, jmaloy@redhat.com,
tuong.t.lien@dektech.com.au
Subject: Re: [net-next] tipc: Add a missing case of TIPC_DIRECT_MSG type
Date: Thu, 26 Mar 2020 11:21:17 -0700 (PDT) [thread overview]
Message-ID: <20200326.112117.296057933553903521.davem@davemloft.net> (raw)
In-Reply-To: <20200326025029.5292-1-hoang.h.le@dektech.com.au>
From: Hoang Le <hoang.h.le@dektech.com.au>
Date: Thu, 26 Mar 2020 09:50:29 +0700
> In the commit f73b12812a3d
> ("tipc: improve throughput between nodes in netns"), we're missing a check
> to handle TIPC_DIRECT_MSG type, it's still using old sending mechanism for
> this message type. So, throughput improvement is not significant as
> expected.
>
> Besides that, when sending a large message with that type, we're also
> handle wrong receiving queue, it should be enqueued in socket receiving
> instead of multicast messages.
>
> Fix this by adding the missing case for TIPC_DIRECT_MSG.
>
> Fixes: f73b12812a3d ("tipc: improve throughput between nodes in netns")
> Reported-by: Tuong Lien <tuong.t.lien@dektech.com.au>
> Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
> Acked-by: Jon Maloy <jmaloy@redhat.com>
Applied to net-next, thank you.
prev parent reply other threads:[~2020-03-26 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 2:50 [net-next] tipc: Add a missing case of TIPC_DIRECT_MSG type Hoang Le
2020-03-26 18:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326.112117.296057933553903521.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hoang.h.le@dektech.com.au \
--cc=jmaloy@redhat.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=tuong.t.lien@dektech.com.au \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.