From: Peter Chen <peter.chen@nxp.com>
To: Colin King <colin.king@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sekhar Nori <nsekhar@ti.com>, Roger Quadros <rogerq@ti.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Pawel Laszczak <pawell@cadence.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: cdns3: make signed 1 bit bitfields unsigned
Date: Thu, 26 Mar 2020 11:46:42 +0000 [thread overview]
Message-ID: <20200326114703.GC23632@b29397-desktop> (raw)
In-Reply-To: <20200325125041.94769-1-colin.king@canonical.com>
On 20-03-25 12:50:41, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The signed 1 bit bitfields should be unsigned, so make them unsigned.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/cdns3/cdns3-ti.c | 4 ++--
> drivers/usb/cdns3/gadget.h | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-ti.c b/drivers/usb/cdns3/cdns3-ti.c
> index c6a79ca15858..5685ba11480b 100644
> --- a/drivers/usb/cdns3/cdns3-ti.c
> +++ b/drivers/usb/cdns3/cdns3-ti.c
> @@ -52,8 +52,8 @@ enum modestrap_mode { USBSS_MODESTRAP_MODE_NONE,
> struct cdns_ti {
> struct device *dev;
> void __iomem *usbss;
> - int usb2_only:1;
> - int vbus_divider:1;
> + unsigned usb2_only:1;
> + unsigned vbus_divider:1;
> struct clk *usb2_refclk;
> struct clk *lpm_clk;
> };
> diff --git a/drivers/usb/cdns3/gadget.h b/drivers/usb/cdns3/gadget.h
> index f003a7801872..bf2828e4df2c 100644
> --- a/drivers/usb/cdns3/gadget.h
> +++ b/drivers/usb/cdns3/gadget.h
> @@ -1199,7 +1199,7 @@ struct cdns3_aligned_buf {
> void *buf;
> dma_addr_t dma;
> u32 size;
> - int in_use:1;
> + unsigned in_use:1;
> struct list_head list;
> };
>
> @@ -1308,8 +1308,8 @@ struct cdns3_device {
> unsigned u2_allowed:1;
> unsigned is_selfpowered:1;
> unsigned setup_pending:1;
> - int hw_configured_flag:1;
> - int wake_up_flag:1;
> + unsigned hw_configured_flag:1;
> + unsigned wake_up_flag:1;
> unsigned status_completion_no_call:1;
> unsigned using_streams:1;
> int out_mem_is_allocated;
> --
Reviewed-by: Peter Chen <peter.chen@nxp.com>
--
Thanks,
Peter Chen
next prev parent reply other threads:[~2020-03-26 11:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 12:50 [PATCH] usb: cdns3: make signed 1 bit bitfields unsigned Colin King
2020-03-26 11:46 ` Peter Chen [this message]
2020-03-26 12:28 ` kbuild test robot
2020-03-26 12:28 ` kbuild test robot
2020-03-26 12:28 ` kbuild test robot
2020-03-26 12:28 ` [RFC PATCH] usb: cdns3: cdns3_clear_register_bit() can be static kbuild test robot
2020-03-26 12:28 ` kbuild test robot
2020-03-26 12:28 ` kbuild test robot
2020-03-26 13:04 ` Greg Kroah-Hartman
2020-03-26 13:04 ` Greg Kroah-Hartman
2020-03-26 13:04 ` Greg Kroah-Hartman
2020-03-27 0:34 ` [kbuild-all] " Rong Chen
2020-03-27 0:34 ` Rong Chen
2020-03-27 0:34 ` [kbuild-all] " Rong Chen
2020-03-27 6:42 ` Greg Kroah-Hartman
2020-03-27 6:42 ` Greg Kroah-Hartman
2020-03-27 6:42 ` [kbuild-all] " Greg Kroah-Hartman
2020-03-27 6:53 ` Rong Chen
2020-03-27 6:53 ` Rong Chen
2020-03-27 6:53 ` [kbuild-all] " Rong Chen
2020-04-02 1:33 ` Rong Chen
2020-04-02 1:33 ` Rong Chen
2020-04-02 1:33 ` [kbuild-all] " Rong Chen
2020-03-27 1:12 ` [kbuild-all] [RFC PATCH v2] " kbuild test robot
2020-03-27 1:12 ` kbuild test robot
2020-03-27 1:12 ` [kbuild-all] " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326114703.GC23632@b29397-desktop \
--to=peter.chen@nxp.com \
--cc=colin.king@canonical.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.