All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
@ 2020-03-26 21:00 Marek Vasut
  2020-03-26 21:00 ` [PATCH 2/2] ARM: dts: stm32: Repair SDMMC2 operation Marek Vasut
  2020-03-30 10:48 ` [PATCH 1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 Patrice CHOTARD
  0 siblings, 2 replies; 4+ messages in thread
From: Marek Vasut @ 2020-03-26 21:00 UTC (permalink / raw)
  To: u-boot

Add another mux option for SDMMC2 pins 4..7, this is used on AV96 board.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
---
 arch/arm/dts/stm32mp157-pinctrl.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm/dts/stm32mp157-pinctrl.dtsi b/arch/arm/dts/stm32mp157-pinctrl.dtsi
index 81a363d93d..e25c44760e 100644
--- a/arch/arm/dts/stm32mp157-pinctrl.dtsi
+++ b/arch/arm/dts/stm32mp157-pinctrl.dtsi
@@ -907,6 +907,27 @@
 				};
 			};
 
+			sdmmc2_d47_pins_b: sdmmc2-d47-1 {
+				pins {
+					pinmux = <STM32_PINMUX('A', 8, AF9)>, /* SDMMC2_D4 */
+						 <STM32_PINMUX('A', 15, AF10)>, /* SDMMC2_D5 */
+						 <STM32_PINMUX('C', 6, AF9)>, /* SDMMC2_D6 */
+						 <STM32_PINMUX('C', 7, AF9)>; /* SDMMC2_D7 */
+					slew-rate = <1>;
+					drive-push-pull;
+					bias-pull-up;
+				};
+			};
+
+			sdmmc2_d47_sleep_pins_b: sdmmc2-d47-sleep-1 {
+				pins {
+					pinmux = <STM32_PINMUX('A', 8, ANALOG)>, /* SDMMC2_D4 */
+						 <STM32_PINMUX('A', 15, ANALOG)>, /* SDMMC2_D5 */
+						 <STM32_PINMUX('C', 6, ANALOG)>, /* SDMMC2_D6 */
+						 <STM32_PINMUX('C', 7, ANALOG)>; /* SDMMC2_D7 */
+				};
+			};
+
 			spdifrx_pins_a: spdifrx-0 {
 				pins {
 					pinmux = <STM32_PINMUX('G', 12, AF8)>; /* SPDIF_IN1 */
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: stm32: Repair SDMMC2 operation
  2020-03-26 21:00 [PATCH 1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 Marek Vasut
@ 2020-03-26 21:00 ` Marek Vasut
  2020-03-30 10:48 ` [PATCH 1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 Patrice CHOTARD
  1 sibling, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2020-03-26 21:00 UTC (permalink / raw)
  To: u-boot

The eMMC uses different pinmux for the top four data lines, use such
a pinmux, otherwise it takes a very long time until the test for 8bit
operation times out. And this is the correct pinmux per schematic too.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
---
 arch/arm/dts/stm32mp157a-avenger96.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/stm32mp157a-avenger96.dts b/arch/arm/dts/stm32mp157a-avenger96.dts
index 3065593bf2..e7505c7596 100644
--- a/arch/arm/dts/stm32mp157a-avenger96.dts
+++ b/arch/arm/dts/stm32mp157a-avenger96.dts
@@ -310,7 +310,7 @@
 
 &sdmmc2 {
 	pinctrl-names = "default";
-	pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a>;
+	pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_b>;
 	non-removable;
 	no-sd;
 	no-sdio;
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
  2020-03-26 21:00 [PATCH 1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 Marek Vasut
  2020-03-26 21:00 ` [PATCH 2/2] ARM: dts: stm32: Repair SDMMC2 operation Marek Vasut
@ 2020-03-30 10:48 ` Patrice CHOTARD
  2020-03-30 10:59   ` Marek Vasut
  1 sibling, 1 reply; 4+ messages in thread
From: Patrice CHOTARD @ 2020-03-30 10:48 UTC (permalink / raw)
  To: u-boot

Hi Marek

On 3/26/20 10:00 PM, Marek Vasut wrote:
> Add another mux option for SDMMC2 pins 4..7, this is used on AV96 board.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> ---
>  arch/arm/dts/stm32mp157-pinctrl.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/dts/stm32mp157-pinctrl.dtsi b/arch/arm/dts/stm32mp157-pinctrl.dtsi
> index 81a363d93d..e25c44760e 100644
> --- a/arch/arm/dts/stm32mp157-pinctrl.dtsi
> +++ b/arch/arm/dts/stm32mp157-pinctrl.dtsi
> @@ -907,6 +907,27 @@
>  				};
>  			};
>  
> +			sdmmc2_d47_pins_b: sdmmc2-d47-1 {
> +				pins {
> +					pinmux = <STM32_PINMUX('A', 8, AF9)>, /* SDMMC2_D4 */
> +						 <STM32_PINMUX('A', 15, AF10)>, /* SDMMC2_D5 */
> +						 <STM32_PINMUX('C', 6, AF9)>, /* SDMMC2_D6 */
> +						 <STM32_PINMUX('C', 7, AF9)>; /* SDMMC2_D7 */
> +					slew-rate = <1>;
> +					drive-push-pull;
> +					bias-pull-up;
> +				};
> +			};
> +
> +			sdmmc2_d47_sleep_pins_b: sdmmc2-d47-sleep-1 {
> +				pins {
> +					pinmux = <STM32_PINMUX('A', 8, ANALOG)>, /* SDMMC2_D4 */
> +						 <STM32_PINMUX('A', 15, ANALOG)>, /* SDMMC2_D5 */
> +						 <STM32_PINMUX('C', 6, ANALOG)>, /* SDMMC2_D6 */
> +						 <STM32_PINMUX('C', 7, ANALOG)>; /* SDMMC2_D7 */
> +				};
> +			};
> +
>  			spdifrx_pins_a: spdifrx-0 {
>  				pins {
>  					pinmux = <STM32_PINMUX('G', 12, AF8)>; /* SPDIF_IN1 */

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
  2020-03-30 10:48 ` [PATCH 1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 Patrice CHOTARD
@ 2020-03-30 10:59   ` Marek Vasut
  0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2020-03-30 10:59 UTC (permalink / raw)
  To: u-boot

On 3/30/20 12:48 PM, Patrice CHOTARD wrote:
> Hi Marek

Hi,

> On 3/26/20 10:00 PM, Marek Vasut wrote:
>> Add another mux option for SDMMC2 pins 4..7, this is used on AV96 board.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Patrick Delaunay <patrick.delaunay@st.com>
>> Cc: Patrice Chotard <patrice.chotard@st.com>
>> ---
>>  arch/arm/dts/stm32mp157-pinctrl.dtsi | 21 +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>> diff --git a/arch/arm/dts/stm32mp157-pinctrl.dtsi b/arch/arm/dts/stm32mp157-pinctrl.dtsi
>> index 81a363d93d..e25c44760e 100644
>> --- a/arch/arm/dts/stm32mp157-pinctrl.dtsi
>> +++ b/arch/arm/dts/stm32mp157-pinctrl.dtsi
>> @@ -907,6 +907,27 @@
>>  				};
>>  			};
>>  
>> +			sdmmc2_d47_pins_b: sdmmc2-d47-1 {
>> +				pins {
>> +					pinmux = <STM32_PINMUX('A', 8, AF9)>, /* SDMMC2_D4 */
>> +						 <STM32_PINMUX('A', 15, AF10)>, /* SDMMC2_D5 */
>> +						 <STM32_PINMUX('C', 6, AF9)>, /* SDMMC2_D6 */
>> +						 <STM32_PINMUX('C', 7, AF9)>; /* SDMMC2_D7 */
>> +					slew-rate = <1>;
>> +					drive-push-pull;
>> +					bias-pull-up;
>> +				};
>> +			};
>> +

Actually, this one is wrong, the AFs are wrong. Lemme send a V2.
The rest of the patches should be OK. Sorry for the mess up.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-30 10:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 21:00 [PATCH 1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 Marek Vasut
2020-03-26 21:00 ` [PATCH 2/2] ARM: dts: stm32: Repair SDMMC2 operation Marek Vasut
2020-03-30 10:48 ` [PATCH 1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 Patrice CHOTARD
2020-03-30 10:59   ` Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.