Re: [net-next v2 09/11] devlink: implement DEVLINK_CMD_REGION_NEW

[Jiri Pirko <jiri@resnulli.us>]

Thu, Mar 26, 2020 at 05:19:30PM CET, jacob.e.keller@intel.com wrote:
>
>
>On 3/26/2020 1:52 AM, Jiri Pirko wrote:
>> Thu, Mar 26, 2020 at 04:51:55AM CET, jacob.e.keller@intel.com wrote:
>> 
>> [...]
>> 
>>> +	err = __devlink_snapshot_id_insert(devlink, snapshot_id);
>>> +	if (err) {
>>> +		return err;
>>> +	}
>>> +
>>> +	err = region->ops->snapshot(devlink, info->extack, &data);
>>> +	if (err)
>>> +		goto snapshot_capture_failure;
>>> +
>>> +	err = __devlink_region_snapshot_create(region, data, snapshot_id);
>>> +	if (err)
>>> +		goto snapshot_create_failure;
>>> +
>>> +	return 0;
>>> +
>>> +snapshot_create_failure:
>>> +	region->ops->destructor(data);
>>> +snapshot_capture_failure:
>> 
>> Eh, this actually should be "err_snapshot_capture" and
>> "err_snapshot_create"
>> 
>
>Sure. It seems a lot of functions use "out" or "nla_put_failure", or

yeah, "nla_put_failure" is a special kind that is used through the net
code.


>other styles.
>
>$grep "^[A-Za-z0-9_]*:" net/core/devlink.c | sort | uniq -c | less
>      1 dump_err:
>      1 err_action_value_put:
>      1 err_action_values_put:
>      1 err_cancel_msg:
>      1 err_group_init:
>      1 err_group_link:
>      1 err_match_value_put:
>      1 err_match_values_put:
>      1 err_resource_put:
>      2 err_stats_alloc:
>      2 err_table_put:
>      1 err_trap_fill:
>      1 err_trap_group_fill:
>      1 err_trap_group_register:
>      1 err_trap_group_verify:
>      1 err_trap_init:
>      1 err_trap_register:
>      1 err_trap_verify:
>      1 free_msg:
>      2 genlmsg_cancel:
>      1 id_increment_failure:
>     34 nla_put_failure:
>      1 nla_put_failure_type_locked:
>     27 out:
>      1 out_cancel_msg:
>      1 out_dev:
>      2 out_free_msg:
>      1 out_unlock:
>      1 param_nest_cancel:
>      1 reporter_nest_cancel:
>      1 resource_put_failure:
>      1 rollback:
>      4 send_done:
>      1 snapshot_capture_failure:
>      1 snapshot_create_failure:
>      3 start_again:
>      9 unlock:
>      1 value_nest_cancel:
>      1 values_list_nest_cancel:
>
>But I'll change these.