From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C26C2D0EE for ; Fri, 27 Mar 2020 04:16:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9507320675 for ; Fri, 27 Mar 2020 04:16:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585282569; bh=MPqAiPXpN5JEkst6TsHe7SkHCTDCe2DIkSuHMQ7/dms=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Ej9a+6e7f/KYL2xXVkMkEf3cRXhou+h27BMOUFKF2BiqgXrYv6t7Orcy6GCEJlL71 DDjBkcjnBGCElOMg4UrKJgx8UBRggwu/l8hiGBPBJGAsxElMLmRczRIa7VJH0UJ8KU m8dIP+xcuaSK5FMzrBUgGc8kjT6mw3H7tKEOxs1U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbgC0EQI (ORCPT ); Fri, 27 Mar 2020 00:16:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:56566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbgC0EQI (ORCPT ); Fri, 27 Mar 2020 00:16:08 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4815520575; Fri, 27 Mar 2020 04:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585282567; bh=MPqAiPXpN5JEkst6TsHe7SkHCTDCe2DIkSuHMQ7/dms=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=quKFvuyz12eu/G9oWjWmPb1R2W8+1AEE+hw7Bl+9O57Uy07ZsDD007nRvzia+GCVv 5MYYmypeP5931n/0LABmOuiShM30MTWgEnAhlTR5dnuJbuMaBv/4KGhv4L7tvj36Pe FKKcQf+OwiuJoRaZ3XyPuHKiAth54sUoaMRotbHo= Date: Thu, 26 Mar 2020 21:16:05 -0700 From: Jakub Kicinski To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jiri Pirko , Andrew Lunn , Florian Fainelli , John Linville , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 02/12] ethtool: provide coalescing parameters with COALESCE_GET request Message-ID: <20200326211605.6f80f9c7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <0d94d1390e886c2d616291c46509fac4cd9eac11.1585267388.git.mkubecek@suse.cz> References: <0d94d1390e886c2d616291c46509fac4cd9eac11.1585267388.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Mar 2020 01:11:57 +0100 (CET) Michal Kubecek wrote: > Implement COALESCE_GET request to get coalescing parameters of a network > device. These are traditionally available via ETHTOOL_GCOALESCE ioctl > request. This commit adds only support for device coalescing parameters, > not per queue coalescing parameters. > > Omit attributes with zero values unless they are declared as supported > (i.e. the corresponding bit in ethtool_ops::supported_coalesce_params is > set). > > Signed-off-by: Michal Kubecek Reviewed-by: Jakub Kicinski