From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/3] mips: Start using ldflags-y for 32/64bit LDFLAGS
Date: Fri, 27 Mar 2020 11:12:31 -0400 [thread overview]
Message-ID: <20200327151231.GG5793@bill-the-cat> (raw)
In-Reply-To: <3d7ad78c-068f-264a-003c-784b01571491@gmail.com>
On Fri, Mar 27, 2020 at 04:08:16PM +0100, Daniel Schwierzeck wrote:
> Hi Tom,
>
> Am 27.03.20 um 14:52 schrieb Tom Rini:
> > To prepare to update our Kbuild logic, start switching some of our cases
> > of adding different bit/endian linker flags via ldflags-y
> >
> > Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > arch/mips/config.mk | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/mips/config.mk b/arch/mips/config.mk
> > index 9d3a84539a7d..f8180dcd396c 100644
> > --- a/arch/mips/config.mk
> > +++ b/arch/mips/config.mk
> > @@ -4,8 +4,8 @@
> > # Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> >
> > ifdef CONFIG_SYS_BIG_ENDIAN
> > -32bit-emul := elf32btsmip
> > -64bit-emul := elf64btsmip
> > +ldflags-$(CONFIG_32BIT) += -m elf32btsmip
> > +ldflags-$(CONFIG_64BIT) += -m elf64btsmip
> > 32bit-bfd := elf32-tradbigmips
> > 64bit-bfd := elf64-tradbigmips
> > PLATFORM_CPPFLAGS += -EB
> > @@ -13,8 +13,8 @@ PLATFORM_LDFLAGS += -EB
> > endif
> >
> > ifdef CONFIG_SYS_LITTLE_ENDIAN
> > -32bit-emul := elf32ltsmip
> > -64bit-emul := elf64ltsmip
> > +ldflags-$(CONFIG_32BIT) += -m elf32btsmip
> > +ldflags-$(CONFIG_64BIT) += -m elf64btsmip
> > 32bit-bfd := elf32-tradlittlemips
> > 64bit-bfd := elf64-tradlittlemips
> > PLATFORM_CPPFLAGS += -EL
> > @@ -23,18 +23,18 @@ endif
> >
> > ifdef CONFIG_32BIT
> > PLATFORM_CPPFLAGS += -mabi=32
> > -PLATFORM_LDFLAGS += -m $(32bit-emul)
> > OBJCOPYFLAGS += -O $(32bit-bfd)
> > CONFIG_STANDALONE_LOAD_ADDR ?= 0x80200000
> > endif
> >
> > ifdef CONFIG_64BIT
> > PLATFORM_CPPFLAGS += -mabi=64
> > -PLATFORM_LDFLAGS += -m$(64bit-emul)
> > OBJCOPYFLAGS += -O $(64bit-bfd)
> > CONFIG_STANDALONE_LOAD_ADDR ?= 0xffffffff80200000
> > endif
> >
> > +PLATFORM_LDFLAGS += $(ldflags-y)
>
> is this change really necessary? I'd like to keep that in sync with MIPS
> Linux. And MIPS Linux simply changed to
>
> KBUILD_LDFLAGS += -m $(ld-emul)
Pretty sure it was the only way I got ci20 to continue to build. I'll
go try a one-off local branch and re-confirm now that I have other
issues resolved too. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200327/d81f2cbd/attachment.sig>
next prev parent reply other threads:[~2020-03-27 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 13:52 [PATCH 1/3] riscv: Start using ldflags-y for 32/64bit LDFLAGS Tom Rini
2020-03-27 13:52 ` [PATCH 2/3] mips: " Tom Rini
2020-03-27 15:08 ` Daniel Schwierzeck
2020-03-27 15:12 ` Tom Rini [this message]
2020-03-27 15:17 ` Tom Rini
2020-03-27 13:52 ` [PATCH 3/3] kconfig / kbuild: Re-sync with Linux 4.19 Tom Rini
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA46EE197@ATCPCS16.andestech.com>
2020-03-30 3:01 ` [PATCH 1/3] riscv: Start using ldflags-y for 32/64bit LDFLAGS Rick Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327151231.GG5793@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.