From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, xiaolong.ye@intel.com, Wei Zhao <wei.zhao1@intel.com>
Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix issue for e-tag defination
Date: Mon, 30 Mar 2020 14:33:23 +0800 [thread overview]
Message-ID: <20200330063323.5371-1-wei.zhao1@intel.com> (raw)
In-Reply-To: <1582760662-9263-1-git-send-email-wei.zhao1@intel.com>
An issue has been caused after change definations of bool,
we had better use uint16_t to define e-tag ethertype, not 8
bits length bool, that patch will change bool bits length, which
introduce a bug for etag/etag_strip for x550 NIC. So change
to the 16 bits defination.
Cc: stable@dpdk.org
Fixes: ad43b7bce95b ("net/ixgbe: avoid multiple definitions of bool")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
v2:
-add more info and find root cause for this issue
---
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h
index e1cd8fd16..c5d0e0912 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.h
+++ b/drivers/net/ixgbe/ixgbe_ethdev.h
@@ -358,7 +358,7 @@ struct ixgbe_l2_tn_info {
struct rte_hash *hash_handle;
bool e_tag_en; /* e-tag enabled */
bool e_tag_fwd_en; /* e-tag based forwarding enabled */
- bool e_tag_ether_type; /* ether type for e-tag */
+ uint16_t e_tag_ether_type; /* ether type for e-tag */
};
struct rte_flow {
--
2.19.1
next prev parent reply other threads:[~2020-03-30 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 23:44 [dpdk-dev] [PATCH] net/ixgbe: fix issue for change definitions of bool Wei Zhao
2020-02-27 1:57 ` Ye Xiaolong
2020-02-27 3:09 ` Ye Xiaolong
2020-02-27 3:13 ` Zhao1, Wei
2020-03-30 6:33 ` Wei Zhao [this message]
2020-03-30 7:37 ` [dpdk-dev] [PATCH v2] net/ixgbe: fix issue for e-tag defination Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330063323.5371-1-wei.zhao1@intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.