From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2993C43331 for ; Mon, 30 Mar 2020 18:45:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A53E820714 for ; Mon, 30 Mar 2020 18:45:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="f0UCPHg1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727148AbgC3SpU (ORCPT ); Mon, 30 Mar 2020 14:45:20 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:39232 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726385AbgC3SpU (ORCPT ); Mon, 30 Mar 2020 14:45:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CXPdVTiCp/UQlA1jkwVcGXrb4CsvV02soGOt8kpgYnw=; b=f0UCPHg1Gf1xj0tFDxE3HFlJ2m xKOE3rozjJmI7jBEsw6TNxh8RkcB0DwAt9EmfigF8mElTVo0L9qpKlkve/cgNc5FMYy7+JksQyWkY JSY0zuL5mk/+1yeJAlR5yER8geO9K9DkRCyNzd51ruwxgnaUShK5jdZS0LUjPQI+d+HI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jIzPR-000790-F5; Mon, 30 Mar 2020 20:45:17 +0200 Date: Mon, 30 Mar 2020 20:45:17 +0200 From: Andrew Lunn To: Daniel Mack Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH] net: dsa: mv88e6xxx: don't force settings on CPU port Message-ID: <20200330184517.GH23477@lunn.ch> References: <20200327200153.GR3819@lunn.ch> <20200327211821.GT3819@lunn.ch> <1bff1da3-8c9d-55c6-3408-3ae1c3943041@zonque.org> <20200327235220.GV3819@lunn.ch> <64462bcf-6c0c-af4f-19f4-d203daeabec3@zonque.org> <20200330134010.GA23477@lunn.ch> <7a777bc3-9109-153a-a735-e36718c06db5@zonque.org> <20200330182307.GG23477@lunn.ch> <82d8e785-ec00-d815-3b11-b694aa9f4d50@zonque.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82d8e785-ec00-d815-3b11-b694aa9f4d50@zonque.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Even when the MAC is *forced* to 1G, which is what the code currently > does? Sorry for the dumb question, but wich code path would undo these > settings? Where would you start debugging this? You could add #define DEBUG to the top of driver/net/phy/phylink.c. You should then see what phylink is up to, including it trying to configure the MAC. You can add additional printk to mv88e6xxx_mac_link_up(), mv88e6xxx_mac_link_down(), mv88e6xxx_mac_config(), etc. Andrew