All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Julien Grall <jgrall@amazon.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	dfaggioli@suse.com,
	Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>
Subject: [Xen-devel] [PATCH 5/8] tools/ocaml: libxc: Check error return in stub_xc_vcpu_context_get()
Date: Mon, 30 Mar 2020 20:21:54 +0100	[thread overview]
Message-ID: <20200330192157.1335-6-julien@xen.org> (raw)
In-Reply-To: <20200330192157.1335-1-julien@xen.org>

From: Julien Grall <jgrall@amazon.com>

xc_vcpu_getcontext() may fail to retrieve the vcpu context. Rather than
ignoring the return value, check it and throw an error if needed.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 tools/ocaml/libs/xc/xenctrl_stubs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 904da45c4f..0fdbeac158 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -497,6 +497,8 @@ CAMLprim value stub_xc_vcpu_context_get(value xch, value domid,
 	vcpu_guest_context_any_t ctxt;
 
 	ret = xc_vcpu_getcontext(_H(xch), _D(domid), Int_val(cpu), &ctxt);
+	if ( ret < 0 )
+		failwith_xc(_H(xch));
 
 	context = caml_alloc_string(sizeof(ctxt));
 	memcpy(String_val(context), (char *) &ctxt.c, sizeof(ctxt.c));
-- 
2.17.1



  parent reply	other threads:[~2020-03-30 19:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30 19:21 [Xen-devel] [PATCH 0/8] Fix build with using OCaml 4.06.1 and -safe-string Julien Grall
2020-03-30 19:21 ` [Xen-devel] [PATCH 1/8] xen/guest_access: Harden copy_to_guest_offset to prevent const dest operand Julien Grall
2020-03-31  7:26   ` Jan Beulich
2020-03-31 19:13     ` Julien Grall
2020-04-01  6:48       ` Jan Beulich
2020-04-01  8:53         ` Julien Grall
2020-04-01  9:25       ` Jan Beulich
2020-04-01 21:10         ` Julien Grall
2020-03-30 19:21 ` [Xen-devel] [PATCH 2/8] xen/public: sysctl: set_parameter.params and debug.keys should be const Julien Grall
2020-03-31  7:30   ` Jan Beulich
2020-04-01  9:53     ` Julien Grall
2020-03-30 19:21 ` [Xen-devel] [PATCH 3/8] tools/libxc: misc: Mark const the parameter 'keys' of xc_send_debug_keys() Julien Grall
2020-03-31 11:14   ` Ian Jackson
2020-03-30 19:21 ` [Xen-devel] [PATCH 4/8] tools/libxc: misc: Mark const the parameter 'params' of xc_set_parameters() Julien Grall
2020-03-31 11:14   ` Ian Jackson
2020-03-30 19:21 ` Julien Grall [this message]
2020-03-30 19:21 ` [Xen-devel] [PATCH 6/8] tools/ocaml: libxb: Harden stub_header_of_string() Julien Grall
2020-03-30 19:21 ` [Xen-devel] [PATCH 7/8] tools/ocaml: libxb: Avoid to use String_val() when value is bytes Julien Grall
2020-03-30 19:21 ` [Xen-devel] [PATCH 8/8] tools/ocaml: Fix stubs build when OCaml has been compiled with -safe-string Julien Grall
2020-03-31 11:17 ` [PATCH 0/8] Fix build with using OCaml 4.06.1 and -safe-string Ian Jackson
2020-04-01 22:00   ` Julien Grall
2020-04-16 11:25 ` Julien Grall
2020-04-16 13:25   ` Christian Lindig
2020-04-20 12:13     ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200330192157.1335-6-julien@xen.org \
    --to=julien@xen.org \
    --cc=christian.lindig@citrix.com \
    --cc=dave@recoil.org \
    --cc=dfaggioli@suse.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jgrall@amazon.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.