From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6809468497850007552 X-Received: by 2002:a17:902:82c5:: with SMTP id u5mr15242017plz.254.1585611552849; Mon, 30 Mar 2020 16:39:12 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:a17:902:a9c1:: with SMTP id b1ls13613105plr.11.gmail; Mon, 30 Mar 2020 16:39:11 -0700 (PDT) X-Google-Smtp-Source: APiQypIFQPik5edsHwVdqoxaOoEhP0BkmWa0GYQwQzPc/+8tOZTANou4mQ+9dOsfhINcYNej+8ey X-Received: by 2002:a17:90a:a40d:: with SMTP id y13mr634119pjp.116.1585611551437; Mon, 30 Mar 2020 16:39:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585611551; cv=none; d=google.com; s=arc-20160816; b=DE0syd4KmZq1brCXDCTtF9rtbg20Jn3Oyw0MR42ApHMDR6bsFLLy9ocTCgH/0e+UR7 IkMWmDE9MsrIsxwdF06DVJTBRJRxyF1kn34C0O2tzvO/7fQTH8SfvhIzeroUvTyIPjLc enns0VP4Qm1dTwX17ff6SkqMo7esd52i+rpAH5q0ZM/NtcAXkrHqC5YyBYv7n8z5b/eH qbhgmZrIaKnMhXS4INJrgT2MSd17AUz7ZBqeel9eDfUeVL1KPTQgSv0aO+4i88S72C18 oIXmvrFiRMmhA57iH0adpIRzJxx8Bsw9hHw1BGNNc2/xb1/r73oB5n5pw694IN7Fv5EW kkNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=8pxcOcpWIjOsjvgQ2bPjI1PSxQO2talzx0dTKC3l3L4=; b=MNMeyqpuYskpHlltmZDTIBn6YdF81T5ocq0zTYMY8lB9D/kxi+XnacHuSL+OZ5KX2p Taq4R/9HoPzRNoR3/lemKtiEkTxsrvvrTWHWoNmOnxMSFPG/KcPpnjVfjcMQ8V3rZM8J RUQJX0drzv1S/HpdHVbJT5JlRGzEeDxOs5dSytqsIpuH2sIi30zz5nR3GRC8KlhRP3FJ A+7RzicjHzvuK4jXEQmuSom2mXtrbZwn41E1CAfs599Y/ldAgNyA/kZp5twUECnBp8Rl NFAlrxawJFVp+aNktBuG6RR6sG639IdnBIjAg/BdRDUVMzoQi5v08aNCZOK+1vM0TPjw aj8A== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kC396dGl; spf=pass (google.com: domain of jbwyatt4@gmail.com designates 2607:f8b0:4864:20::644 as permitted sender) smtp.mailfrom=jbwyatt4@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com. [2607:f8b0:4864:20::644]) by gmr-mx.google.com with ESMTPS id y5si986374plr.4.2020.03.30.16.39.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2020 16:39:11 -0700 (PDT) Received-SPF: pass (google.com: domain of jbwyatt4@gmail.com designates 2607:f8b0:4864:20::644 as permitted sender) client-ip=2607:f8b0:4864:20::644; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kC396dGl; spf=pass (google.com: domain of jbwyatt4@gmail.com designates 2607:f8b0:4864:20::644 as permitted sender) smtp.mailfrom=jbwyatt4@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-pl1-x644.google.com with SMTP id a23so7401191plm.1 for ; Mon, 30 Mar 2020 16:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8pxcOcpWIjOsjvgQ2bPjI1PSxQO2talzx0dTKC3l3L4=; b=kC396dGlRCxUqoC3rJNV8jYlr3wqGleHoOt8yaq0lqdFuSL0Of16FsXKKU/XAzjRzQ pGr1zi0rM3ZE/SaC2B6/PAr+/2ZQqOEZAGp+D/WVuWmWZ4xEf8IcV7mXVnb02PBsvupX CHxglgpl3K+eoPJiil0sa5ALVtYysVoMzlAYeCJ/qnMQRPOA1L+N3kQPNfsyH/+2scAI ClvPIhuCrU46Qewkjl9zTWIbb5+Kea0kx/IM86bKYa2Jda6D4aRmlt7YUQo+Gl7ob9mE bGAD7gHZRqNlmlLJmgzmXlK6vBTvfa50NHi1NJ4VmIpaww4cizFs4PqMlmIuMBgKTFLh D3dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8pxcOcpWIjOsjvgQ2bPjI1PSxQO2talzx0dTKC3l3L4=; b=kigSSpcFhbaZmA8dQ8oIQGSqf/RNPNaGBGnqrLv0+v5izfBVexCvRFrK05w79Qbxcb s/myX/1FRhfwqMyDNnEmLzrYskNXW4T4SEl4vgLf6jgrsJmYsmpYygTvF91HSqPGWdYN T8vRj5oW9eYE/FEl2NsaV3p5jaInRppw+bpqBAkxu5VVPorG6rlrXywgG9wMvWNrWOwL 17pl19Ld9xiuh3d0TMpAPxHuu4Kdr0lceTXmbtGJ7nn31vhTEzC4VJ9yC1pCfFJjcSVU rutK8FT5ShhdW1vo9gdBjBOlvknutn1njUMdt0pOkjqoLzx2xefdOADpCVwMsPH3Hjne 4TcA== X-Gm-Message-State: AGi0Pub2J/qQQsf91G76RsNssMxH1bC36O/2JbMtSI2wEamjr4upjAaX vqv4rQWv88C/cYTE90VUjUtt/8j5Qq4LNQ== X-Received: by 2002:a17:90a:fd90:: with SMTP id cx16mr613505pjb.41.1585611550428; Mon, 30 Mar 2020 16:39:10 -0700 (PDT) Return-Path: Received: from OptiPlexFedora.fios-router.home ([47.144.161.84]) by smtp.gmail.com with ESMTPSA id a15sm10961425pfg.77.2020.03.30.16.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 16:39:09 -0700 (PDT) From: "John B. Wyatt IV" To: outreachy-kernel@googlegroups.com, Julia Lawall , Stefano Brivio , Forest Bond , Greg Kroah-Hartman , Quentin Deslandes , Colin Ian King , Malcolm Priestley , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: "John B. Wyatt IV" Subject: [PATCH v8] staging: vt6656: add error code handling to unused variable Date: Mon, 30 Mar 2020 16:39:00 -0700 Message-Id: <20200330233900.36938-1-jbwyatt4@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add error code handling to unused 'ret' variable that was never used. Return an error code from functions called within vnt_radio_power_on. Issue reported by coccinelle (coccicheck). Suggested-by: Quentin Deslandes Suggested-by: Stefano Brivio Reviewed-by: Quentin Deslandes Signed-off-by: John B. Wyatt IV --- v8: Fix trailing space reported by checkpatch Fix alignment issue suggested by: Stefano Brivio v7: Move an if check. Suggested by Stefano Brivio v6: Forgot to add all the v5 code to commit. v5: Remove Suggested-by: Julia Lawall above seperator line. Remove break; statement in switch block. break; removal checked by both gcc compile and checkpatch. Suggested by Stefano Brivio v4: Move Suggested-by: Julia Lawall above seperator line. Add Reviewed-by tag as requested by Quentin Deslandes. v3: Forgot to add v2 code changes to commit. v2: Replace goto statements with return. Remove last if check because it was unneeded. Suggested-by: Julia Lawall drivers/staging/vt6656/card.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c index dc3ab10eb630..1ef1f6b22195 100644 --- a/drivers/staging/vt6656/card.c +++ b/drivers/staging/vt6656/card.c @@ -723,9 +723,13 @@ int vnt_radio_power_on(struct vnt_private *priv) { int ret = 0; - vnt_exit_deep_sleep(priv); + ret = vnt_exit_deep_sleep(priv); + if (ret) + return ret; - vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON); + ret = vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON); + if (ret) + return ret; switch (priv->rf_type) { case RF_AL2230: @@ -734,14 +738,14 @@ int vnt_radio_power_on(struct vnt_private *priv) case RF_VT3226: case RF_VT3226D0: case RF_VT3342A0: - vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL, - (SOFTPWRCTL_SWPE2 | SOFTPWRCTL_SWPE3)); - break; + ret = vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL, + (SOFTPWRCTL_SWPE2 | + SOFTPWRCTL_SWPE3)); + if (ret) + return ret; } - vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD); - - return ret; + return vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD); } void vnt_set_bss_mode(struct vnt_private *priv) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F382C2D0EE for ; Mon, 30 Mar 2020 23:39:15 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E2D220771 for ; Mon, 30 Mar 2020 23:39:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kC396dGl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E2D220771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3509523B9B; Mon, 30 Mar 2020 23:39:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iMqv7Ly17OSk; Mon, 30 Mar 2020 23:39:12 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id A61AA23B2B; Mon, 30 Mar 2020 23:39:12 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id CBF411BF329 for ; Mon, 30 Mar 2020 23:39:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id C5BBD8869B for ; Mon, 30 Mar 2020 23:39:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MefCSWP2LfJL for ; Mon, 30 Mar 2020 23:39:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by hemlock.osuosl.org (Postfix) with ESMTPS id 5344188699 for ; Mon, 30 Mar 2020 23:39:11 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id t4so1434360plq.12 for ; Mon, 30 Mar 2020 16:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8pxcOcpWIjOsjvgQ2bPjI1PSxQO2talzx0dTKC3l3L4=; b=kC396dGlRCxUqoC3rJNV8jYlr3wqGleHoOt8yaq0lqdFuSL0Of16FsXKKU/XAzjRzQ pGr1zi0rM3ZE/SaC2B6/PAr+/2ZQqOEZAGp+D/WVuWmWZ4xEf8IcV7mXVnb02PBsvupX CHxglgpl3K+eoPJiil0sa5ALVtYysVoMzlAYeCJ/qnMQRPOA1L+N3kQPNfsyH/+2scAI ClvPIhuCrU46Qewkjl9zTWIbb5+Kea0kx/IM86bKYa2Jda6D4aRmlt7YUQo+Gl7ob9mE bGAD7gHZRqNlmlLJmgzmXlK6vBTvfa50NHi1NJ4VmIpaww4cizFs4PqMlmIuMBgKTFLh D3dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8pxcOcpWIjOsjvgQ2bPjI1PSxQO2talzx0dTKC3l3L4=; b=HDiUw0DLxjHFHGH/S3Wa4PaB/wuamMgXHyqhmLztIpbzYjs5j0qZ7730bgRGpWAPwW EAhVsxRBMH774aWMaZx9UKtXmVQnm+1aM8P7k1Vais0vauBbmQHYceNm5+zL16+Fah3o Ywwg88M8n17hFZDx7SfltO0p/yRfY9uYB4FprcQlB0ijGTp5LYxs9MTYGfbvxSeVYUVp wSu/cbYWPrw6ZFtIte6nTLMZqXLiBBA5sxBqgWyfngUWcM0zIm7x8r0HJeS2TNMHDhhI R6an/wMsto+LtKQgakrTzMFuZCuxm4kc/9YwQq3Ww6JJ0eDv7qiShI5EqDmkA3b8vWQ6 4XxQ== X-Gm-Message-State: AGi0PuYCf4Hv0HelBO0y7pV/i1f+ghnbmRd0zovI6nMEa+ZToUpd0LWI 9sY3MXJNamMZnvoLH+bYDd0= X-Google-Smtp-Source: APiQypKlxoA/ONi9CDJo1gNa6nL6Gyga6987LV8cZAMa12hHmHi/qm3/QxQYl7+FwWhNV03EMLwK8A== X-Received: by 2002:a17:90a:fd90:: with SMTP id cx16mr613505pjb.41.1585611550428; Mon, 30 Mar 2020 16:39:10 -0700 (PDT) Received: from OptiPlexFedora.fios-router.home ([47.144.161.84]) by smtp.gmail.com with ESMTPSA id a15sm10961425pfg.77.2020.03.30.16.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 16:39:09 -0700 (PDT) From: "John B. Wyatt IV" To: outreachy-kernel@googlegroups.com, Julia Lawall , Stefano Brivio , Forest Bond , Greg Kroah-Hartman , Quentin Deslandes , Colin Ian King , Malcolm Priestley , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v8] staging: vt6656: add error code handling to unused variable Date: Mon, 30 Mar 2020 16:39:00 -0700 Message-Id: <20200330233900.36938-1-jbwyatt4@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "John B. Wyatt IV" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Add error code handling to unused 'ret' variable that was never used. Return an error code from functions called within vnt_radio_power_on. Issue reported by coccinelle (coccicheck). Suggested-by: Quentin Deslandes Suggested-by: Stefano Brivio Reviewed-by: Quentin Deslandes Signed-off-by: John B. Wyatt IV --- v8: Fix trailing space reported by checkpatch Fix alignment issue suggested by: Stefano Brivio v7: Move an if check. Suggested by Stefano Brivio v6: Forgot to add all the v5 code to commit. v5: Remove Suggested-by: Julia Lawall above seperator line. Remove break; statement in switch block. break; removal checked by both gcc compile and checkpatch. Suggested by Stefano Brivio v4: Move Suggested-by: Julia Lawall above seperator line. Add Reviewed-by tag as requested by Quentin Deslandes. v3: Forgot to add v2 code changes to commit. v2: Replace goto statements with return. Remove last if check because it was unneeded. Suggested-by: Julia Lawall drivers/staging/vt6656/card.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c index dc3ab10eb630..1ef1f6b22195 100644 --- a/drivers/staging/vt6656/card.c +++ b/drivers/staging/vt6656/card.c @@ -723,9 +723,13 @@ int vnt_radio_power_on(struct vnt_private *priv) { int ret = 0; - vnt_exit_deep_sleep(priv); + ret = vnt_exit_deep_sleep(priv); + if (ret) + return ret; - vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON); + ret = vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON); + if (ret) + return ret; switch (priv->rf_type) { case RF_AL2230: @@ -734,14 +738,14 @@ int vnt_radio_power_on(struct vnt_private *priv) case RF_VT3226: case RF_VT3226D0: case RF_VT3342A0: - vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL, - (SOFTPWRCTL_SWPE2 | SOFTPWRCTL_SWPE3)); - break; + ret = vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL, + (SOFTPWRCTL_SWPE2 | + SOFTPWRCTL_SWPE3)); + if (ret) + return ret; } - vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD); - - return ret; + return vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD); } void vnt_set_bss_mode(struct vnt_private *priv) -- 2.25.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel