From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE60C43331 for ; Tue, 31 Mar 2020 04:33:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D6AA2071A for ; Tue, 31 Mar 2020 04:33:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N9Ny6dmV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vCDPFgxT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D6AA2071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RTsYC1N/L5IkcRC+NTzauy61JWEBTbSySwRyLH7alQU=; b=N9Ny6dmVay0hzO poXusAbYgi18m+nQbTmuM5EnvpEx5JsW1vOk35Pzyj9Pra1AZWv7VZCM9qGE7KuDkiGr7uRyCdqt0 LUonevW/Dp01qtyravdG9jFlxcOMyjW4LfdIYb52DaVxbV3NsEXdaqqyxBgzv0yEe0Z7lH2jWctqW 8B5ZBSu3DEKsRnRgI0977o2ZUud3L6mIM3IZye67PXtfelDpsYj43ZI+moGte6jLW1KXHcECXh/Vc j7J5zHPYelCZY3vIt0GXO9dqNdjBJhcPKzXy96ahkDdsxqstNB/3GVA8hPPIKpOjE2NFddJLxHqFw gDkoRW9P+HDQ07sbZawA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJ8b0-0007ud-7V; Tue, 31 Mar 2020 04:33:50 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJ8aw-0007u1-Kr for linux-arm-kernel@lists.infradead.org; Tue, 31 Mar 2020 04:33:47 +0000 Received: by mail-pl1-x641.google.com with SMTP id h11so7638058plk.7 for ; Mon, 30 Mar 2020 21:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KHj39y5fdH9Uv51+nxOzjv4v2uANykWV5CO0Mi85N6I=; b=vCDPFgxTTiWo5KOk4iJIiAKcSrHBIauour4dahxzyJugvrzYps5/MAuuYqxjfbDw/L vIYUm9DmpFEqeQts9+aLrGP8wGqW99S6SHoNgxNaIv/ZfefuVRD/2NdqWyNXS36XQM8H BCAEiQSZ9faEw9fyxplPGCRUgl4NSnR6BlX+lIPS18Qy4RrGTb+r81D4AlE/ZEPu3hhI Fl1vlZUsf/mJTkJl7MmlG7CnPtliOj/5RPyCxZ5cwBhUK1HD7meNEA7ub3RNiyWabNhQ v9UMXgxhQGtsgVPLXSFMnGSwMeMtzYoYrqwSOjqbx2/rErLLIURuOL4r/Q4NF2UbRHXt NjSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KHj39y5fdH9Uv51+nxOzjv4v2uANykWV5CO0Mi85N6I=; b=E6S65XhTdqltfHx5B8WpxpI+elYoqwgZ7L+ES7hLGZAVrINyLS6l2wDKQi1VQsiELK ggGZ3n1XzLfNITWONvMXujCPONdysvbZYxqAo3TfL8tEja5RXS5MeG8gRWbOgc28txzC F5+DJe0uKh+qVfjyWA0rQbju8PZytATFmcSnNQrFSUGvswZwkioFCmjgymgnN99zGP13 fyuhI8kWd87wn/D5oaIuOueSXrDvSbHORz90iD6l+CkPobKPDfskMzWyCY8gcoNqj3Zk iECRjtqiE6VMyy12TA31v7Rxb/6fSClCVrNot/KCVv7NxhqNvDRmsFx+gbNI/x6e17ym A5KA== X-Gm-Message-State: AGi0Pubi6xR5ouavv+m4c89oX1CZNYCAlsw+2/5f6aZL53u1/NnyMEaJ Mb7X8d+bbVozlZwJ0U//Uc/gjeQaRg== X-Google-Smtp-Source: APiQypIPQMHA7xCDE37J1tm9V8LvIzT94pFuOlkJKUqV9VsympLng+X6jurgccQ3cev51Tc0bVEhjg== X-Received: by 2002:a17:90a:868b:: with SMTP id p11mr1769236pjn.34.1585629225956; Mon, 30 Mar 2020 21:33:45 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:630f:1337:c28:2530:7bf4:e941]) by smtp.gmail.com with ESMTPSA id go9sm850663pjb.27.2020.03.30.21.33.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Mar 2020 21:33:45 -0700 (PDT) Date: Tue, 31 Mar 2020 10:03:38 +0530 From: Manivannan Sadhasivam To: Marek Vasut Subject: Re: [PATCH V2 06/22] ARM: dts: stm32: Repair SDMMC1 operation on AV96 Message-ID: <20200331043338.GH14274@Mani-XPS-13-9360> References: <20200331005701.283998-1-marex@denx.de> <20200331005701.283998-7-marex@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200331005701.283998-7-marex@denx.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200330_213346_697178_2737D9E9 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , Patrice Chotard , Patrick Delaunay , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 31, 2020 at 02:56:45AM +0200, Marek Vasut wrote: > The SD uses different pinmux for the D123DIRline, use such a pinmux, > otherwise there is a pinmux collision on the AV96. Add missing SD > voltage regulator switch. > > Signed-off-by: Marek Vasut > Cc: Alexandre Torgue > Cc: Manivannan Sadhasivam > Cc: Maxime Coquelin > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > --- > V2: Disable SDR104, it seems unstable thus far > --- > arch/arm/boot/dts/stm32mp157a-avenger96.dts | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/stm32mp157a-avenger96.dts b/arch/arm/boot/dts/stm32mp157a-avenger96.dts > index e58653ccb60f..04280353fdbe 100644 > --- a/arch/arm/boot/dts/stm32mp157a-avenger96.dts > +++ b/arch/arm/boot/dts/stm32mp157a-avenger96.dts > @@ -77,6 +77,20 @@ led6 { > default-state = "off"; > }; > }; > + > + sd_switch: regulator-sd_switch { > + compatible = "regulator-gpio"; > + regulator-name = "sd_switch"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2900000>; > + regulator-type = "voltage"; > + regulator-always-on; > + > + gpios = <&gpioi 5 GPIO_ACTIVE_HIGH>; > + gpios-states = <0>; > + states = <1800000 0x1>, > + <2900000 0x0>; > + }; > }; > > ðernet0 { > @@ -305,9 +319,9 @@ &rtc { > > &sdmmc1 { > pinctrl-names = "default", "opendrain", "sleep"; > - pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_a>; > - pinctrl-1 = <&sdmmc1_b4_od_pins_a>; > - pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>; > + pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>; > + pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_dir_pins_b>; > + pinctrl-2 = <&sdmmc1_b4_sleep_pins_a &sdmmc1_dir_sleep_pins_b>; > cd-gpios = <&gpioi 8 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; The "cd-gpios" change is not present in mainline. I think you can add it to this patch as well with relevant commit description. With that fixed, Reviewed-by: Manivannan Sadhasivam Thanks, Mani > disable-wp; > st,sig-dir; > @@ -315,6 +329,7 @@ &sdmmc1 { > st,use-ckin; > bus-width = <4>; > vmmc-supply = <&vdd_sd>; > + vqmmc-supply = <&sd_switch>; > status = "okay"; > }; > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel