From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D9F1C2D0EE for ; Tue, 31 Mar 2020 08:25:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E72620848 for ; Tue, 31 Mar 2020 08:25:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="n5ImjXWj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729425AbgCaIZG (ORCPT ); Tue, 31 Mar 2020 04:25:06 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:46624 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbgCaIZG (ORCPT ); Tue, 31 Mar 2020 04:25:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uHShfLyk+r2NtFiic0iTbAAoXgVtjC6D8jlMuvt3O8Y=; b=n5ImjXWjPQw04c5uquw6cwixCv e578jSqqpyF1jjdfvtctP4mO/a2CkqhQt617UeqcG7Ay5zz1VUbguxYUT4llyz+IPv+tjjh96qvHc 0MH0wHtTkTJzBE8gaXP/KWsnZQVIKJJeCBxhgBAiZZqKYqelGWUnVX8hEZ92zxLhxjUBaynD1v2tD pmqARRpdJOUaIWWZp3UygBsNnMB8s5/qz9kchbFuncuN6HUolUeX/tXdGO9Q8aqlgJNNHDDLd7Svp IgnxLJzB3IDZR998Iik9Bvhg8SJ0QMNEkVSXlnqbcLX78f76825WKxw8lW0i7k0w4ByB79f7Z5U+x cYLji1bQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJCCn-0004wb-I0; Tue, 31 Mar 2020 08:25:05 +0000 Date: Tue, 31 Mar 2020 01:25:05 -0700 From: Christoph Hellwig To: axboe@kernel.dk, tj@kernel.org, linux-block@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [RFC PATCH v2 2/3] bio: track timestamp of submitting bio the disk driver Message-ID: <20200331082505.GA14655@infradead.org> References: <20200327062859.GA12588@192.168.3.9> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200327062859.GA12588@192.168.3.9> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Mar 27, 2020 at 02:28:59PM +0800, Weiping Zhang wrote: > Change-Id: Ibb9caf20616f83e111113ab5c824c05930c0e523 > Signed-off-by: Weiping Zhang This needs a commit description and loose the weird change id. I also think oyu need to fins a way to not bloat the bio even more, cgroup is a really bad offender for bio size. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC PATCH v2 2/3] bio: track timestamp of submitting bio the disk driver Date: Tue, 31 Mar 2020 01:25:05 -0700 Message-ID: <20200331082505.GA14655@infradead.org> References: <20200327062859.GA12588@192.168.3.9> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uHShfLyk+r2NtFiic0iTbAAoXgVtjC6D8jlMuvt3O8Y=; b=n5ImjXWjPQw04c5uquw6cwixCv e578jSqqpyF1jjdfvtctP4mO/a2CkqhQt617UeqcG7Ay5zz1VUbguxYUT4llyz+IPv+tjjh96qvHc 0MH0wHtTkTJzBE8gaXP/KWsnZQVIKJJeCBxhgBAiZZqKYqelGWUnVX8hEZ92zxLhxjUBaynD1v2tD pmqARRpdJOUaIWWZp3UygBsNnMB8s5/qz9kchbFuncuN6HUolUeX/tXdGO9Q8aqlgJNNHDDLd7Svp IgnxLJzB3IDZR998Iik9Bvhg8SJ0QMNEkVSXlnqbcLX78f76825WKxw8lW0i7k0w4ByB79f7Z5U+x cYLji1bQ==; Content-Disposition: inline In-Reply-To: <20200327062859.GA12588-Q0ErXNX1RuZvRBSd6SXyqg@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Fri, Mar 27, 2020 at 02:28:59PM +0800, Weiping Zhang wrote: > Change-Id: Ibb9caf20616f83e111113ab5c824c05930c0e523 > Signed-off-by: Weiping Zhang This needs a commit description and loose the weird change id. I also think oyu need to fins a way to not bloat the bio even more, cgroup is a really bad offender for bio size.