From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B060C2D0EE for ; Tue, 31 Mar 2020 09:00:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 075F6208E0 for ; Tue, 31 Mar 2020 09:00:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585645239; bh=Gyq5CPIWhGyETl7u146YtvZnj20MLETTWKjndr0vl/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cZOMBb8iOORuxaAY9qDIxLbv/b3K/dlWwgFY2au+0AK5mgFd0qX6U/WU1Cqa+loqq EynpjIVABzAl6tao11hqScSjMD0iH8QuhtwjuIwi3ujw8w3YPsRCMmBhVzgsGp4+CS jf+D4TyVwdnOomZYW1tLxnVit2KBmcsbWE4e8lBw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730422AbgCaJAi (ORCPT ); Tue, 31 Mar 2020 05:00:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:39388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729425AbgCaJAh (ORCPT ); Tue, 31 Mar 2020 05:00:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00025208E0; Tue, 31 Mar 2020 09:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585645237; bh=Gyq5CPIWhGyETl7u146YtvZnj20MLETTWKjndr0vl/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fRMEqYMF049U6BPmtLGXcpeTsy6Vx6Zgc+tVcx/9VbIwVzhc31s1iHj8oF1HCc2/Z MWqcGWSsUsmXIr7gl/r04P99T875W9lfiPWxBnSAh2LqOr5hFIMXh8iBz9iES9TDuq eo73Q4PmzSr/O6NrNDzEUYyVFfoaZcVCNtNLV+kE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiujun Huang , Johan Hovold , syzbot+37ba33391ad5f3935bbd@syzkaller.appspotmail.com Subject: [PATCH 5.6 06/23] USB: serial: io_edgeport: fix slab-out-of-bounds read in edge_interrupt_callback Date: Tue, 31 Mar 2020 10:59:18 +0200 Message-Id: <20200331085311.333835590@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200331085308.098696461@linuxfoundation.org> References: <20200331085308.098696461@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiujun Huang commit 57aa9f294b09463492f604feaa5cc719beaace32 upstream. Fix slab-out-of-bounds read in the interrupt-URB completion handler. The boundary condition should be (length - 1) as we access data[position + 1]. Reported-and-tested-by: syzbot+37ba33391ad5f3935bbd@syzkaller.appspotmail.com Signed-off-by: Qiujun Huang Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/io_edgeport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/serial/io_edgeport.c +++ b/drivers/usb/serial/io_edgeport.c @@ -710,7 +710,7 @@ static void edge_interrupt_callback(stru /* grab the txcredits for the ports if available */ position = 2; portNumber = 0; - while ((position < length) && + while ((position < length - 1) && (portNumber < edge_serial->serial->num_ports)) { txCredits = data[position] | (data[position+1] << 8); if (txCredits) {