From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80B08C2D0EE for ; Tue, 31 Mar 2020 11:23:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B56D2145D for ; Tue, 31 Mar 2020 11:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585653836; bh=lD3eupwCIf1bt+praqpgfwp2g8jfARiz+0CQ8P3uEnc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fvsIQG1cie8FMNhxy37umr1BUMTjIAokd0HW9HwQSrHgAmPTkjicJhvMtYa6FA3OC wmlNCkic1ezmqQfdAExNapopQAVsuwINtq+wN+0nU8LClnUvS1hJcGyQ9PE+3Pgf7q tvEfkweOaXnx4tO1ux9qf62jtYXKQDXXfz9JPamc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730598AbgCaLXz (ORCPT ); Tue, 31 Mar 2020 07:23:55 -0400 Received: from foss.arm.com ([217.140.110.172]:51458 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730180AbgCaLXz (ORCPT ); Tue, 31 Mar 2020 07:23:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D07581FB; Tue, 31 Mar 2020 04:23:54 -0700 (PDT) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2D0D23F52E; Tue, 31 Mar 2020 04:23:54 -0700 (PDT) Date: Tue, 31 Mar 2020 12:23:52 +0100 From: Mark Brown To: Akash Asthana Cc: gregkh@linuxfoundation.org, agross@kernel.org, bjorn.andersson@linaro.org, wsa@the-dreams.de, mark.rutland@arm.com, robh+dt@kernel.org, georgi.djakov@linaro.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, swboyd@chromium.org, mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, mka@chromium.org, dianders@chromium.org, evgreen@chromium.org Subject: Re: [PATCH V3 7/8] spi: spi-qcom-qspi: Add interconnect support Message-ID: <20200331112352.GB4802@sirena.org.uk> References: <1585652976-17481-1-git-send-email-akashast@codeaurora.org> <1585652976-17481-8-git-send-email-akashast@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V0207lvV8h4k8FAm" Content-Disposition: inline In-Reply-To: <1585652976-17481-8-git-send-email-akashast@codeaurora.org> X-Cookie: It's later than you think. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org --V0207lvV8h4k8FAm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 31, 2020 at 04:39:35PM +0530, Akash Asthana wrote: > + /* > + * Set BW quota for CPU as driver supports FIFO mode only. > + * Assume peak bw as twice of avg bw. > + */ > + ctrl->avg_bw_cpu = Bps_to_icc(speed_hz); > + ctrl->peak_bw_cpu = Bps_to_icc(2 * speed_hz); I thought you were going to factor this best guess handling of peak bandwidth out into the core? --V0207lvV8h4k8FAm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6DKEgACgkQJNaLcl1U h9B9hgf5AfEd6Av5eJV6b95BDWCIFAj1+wz2OaVN0NIjeR3P7zOSgWAMdMedmZob 9LpFAExIyjOzIowmVDD87xJhROhY3Iia8tBydoWKw8ti5bHoppSc3K1MtShRhhiA A/QsZgJ2wzcc79ieuX1MVJTxy8kFu45U7X7r4RCGvKiYQtcTx5xkH093jWWxLMcP DwTDCdJHBNvJb9g6erGk+bx01d6OnoPksVXY4XKU+eb+PbRhpwQZ0XJEI7Kbd0Vm 3OVvZY3idWN2KgNQVsYizxU4GDBGjKJ2/bNBO9SrUIRxuqqLRGfO3S2SKBxhRlE1 8Dx6OW56nNqySqFehTkxj8IUxmdgZg== =ZtH5 -----END PGP SIGNATURE----- --V0207lvV8h4k8FAm-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH V3 7/8] spi: spi-qcom-qspi: Add interconnect support Date: Tue, 31 Mar 2020 12:23:52 +0100 Message-ID: <20200331112352.GB4802@sirena.org.uk> References: <1585652976-17481-1-git-send-email-akashast@codeaurora.org> <1585652976-17481-8-git-send-email-akashast@codeaurora.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V0207lvV8h4k8FAm" Return-path: Content-Disposition: inline In-Reply-To: <1585652976-17481-8-git-send-email-akashast-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Akash Asthana Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, agross-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, swboyd-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, evgreen-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org List-Id: linux-i2c@vger.kernel.org --V0207lvV8h4k8FAm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 31, 2020 at 04:39:35PM +0530, Akash Asthana wrote: > + /* > + * Set BW quota for CPU as driver supports FIFO mode only. > + * Assume peak bw as twice of avg bw. > + */ > + ctrl->avg_bw_cpu = Bps_to_icc(speed_hz); > + ctrl->peak_bw_cpu = Bps_to_icc(2 * speed_hz); I thought you were going to factor this best guess handling of peak bandwidth out into the core? --V0207lvV8h4k8FAm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6DKEgACgkQJNaLcl1U h9B9hgf5AfEd6Av5eJV6b95BDWCIFAj1+wz2OaVN0NIjeR3P7zOSgWAMdMedmZob 9LpFAExIyjOzIowmVDD87xJhROhY3Iia8tBydoWKw8ti5bHoppSc3K1MtShRhhiA A/QsZgJ2wzcc79ieuX1MVJTxy8kFu45U7X7r4RCGvKiYQtcTx5xkH093jWWxLMcP DwTDCdJHBNvJb9g6erGk+bx01d6OnoPksVXY4XKU+eb+PbRhpwQZ0XJEI7Kbd0Vm 3OVvZY3idWN2KgNQVsYizxU4GDBGjKJ2/bNBO9SrUIRxuqqLRGfO3S2SKBxhRlE1 8Dx6OW56nNqySqFehTkxj8IUxmdgZg== =ZtH5 -----END PGP SIGNATURE----- --V0207lvV8h4k8FAm--