From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54922C43331 for ; Tue, 31 Mar 2020 12:50:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28F2D20848 for ; Tue, 31 Mar 2020 12:50:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28F2D20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJGLr-0002i7-C9 for qemu-devel@archiver.kernel.org; Tue, 31 Mar 2020 08:50:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37876) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJGL3-0001oT-M9 for qemu-devel@nongnu.org; Tue, 31 Mar 2020 08:49:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJGL1-0004cS-Fx for qemu-devel@nongnu.org; Tue, 31 Mar 2020 08:49:53 -0400 Received: from charlie.dont.surf ([128.199.63.193]:48694) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJGKy-0004X9-Su; Tue, 31 Mar 2020 08:49:49 -0400 Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id 9240CBF5F1; Tue, 31 Mar 2020 12:49:47 +0000 (UTC) Date: Tue, 31 Mar 2020 14:49:44 +0200 From: Klaus Birkelund Jensen To: Maxim Levitsky Subject: Re: [PATCH v6 12/42] nvme: add support for the get log page command Message-ID: <20200331124944.qbyu4qzivdjm5ms2@apples.localdomain> References: <20200316142928.153431-1-its@irrelevant.dk> <20200316142928.153431-13-its@irrelevant.dk> <20200331054109.zq6yluixcnpdbust@apples.localdomain> <4107ea7ca5b4810d1d5d9e498fbd336a17a57936.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4107ea7ca5b4810d1d5d9e498fbd336a17a57936.camel@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 128.199.63.193 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Beata Michalska , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , Keith Busch , Javier Gonzalez Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mar 31 12:45, Maxim Levitsky wrote: > On Tue, 2020-03-31 at 07:41 +0200, Klaus Birkelund Jensen wrote: > > On Mar 25 12:40, Maxim Levitsky wrote: > > > On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > > > > From: Klaus Jensen > > > > > > > > Add support for the Get Log Page command and basic implementations of > > > > the mandatory Error Information, SMART / Health Information and Firmware > > > > Slot Information log pages. > > > > > > > > In violation of the specification, the SMART / Health Information log > > > > page does not persist information over the lifetime of the controller > > > > because the device has no place to store such persistent state. > > > > > > > > Note that the LPA field in the Identify Controller data structure > > > > intentionally has bit 0 cleared because there is no namespace specific > > > > information in the SMART / Health information log page. > > > > > > > > Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, > > > > Section 5.10 ("Get Log Page command"). > > > > > > > > Signed-off-by: Klaus Jensen > > > > Acked-by: Keith Busch > > > > --- > > > > hw/block/nvme.c | 138 +++++++++++++++++++++++++++++++++++++++++- > > > > hw/block/nvme.h | 10 +++ > > > > hw/block/trace-events | 2 + > > > > 3 files changed, 149 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > > > > index 64c42101df5c..83ff3fbfb463 100644 > > > > > > > > +static uint16_t nvme_error_info(NvmeCtrl *n, NvmeCmd *cmd, uint32_t buf_len, > > > > + uint64_t off, NvmeRequest *req) > > > > +{ > > > > + uint32_t trans_len; > > > > + uint64_t prp1 = le64_to_cpu(cmd->dptr.prp1); > > > > + uint64_t prp2 = le64_to_cpu(cmd->dptr.prp2); > > > > + uint8_t errlog[64]; > > > > > > I'll would replace this with sizeof(NvmeErrorLogEntry) > > > (and add NvmeErrorLogEntry to the nvme.h), just for the sake of consistency, > > > and in case we end up reporting some errors to the log in the future. > > > > > > > NvmeErrorLog is already in nvme.h; Fixed to actually use it. > True that! I'll would rename it to NvmeErrorLogEntry to be honest > (in that patch that added many nvme spec changes) but I don't mind > keeping it as is as well. > It is used in the block driver (block/nvme.c) as well, and I'd rather not involved that too much in this series.