From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30F8C2D0F0 for ; Tue, 31 Mar 2020 14:31:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA20420784 for ; Tue, 31 Mar 2020 14:31:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585665101; bh=GbwCITgX7+ViF0nZ/SYsVFgrvblVn2yk006z/KmssC4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tXTyCwJODdFBFU5MXs+CCh2yJUqqJ0J1aMuvcTJOY4GQHouB6fiOjWfeUqJEkZrhz r3sLuxi3AMLtWJKTVY/ZqtXWPbZt//poRmhCo+uTJ1OD9aSzOqWZn4VlfKojS/4hPy kkC+pAofsiYrXpKoh11AkrxRfu79r3QoBKUKm1rM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731109AbgCaObk (ORCPT ); Tue, 31 Mar 2020 10:31:40 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42322 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730810AbgCaObk (ORCPT ); Tue, 31 Mar 2020 10:31:40 -0400 Received: by mail-pf1-f196.google.com with SMTP id 22so10398519pfa.9; Tue, 31 Mar 2020 07:31:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZV1KfwgGLtoEiy3TkAg/zZ6KIB+b40AZeOP0Q0XHWHU=; b=V/ckHBGkUv+faIurBZm6aWkZw8kSgZv/W32v4KnRdHa3ae4XdBHYzRPzrKlm7N82wq 6tazVl/vkU+thJE5va34cOiRLqXI+R3LequulATdCwnwje5A/mPVtrJnOyq4p3pf+N9S 6uWJsnj/KTpQ1pK/7N4Q+NxBYqFyKHZkQdcOF0mhY4JoKZyZWXFW2Ndgx2WFDfwdP7BJ MWVTD+PhVu28Po06FEONOF8zzI2Aj4+b5+JgzeW01tA5XH5tqXtmeLUAUSeVh5znX8tv nuwpsyj7NAZxrbSl1bRHfMPNFXEo8WFUJSSR/58GUmp2BhDV82HXg3nLf+31df9865qf SKrg== X-Gm-Message-State: ANhLgQ32zP88vMIDbn+syR3TVqKLMyTETGr3z6aXJ7+BTrJztNOUYEjX VrYUXRNssY1JKm3NBQ5+tmA= X-Google-Smtp-Source: ADFU+vv9QG+JNLAPq5Hse2+XL1fqy/ETctrMBCrfQRW4WYOaoKGlkutwe7Dhv7pKCEUfjkAs3IExyg== X-Received: by 2002:a63:7e10:: with SMTP id z16mr18195431pgc.412.1585665098929; Tue, 31 Mar 2020 07:31:38 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id 184sm469375pge.71.2020.03.31.07.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 07:31:35 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 0DA0940277; Tue, 31 Mar 2020 14:31:35 +0000 (UTC) Date: Tue, 31 Mar 2020 14:31:35 +0000 From: Luis Chamberlain To: Vlastimil Babka Cc: Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner Subject: Re: [PATCH 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line Message-ID: <20200331143134.GY11244@42.do-not-panic.com> References: <20200330115535.3215-1-vbabka@suse.cz> <20200330115535.3215-2-vbabka@suse.cz> <20200330224422.GX11244@42.do-not-panic.com> <8146e3d0-89c3-7f79-f786-084c58282c85@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8146e3d0-89c3-7f79-f786-084c58282c85@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2020 at 09:42:46AM +0200, Vlastimil Babka wrote: > On 3/31/20 12:44 AM, Luis Chamberlain wrote: > > > > This is wonderful when we think about existing sysctls which have > > corresponding silly boot params that do the same thing. However, shoving > > a boot param capability down every possible built-in sysctl brings > > forward support considerations we should take serious, as this would > > add a new user interface and we'll have to support it. > > Hmm, if I boot with an initramfs with init process that does mount /proc and set > some sysctl there as the very first thing, then this will be almost the same > moment as my patch does it. There is no further kernel initialization in > between. So with your logic we already do support all non-modular sysctls to be > set so early. Yes, true. Then by all means: Reviewed-by: Luis Chamberlain Luis