From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25069C2D0F1 for ; Tue, 31 Mar 2020 17:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9DDB2145D for ; Tue, 31 Mar 2020 17:52:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Y8M8ls/T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726164AbgCaRwL (ORCPT ); Tue, 31 Mar 2020 13:52:11 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:40273 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726194AbgCaRwL (ORCPT ); Tue, 31 Mar 2020 13:52:11 -0400 Received: by mail-pl1-f196.google.com with SMTP id h11so8383402plk.7 for ; Tue, 31 Mar 2020 10:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8b3WnZTTNBaPOMDMuIqGibWI1hhFOK4GHv2gbbqH4E4=; b=Y8M8ls/Tz7mnjRLag509mDzeltvzbPfcMsTSXBMrI+rpRmUwjDK1+CkgdTXqyfEhYg bZEmgXc4O3cx/xXKnPBfH/o2pWD2O/S4zuGQxn0PpL3D29pjVHIayEPExxJPcBvm/j+Y ds26z93uo/7QI7TKsqvz0V98b+PNUYfX8DFiY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8b3WnZTTNBaPOMDMuIqGibWI1hhFOK4GHv2gbbqH4E4=; b=f7PDGvY+B4A4k2Nk25XRMdkDxon1Fs3FycJ8I3g5qU8t9nd9aDgpBiLo0a8R4+LVXH f27JpajDhB+0IXVvxB7bxpXAQLWwNIZ5VKQRK4NL5D5/ntYocveBJUBLtiVNWB/pM6ab VaN4bYLi8SCvck2C/bteMPZdAdcDmNf97ewrHkMTF7kOcGzfgtX4e+fQJz6kZLmT2Apm lv70V1fQTrkVI1naX96+HVSwiBI0KIS7GMHiUbzpYZ/XG/gzR6ejADxPVljQ0RXdSoSU MYkOfCIMXrPxmnQehaGIc47qPbwUGSkfEqNh29N770hO691M83f+cAbZUe+wrSPKaLUw +c9Q== X-Gm-Message-State: AGi0PuYTvNEIuezkRp/xAYPwQSOPNJGh4OJ1YlesgF7R8Vzmhn9x+Ynr gqHcBBvS/JLPXfdmVEwhgeNZOA== X-Google-Smtp-Source: APiQypLEDWt9naJrmZKRq7qNu/KyQtF3te2IOlxl2ISxISRKDGfkLLJ/GDPPR5qiBNFBaLE8bdDXAw== X-Received: by 2002:a17:90a:e398:: with SMTP id b24mr16072pjz.113.1585677129802; Tue, 31 Mar 2020 10:52:09 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id i187sm12910140pfg.33.2020.03.31.10.52.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2020 10:52:09 -0700 (PDT) Date: Tue, 31 Mar 2020 10:52:07 -0700 From: Matthias Kaehlcke To: Akash Asthana Cc: gregkh@linuxfoundation.org, agross@kernel.org, bjorn.andersson@linaro.org, wsa@the-dreams.de, broonie@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, georgi.djakov@linaro.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, swboyd@chromium.org, mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, dianders@chromium.org, evgreen@chromium.org Subject: Re: [PATCH V3 2/8] soc: qcom: geni: Support for ICC voting Message-ID: <20200331175207.GG199755@google.com> References: <1585652976-17481-1-git-send-email-akashast@codeaurora.org> <1585652976-17481-3-git-send-email-akashast@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1585652976-17481-3-git-send-email-akashast@codeaurora.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Akash, On Tue, Mar 31, 2020 at 04:39:30PM +0530, Akash Asthana wrote: > Add necessary macros and structure variables to support ICC BW > voting from individual SE drivers. > > Signed-off-by: Akash Asthana > --- > Changes in V2: > - As per Bjorn's comment dropped enums for ICC paths, given the three > paths individual members > > Changes in V3: > - Add geni_icc_get, geni_icc_vote_on and geni_icc_vote_off as helper API. > - Add geni_icc_path structure in common header > > drivers/soc/qcom/qcom-geni-se.c | 98 +++++++++++++++++++++++++++++++++++++++++ > include/linux/qcom-geni-se.h | 36 +++++++++++++++ > 2 files changed, 134 insertions(+) > > diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c > index 7d622ea..9344c14 100644 > --- a/drivers/soc/qcom/qcom-geni-se.c > +++ b/drivers/soc/qcom/qcom-geni-se.c > @@ -720,6 +720,104 @@ void geni_se_rx_dma_unprep(struct geni_se *se, dma_addr_t iova, size_t len) > } > EXPORT_SYMBOL(geni_se_rx_dma_unprep); > > +int geni_icc_get(struct geni_se *se, const char *icc_core, const char *icc_cpu, > + const char *icc_ddr) > +{ > + if (icc_core) { > + se->to_core.path = devm_of_icc_get(se->dev, "qup-core"); > + if (IS_ERR(se->to_core.path)) > + return PTR_ERR(se->to_core.path); > + } > + > + if (icc_cpu) { > + se->from_cpu.path = devm_of_icc_get(se->dev, "qup-config"); > + if (IS_ERR(se->from_cpu.path)) > + return PTR_ERR(se->from_cpu.path); > + } > + > + if (icc_ddr) { > + se->to_ddr.path = devm_of_icc_get(se->dev, "qup-memory"); > + if (IS_ERR(se->to_ddr.path)) > + return PTR_ERR(se->to_ddr.path); > + } > + > + return 0; > +} > +EXPORT_SYMBOL(geni_icc_get); > + > +int geni_icc_vote_on(struct geni_se *se) > +{ > + int ret; > + > + if (se->to_core.path) { > + ret = icc_set_bw(se->to_core.path, se->to_core.avg_bw, > + se->to_core.peak_bw); > + if (ret) { > + dev_err_ratelimited(se->dev, "%s: ICC BW voting failed for core\n", > + __func__); > + return ret; > + } > + } > + > + if (se->from_cpu.path) { > + ret = icc_set_bw(se->from_cpu.path, se->from_cpu.avg_bw, > + se->from_cpu.peak_bw); > + if (ret) { > + dev_err_ratelimited(se->dev, "%s: ICC BW voting failed for cpu\n", > + __func__); > + return ret; > + } > + } > + > + if (se->to_ddr.path) { > + ret = icc_set_bw(se->to_ddr.path, se->to_ddr.avg_bw, > + se->to_ddr.peak_bw); > + if (ret) { > + dev_err_ratelimited(se->dev, "%s: ICC BW voting failed for ddr\n", > + __func__); > + return ret; > + } > + } With an array of 'struct geni_icc_path' pointers the above could be reduced to: for (i = 0; i < ARRAY_SIZE(se->icc_paths); i++) { if (!se->icc_paths[i]) continue; ret = icc_set_bw(se->icc_paths[i]->path, se->icc_paths[i]->avg_bw, se->icc_paths[i]->peak_bw); if (ret) { dev_err_ratelimited(se->dev, "%s: ICC BW voting failed\n", __func__); return ret; } } similar for geni_icc_vote_off() It's just a suggestion, looks also good to me as is. Reviewed-by: Matthias Kaehlcke From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH V3 2/8] soc: qcom: geni: Support for ICC voting Date: Tue, 31 Mar 2020 10:52:07 -0700 Message-ID: <20200331175207.GG199755@google.com> References: <1585652976-17481-1-git-send-email-akashast@codeaurora.org> <1585652976-17481-3-git-send-email-akashast@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1585652976-17481-3-git-send-email-akashast-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Akash Asthana Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, agross-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, swboyd-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, evgreen-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hi Akash, On Tue, Mar 31, 2020 at 04:39:30PM +0530, Akash Asthana wrote: > Add necessary macros and structure variables to support ICC BW > voting from individual SE drivers. > > Signed-off-by: Akash Asthana > --- > Changes in V2: > - As per Bjorn's comment dropped enums for ICC paths, given the three > paths individual members > > Changes in V3: > - Add geni_icc_get, geni_icc_vote_on and geni_icc_vote_off as helper API. > - Add geni_icc_path structure in common header > > drivers/soc/qcom/qcom-geni-se.c | 98 +++++++++++++++++++++++++++++++++++++++++ > include/linux/qcom-geni-se.h | 36 +++++++++++++++ > 2 files changed, 134 insertions(+) > > diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c > index 7d622ea..9344c14 100644 > --- a/drivers/soc/qcom/qcom-geni-se.c > +++ b/drivers/soc/qcom/qcom-geni-se.c > @@ -720,6 +720,104 @@ void geni_se_rx_dma_unprep(struct geni_se *se, dma_addr_t iova, size_t len) > } > EXPORT_SYMBOL(geni_se_rx_dma_unprep); > > +int geni_icc_get(struct geni_se *se, const char *icc_core, const char *icc_cpu, > + const char *icc_ddr) > +{ > + if (icc_core) { > + se->to_core.path = devm_of_icc_get(se->dev, "qup-core"); > + if (IS_ERR(se->to_core.path)) > + return PTR_ERR(se->to_core.path); > + } > + > + if (icc_cpu) { > + se->from_cpu.path = devm_of_icc_get(se->dev, "qup-config"); > + if (IS_ERR(se->from_cpu.path)) > + return PTR_ERR(se->from_cpu.path); > + } > + > + if (icc_ddr) { > + se->to_ddr.path = devm_of_icc_get(se->dev, "qup-memory"); > + if (IS_ERR(se->to_ddr.path)) > + return PTR_ERR(se->to_ddr.path); > + } > + > + return 0; > +} > +EXPORT_SYMBOL(geni_icc_get); > + > +int geni_icc_vote_on(struct geni_se *se) > +{ > + int ret; > + > + if (se->to_core.path) { > + ret = icc_set_bw(se->to_core.path, se->to_core.avg_bw, > + se->to_core.peak_bw); > + if (ret) { > + dev_err_ratelimited(se->dev, "%s: ICC BW voting failed for core\n", > + __func__); > + return ret; > + } > + } > + > + if (se->from_cpu.path) { > + ret = icc_set_bw(se->from_cpu.path, se->from_cpu.avg_bw, > + se->from_cpu.peak_bw); > + if (ret) { > + dev_err_ratelimited(se->dev, "%s: ICC BW voting failed for cpu\n", > + __func__); > + return ret; > + } > + } > + > + if (se->to_ddr.path) { > + ret = icc_set_bw(se->to_ddr.path, se->to_ddr.avg_bw, > + se->to_ddr.peak_bw); > + if (ret) { > + dev_err_ratelimited(se->dev, "%s: ICC BW voting failed for ddr\n", > + __func__); > + return ret; > + } > + } With an array of 'struct geni_icc_path' pointers the above could be reduced to: for (i = 0; i < ARRAY_SIZE(se->icc_paths); i++) { if (!se->icc_paths[i]) continue; ret = icc_set_bw(se->icc_paths[i]->path, se->icc_paths[i]->avg_bw, se->icc_paths[i]->peak_bw); if (ret) { dev_err_ratelimited(se->dev, "%s: ICC BW voting failed\n", __func__); return ret; } } similar for geni_icc_vote_off() It's just a suggestion, looks also good to me as is. Reviewed-by: Matthias Kaehlcke