From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A6A7C2D0F2 for ; Tue, 31 Mar 2020 18:49:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00109207FF for ; Tue, 31 Mar 2020 18:49:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eMrdhT/q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726290AbgCaSto (ORCPT ); Tue, 31 Mar 2020 14:49:44 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:38902 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbgCaStn (ORCPT ); Tue, 31 Mar 2020 14:49:43 -0400 Received: by mail-pj1-f65.google.com with SMTP id m15so1459639pje.3 for ; Tue, 31 Mar 2020 11:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FR8ai6OEFNnFMOGot7XfHged9ha79/NcwHyPaC6Zbwc=; b=eMrdhT/qP31mz6ElSVLxdGt16tmdCiwcHVSd6xDtLHUptLILvWkMm++hmvVqM/JPi/ 8nFoewrfF+mxkk0rkCHK1UmGXpJvN3IDAi+KfvxAYv8yJqjdLmapL1HdSqCMIvVNt9IW aYh1LdkINaKXdhA9dGSkxjL36bTYU1T61+ggc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FR8ai6OEFNnFMOGot7XfHged9ha79/NcwHyPaC6Zbwc=; b=oJjw0c69kM+8YQ0GTVpR5k57cK4Qj59T40PbFcPJXZ81cosrb+uvF2FacTHMopsNyS NnBptU4S/ApA9wydtetiMb9BipUsNzcUUWG4mWSFW/9CDU9+ckzSwpiAENf7e4n6tmHN LZBxatptJKp2hO/OzYkhCDKx2HAbk4hMESUSCkEVAqSGxqOrodh1mqkaiLuHjxq4NQd3 gxcWj+eZ88gqNuU7jDpXvDk0qKngnFetcDWI4MFgHiY7RhVK14+E6/6hMf8WmrUj20bF UNPfjFM1fYL3RlHcFQtxvFn1f0ysaS8WobL4l79FA0z2gv8MoioVjVWA97gIftGMr9Ok Ytsg== X-Gm-Message-State: AGi0PuaMXq9RoNVbF6qh6AAII9Mk2fO+rL7VUg2aYYG7N675bMRJefxF 8mneUDUwrLO9/Ptjlmr4tUR39g== X-Google-Smtp-Source: APiQypJRxT61RTFX4IkaJ3JmMkwZxMMGvWWRvLCrRvi42md6UNMe9jGvgAheR5m4rs1P0C+DQhpFAQ== X-Received: by 2002:a17:90a:c001:: with SMTP id p1mr350441pjt.86.1585680581150; Tue, 31 Mar 2020 11:49:41 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id x71sm12937792pfd.129.2020.03.31.11.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2020 11:49:40 -0700 (PDT) Date: Tue, 31 Mar 2020 11:49:39 -0700 From: Matthias Kaehlcke To: Akash Asthana Cc: gregkh@linuxfoundation.org, agross@kernel.org, bjorn.andersson@linaro.org, wsa@the-dreams.de, broonie@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, georgi.djakov@linaro.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, swboyd@chromium.org, mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, dianders@chromium.org, evgreen@chromium.org Subject: Re: [PATCH V3 4/8] i2c: i2c-qcom-geni: Add interconnect support Message-ID: <20200331184939.GI199755@google.com> References: <1585652976-17481-1-git-send-email-akashast@codeaurora.org> <1585652976-17481-5-git-send-email-akashast@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1585652976-17481-5-git-send-email-akashast@codeaurora.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Akash, On Tue, Mar 31, 2020 at 04:39:32PM +0530, Akash Asthana wrote: > Get the interconnect paths for I2C based Serial Engine device > and vote according to the bus speed of the driver. > > Signed-off-by: Akash Asthana > --- > Changes in V2: > - As per Bjorn's comment, removed se == NULL check from geni_i2c_icc_get > - As per Bjorn's comment, removed code to set se->icc_path* to NULL in failure > - As per Bjorn's comment, introduced and using devm_of_icc_get API for getting > path handle > - As per Matthias comment, added error handling for icc_set_bw call > > Changes in V3: > - As per Matthias comment, use common library APIs defined in geni-se > driver for ICC functionality. > > drivers/i2c/busses/i2c-qcom-geni.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index 18d1e4f..373c2ca 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -557,6 +557,26 @@ static int geni_i2c_probe(struct platform_device *pdev) > gi2c->adap.dev.of_node = dev->of_node; > strlcpy(gi2c->adap.name, "Geni-I2C", sizeof(gi2c->adap.name)); > > + ret = geni_icc_get(&gi2c->se, "qup-core", "qup-config", "qup-memory"); > + if (ret) > + return ret; > + /* > + * Set the bus quota for core and cpu to a reasonable value for > + * register access. > + * Set quota for DDR based on bus speed, assume peak requirement > + * as twice of avg bw. > + */ > + gi2c->se.to_core.avg_bw = GENI_DEFAULT_BW; > + gi2c->se.to_core.peak_bw = Bps_to_icc(CORE_2X_100_MHZ); > + gi2c->se.from_cpu.avg_bw = GENI_DEFAULT_BW; > + gi2c->se.from_cpu.peak_bw = GENI_DEFAULT_BW; > + gi2c->se.to_ddr.avg_bw = Bps_to_icc(gi2c->clk_freq_out); > + gi2c->se.to_ddr.peak_bw = Bps_to_icc(2 * gi2c->clk_freq_out); > + > + ret = geni_icc_vote_on(&gi2c->se); > + if (ret) > + return ret; > + > ret = geni_se_resources_on(&gi2c->se); > if (ret) { > dev_err(dev, "Error turning on resources %d\n", ret); I think you need to call geni_icc_vote_off() here and in other error paths. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH V3 4/8] i2c: i2c-qcom-geni: Add interconnect support Date: Tue, 31 Mar 2020 11:49:39 -0700 Message-ID: <20200331184939.GI199755@google.com> References: <1585652976-17481-1-git-send-email-akashast@codeaurora.org> <1585652976-17481-5-git-send-email-akashast@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1585652976-17481-5-git-send-email-akashast-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Akash Asthana Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, agross-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, swboyd-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, evgreen-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hi Akash, On Tue, Mar 31, 2020 at 04:39:32PM +0530, Akash Asthana wrote: > Get the interconnect paths for I2C based Serial Engine device > and vote according to the bus speed of the driver. > > Signed-off-by: Akash Asthana > --- > Changes in V2: > - As per Bjorn's comment, removed se == NULL check from geni_i2c_icc_get > - As per Bjorn's comment, removed code to set se->icc_path* to NULL in failure > - As per Bjorn's comment, introduced and using devm_of_icc_get API for getting > path handle > - As per Matthias comment, added error handling for icc_set_bw call > > Changes in V3: > - As per Matthias comment, use common library APIs defined in geni-se > driver for ICC functionality. > > drivers/i2c/busses/i2c-qcom-geni.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index 18d1e4f..373c2ca 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -557,6 +557,26 @@ static int geni_i2c_probe(struct platform_device *pdev) > gi2c->adap.dev.of_node = dev->of_node; > strlcpy(gi2c->adap.name, "Geni-I2C", sizeof(gi2c->adap.name)); > > + ret = geni_icc_get(&gi2c->se, "qup-core", "qup-config", "qup-memory"); > + if (ret) > + return ret; > + /* > + * Set the bus quota for core and cpu to a reasonable value for > + * register access. > + * Set quota for DDR based on bus speed, assume peak requirement > + * as twice of avg bw. > + */ > + gi2c->se.to_core.avg_bw = GENI_DEFAULT_BW; > + gi2c->se.to_core.peak_bw = Bps_to_icc(CORE_2X_100_MHZ); > + gi2c->se.from_cpu.avg_bw = GENI_DEFAULT_BW; > + gi2c->se.from_cpu.peak_bw = GENI_DEFAULT_BW; > + gi2c->se.to_ddr.avg_bw = Bps_to_icc(gi2c->clk_freq_out); > + gi2c->se.to_ddr.peak_bw = Bps_to_icc(2 * gi2c->clk_freq_out); > + > + ret = geni_icc_vote_on(&gi2c->se); > + if (ret) > + return ret; > + > ret = geni_se_resources_on(&gi2c->se); > if (ret) { > dev_err(dev, "Error turning on resources %d\n", ret); I think you need to call geni_icc_vote_off() here and in other error paths.