From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F8F4C2D0F3 for ; Wed, 1 Apr 2020 06:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C9FF206F5 for ; Wed, 1 Apr 2020 06:38:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B0s5qLL2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731905AbgDAGib (ORCPT ); Wed, 1 Apr 2020 02:38:31 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:38406 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731791AbgDAGib (ORCPT ); Wed, 1 Apr 2020 02:38:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585723110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FCSSEclj0ae09gTP8bn9O3K6yRcTAt/8Yi29buWbaxw=; b=B0s5qLL2k0eamZOMT6HG7t4kHFL4xZnrfeQI6Q8edEUGKzgoXJ2wz6FGFkhJXzxLea06FD s8D11wtWfps9fzpObRyio/NJiGDk/lGJBf58W6PDOCQBAEXI+x2QYt0DPOrZyRKASfTVxq t6Wi3EF762Ih67Ei7qckrzB+Wpa6SXU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-MkT21KpwPa-iJMpbhwU6pQ-1; Wed, 01 Apr 2020 02:38:28 -0400 X-MC-Unique: MkT21KpwPa-iJMpbhwU6pQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B511A107ACC7; Wed, 1 Apr 2020 06:38:27 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.40.193.155]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3800B10002AE; Wed, 1 Apr 2020 06:38:20 +0000 (UTC) Date: Wed, 1 Apr 2020 08:38:17 +0200 From: Andrew Jones To: Wainer dos Santos Moschetta Cc: kvm@vger.kernel.org, pbonzini@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, david@redhat.com Subject: Re: [PATCH 2/2] selftests: kvm: Add mem_slot_test test Message-ID: <20200401063817.gb5f4ah45qvtqkhw@kamzik.brq.redhat.com> References: <20200330204310.21736-1-wainersm@redhat.com> <20200330204310.21736-3-wainersm@redhat.com> <20200331081632.ithcwuzjyjhiwphy@kamzik.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2020 at 06:42:21PM -0300, Wainer dos Santos Moschetta wrote: > It would be nice to exercise the code by adding slots with different page > flags. But for this test that simple checks the limit, the use of > KVM_MEM_READONLY is enough. I will change it on v2. It would be good to test more memslot error conditions as well. Do you plan to expand on this test? Thanks, drew