From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3754EC43331 for ; Wed, 1 Apr 2020 08:39:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 003FD2078B for ; Wed, 1 Apr 2020 08:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585730364; bh=bCAkbcSaYfiEPE7qWQeomak3DUc5F4qOM0M2cfGxkEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rHiWEsaGWYAS3Cw1qlkhgSB3CK9JQJ7D0yNAuYBiyLIj7CjRHeNjSD7tpxwbcbfEb FbgTCbhZ+zoVvRhAX04iK/Nff5MuFJwsKgZiYSnCZs51DhzbrQQGWCb0X6ts3oPnQh qoducueAgH2zjCFX0LjStDP1luP7c6ihsAoFwUPo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731705AbgDAIjX (ORCPT ); Wed, 1 Apr 2020 04:39:23 -0400 Received: from foss.arm.com ([217.140.110.172]:45808 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbgDAIjW (ORCPT ); Wed, 1 Apr 2020 04:39:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 335D831B; Wed, 1 Apr 2020 01:39:22 -0700 (PDT) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A77653F52E; Wed, 1 Apr 2020 01:39:21 -0700 (PDT) Date: Wed, 1 Apr 2020 09:39:20 +0100 From: Mark Brown To: YueHaibing Cc: oder_chiou@realtek.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ASoC: rt5682: Fix build error without CONFIG_I2C Message-ID: <20200401083920.GB4943@sirena.org.uk> References: <20200401082540.21876-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="E39vaYmALEf/7YXx" Content-Disposition: inline In-Reply-To: <20200401082540.21876-1-yuehaibing@huawei.com> X-Cookie: The Ranger isn't gonna like it, Yogi. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --E39vaYmALEf/7YXx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 01, 2020 at 04:25:40PM +0800, YueHaibing wrote: > -static const char *rt5682_supply_names[RT5682_NUM_SUPPLIES] =3D { > - "AVDD", > - "MICVDD", > - "VBAT", > -}; > - I imagine that the device is going to need power even when use with slimbus, even if the regulator support isn't wired up at the minute. For things like this __maybey_unused annotations tend to be better,=20 this stops warnings about things not being used but doesn't need ifdefs or big code moves. --E39vaYmALEf/7YXx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6EUzcACgkQJNaLcl1U h9ANrgf/f7gocQPtQBlwwICg0sIaoabV0i7a4QjmUQl+hyL/r1q0weR9P42brmMZ EQwcm89LZOJJG8pLSonMGPeoIH0gePFlBqN4AbFl0h+uUBDfvuSZbuFnZS+AEVyd pa2KTzaM3LAbzuwfAH0R8AkWn2WE9LmetNEGuWluP4yKYsRWLNmGsalDm/kw7ww7 zexY9Z9eOZZddfn2PBAWfqHcy7HFFXy0bB4rG2LR6KevIGp+8ZwJvs5BwllnpqiU /O6tIY282GqwsuPFg1nktHVgUP35cQVkAF+mjddMvPI3pGMdYvAdd3YWcGmwOzJr ZXnMzVEKsd1L8e4v9nty0/z7Fk7YUA== =lx3U -----END PGP SIGNATURE----- --E39vaYmALEf/7YXx-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8212CC43331 for ; Wed, 1 Apr 2020 08:40:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BB6821582 for ; Wed, 1 Apr 2020 08:40:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="uHxJ1gay" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BB6821582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 62147166E; Wed, 1 Apr 2020 10:39:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 62147166E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1585730418; bh=bCAkbcSaYfiEPE7qWQeomak3DUc5F4qOM0M2cfGxkEc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uHxJ1gayYl91pdt4x9laWyN+OqgHo7Bf/xRFX5YV4yvFNgPHhknMT+Xnh/tyakPo7 QdFhZs0D8ptHrSTB0/gXe0M6ByRP/P8ZAgnabyYhUSa1fwbHPj2hpeuB3hbDUL+xrq 5LmB8bF3tARqp8lEczT7OgGC5uO9dSXfTJXRkXWw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 010B3F80110; Wed, 1 Apr 2020 10:39:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A4246F8014B; Wed, 1 Apr 2020 10:39:26 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id CC4BFF80110 for ; Wed, 1 Apr 2020 10:39:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CC4BFF80110 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 335D831B; Wed, 1 Apr 2020 01:39:22 -0700 (PDT) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A77653F52E; Wed, 1 Apr 2020 01:39:21 -0700 (PDT) Date: Wed, 1 Apr 2020 09:39:20 +0100 From: Mark Brown To: YueHaibing Subject: Re: [PATCH -next] ASoC: rt5682: Fix build error without CONFIG_I2C Message-ID: <20200401083920.GB4943@sirena.org.uk> References: <20200401082540.21876-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="E39vaYmALEf/7YXx" Content-Disposition: inline In-Reply-To: <20200401082540.21876-1-yuehaibing@huawei.com> X-Cookie: The Ranger isn't gonna like it, Yogi. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --E39vaYmALEf/7YXx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 01, 2020 at 04:25:40PM +0800, YueHaibing wrote: > -static const char *rt5682_supply_names[RT5682_NUM_SUPPLIES] =3D { > - "AVDD", > - "MICVDD", > - "VBAT", > -}; > - I imagine that the device is going to need power even when use with slimbus, even if the regulator support isn't wired up at the minute. For things like this __maybey_unused annotations tend to be better,=20 this stops warnings about things not being used but doesn't need ifdefs or big code moves. --E39vaYmALEf/7YXx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6EUzcACgkQJNaLcl1U h9ANrgf/f7gocQPtQBlwwICg0sIaoabV0i7a4QjmUQl+hyL/r1q0weR9P42brmMZ EQwcm89LZOJJG8pLSonMGPeoIH0gePFlBqN4AbFl0h+uUBDfvuSZbuFnZS+AEVyd pa2KTzaM3LAbzuwfAH0R8AkWn2WE9LmetNEGuWluP4yKYsRWLNmGsalDm/kw7ww7 zexY9Z9eOZZddfn2PBAWfqHcy7HFFXy0bB4rG2LR6KevIGp+8ZwJvs5BwllnpqiU /O6tIY282GqwsuPFg1nktHVgUP35cQVkAF+mjddMvPI3pGMdYvAdd3YWcGmwOzJr ZXnMzVEKsd1L8e4v9nty0/z7Fk7YUA== =lx3U -----END PGP SIGNATURE----- --E39vaYmALEf/7YXx--