All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment
Date: Wed, 01 Apr 2020 13:26:15 +0200	[thread overview]
Message-ID: <20200401112615.931A024003E@gemini.denx.de> (raw)
In-Reply-To: <20200331160456.26254-1-patrick.delaunay@st.com>

Dear Patrick Delaunay,

In message <20200331160456.26254-1-patrick.delaunay@st.com> you wrote:
> Imply CONFIG_VERSION_VARIABLE for stm32mp1 target
> and test U-Boot version ($env_ver) when the environment was
> saved for the last time and to display warning trace.

What is env_ver?  Are you by chance reinventing the wheel?

The U-Boot version is stored in the environment variable "ver";
there should be no need for something similar.


Also. where is $env_ver coming from? It does not exist in mainline,
nor in any of the 3 patches that preceed this patch # 4/16 ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Computers are not intelligent.  They only think they are.

  parent reply	other threads:[~2020-04-01 11:26 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 16:04 [PATCH 01/16] arm: stm32mp: update dependency for STM32_ETZPC Patrick Delaunay
2020-03-31 16:04 ` [PATCH 02/16] arm: stm32mp: remove dependency for STM32KEY Patrick Delaunay
2020-04-01  7:19   ` Patrice CHOTARD
2020-03-31 16:04 ` [PATCH 03/16] arm: stm32mp: reset to default environment when serial# change Patrick Delaunay
2020-04-01  7:22   ` Patrice CHOTARD
2020-04-01 11:18   ` Wolfgang Denk
2020-04-07 14:31     ` Patrick DELAUNAY
2020-04-07 16:22       ` Wolfgang Denk
2020-03-31 16:04 ` [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment Patrick Delaunay
2020-04-01  7:33   ` Patrice CHOTARD
2020-04-07 14:37     ` Patrick DELAUNAY
2020-04-01 11:26   ` Wolfgang Denk [this message]
2020-04-07 14:54     ` Patrick DELAUNAY
2020-04-07 16:28       ` Wolfgang Denk
2020-04-08  9:38         ` [Uboot-stm32] " Patrick DELAUNAY
2020-03-31 16:04 ` [PATCH 05/16] arm: stm32mp: spl: add bsec driver in SPL Patrick Delaunay
2020-04-01  7:34   ` Patrice CHOTARD
2020-04-01 11:27   ` Wolfgang Denk
2020-04-08 14:31     ` Patrick DELAUNAY
2020-03-31 16:04 ` [PATCH 06/16] arm: stm32mp: spl: display error in board_init_f Patrick Delaunay
2020-04-01  7:43   ` Patrice CHOTARD
2020-04-01 11:30   ` Wolfgang Denk
2020-04-21 16:05     ` Patrick DELAUNAY
2020-04-23 20:39       ` Wolfgang Denk
2020-04-24  8:28         ` Patrick DELAUNAY
2020-03-31 16:04 ` [PATCH 07/16] board: stm32mp1: Keep error led ON in case of low power detection Patrick Delaunay
2020-04-01  7:44   ` Patrice CHOTARD
2020-03-31 16:04 ` [PATCH 08/16] board: stm32mp1: update management of boot-led Patrick Delaunay
2020-04-01  7:49   ` [Uboot-stm32] " Patrice CHOTARD
2020-04-01 11:32   ` Wolfgang Denk
2020-04-01 11:43   ` Anatolij Gustschin
2020-04-10 17:08     ` Patrick DELAUNAY
2020-03-31 16:04 ` [PATCH 09/16] board: stm32mp1: gt9147 IRQ before reset on EV1 Patrick Delaunay
2020-04-01  7:53   ` [Uboot-stm32] " Patrice CHOTARD
2020-04-01 11:34   ` Wolfgang Denk
2020-03-31 16:04 ` [PATCH 10/16] board: stm32mp1: set environment variable fdtfile Patrick Delaunay
2020-04-01  8:06   ` [Uboot-stm32] " Patrice CHOTARD
2020-03-31 16:04 ` [PATCH 11/16] board: stm32mp1: check env_get result in board_late_init Patrick Delaunay
2020-04-01  8:06   ` [Uboot-stm32] " Patrice CHOTARD
2020-04-01 11:39   ` Wolfgang Denk
2020-03-31 16:04 ` [PATCH 12/16] board: stm32mp1: add timeout for I/O compensation ready Patrick Delaunay
2020-04-01  8:07   ` [Uboot-stm32] " Patrice CHOTARD
2020-03-31 16:04 ` [PATCH 13/16] gpio: stm32: support gpio ops in SPL Patrick Delaunay
2020-04-01  8:11   ` Patrice CHOTARD
2020-03-31 16:04 ` [PATCH 14/16] ARM: dts: stm32mp15: use DDR3 files generated by STM32CubeMX Patrick Delaunay
2020-04-01  8:08   ` [Uboot-stm32] " Patrice CHOTARD
2020-03-31 16:04 ` [PATCH 15/16] configs: stm32mp1: activate Ethernet PHY Realtek Patrick Delaunay
2020-04-01  8:08   ` [Uboot-stm32] " Patrice CHOTARD
2020-03-31 16:04 ` [PATCH 16/16] configs: stm32mp1: activate CONFIG_ERRNO_STR Patrick Delaunay
2020-04-01  8:09   ` [Uboot-stm32] " Patrice CHOTARD
2020-04-01  7:10 ` [PATCH 01/16] arm: stm32mp: update dependency for STM32_ETZPC Patrice CHOTARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200401112615.931A024003E@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.