All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Li Xinhai <lixinhai.lxh@gmail.com>
Cc: linux-mm@kvack.org, Rik van Riel <riel@redhat.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 0/3] mm: Fix misuse of parent anon_vma in dup_mmap path
Date: Wed, 1 Apr 2020 18:25:59 -0700	[thread overview]
Message-ID: <20200401182559.e5d988f6491537f31323cb2c@linux-foundation.org> (raw)
In-Reply-To: <1581150928-3214-1-git-send-email-lixinhai.lxh@gmail.com>

On Sat,  8 Feb 2020 08:35:25 +0000 Li Xinhai <lixinhai.lxh@gmail.com> wrote:

> This patchset fix the misuse of parenet anon_vma, which mainly caused by
> child vma's vm_next and vm_prev are left same as its parent after
> duplicate vma. Finally, code reached parent vma's neighbor by referring
> pointer of child vma and executed wrong logic.
> 
> The first two patches fix relevant issues, and the third patch sets vm_next
> and vm_prev to NULL when duplicate vma to prevent potential misuse in future. 
> 
> Li Xinhai (3):
>   mm: don't prepare anon_vma if vma has VM_WIPEONFORK
>   Revert "mm/rmap.c: reuse mergeable anon_vma as parent when fork"
>   mm: set vm_next and vm_prev to NULL in vm_area_dup()
> 
>  kernel/fork.c | 10 ++++++----
>  mm/rmap.c     | 13 -------------
>  2 files changed, 6 insertions(+), 17 deletions(-)

Can we please have some review input on this series?


      parent reply	other threads:[~2020-04-02  1:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-08  8:35 [PATCH 0/3] mm: Fix misuse of parent anon_vma in dup_mmap path Li Xinhai
2020-02-08  8:35 ` [PATCH 1/3] mm: don't prepare anon_vma if vma has VM_WIPEONFORK Li Xinhai
2020-02-08  8:53   ` Li Xinhai
2020-04-02 13:45   ` Kirill A. Shutemov
2020-02-08  8:35 ` [PATCH 2/3] Revert "mm/rmap.c: reuse mergeable anon_vma as parent when fork" Li Xinhai
2020-04-02 13:59   ` Kirill A. Shutemov
2020-04-03  3:08     ` Li Xinhai
2020-04-05  1:26       ` Li Xinhai
2020-02-08  8:35 ` [PATCH 3/3] mm: set vm_next and vm_prev to NULL in vm_area_dup() Li Xinhai
2020-04-02 14:07   ` Kirill A. Shutemov
2020-02-10  0:52 ` [PATCH 0/3] mm: Fix misuse of parent anon_vma in dup_mmap path Andrew Morton
2020-02-10  2:15   ` Li Xinhai
2020-04-20 12:06     ` Michal Hocko
2020-04-21  3:53       ` Li Xinhai
2020-04-21  7:26         ` Michal Hocko
2020-04-02  1:25 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200401182559.e5d988f6491537f31323cb2c@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-mm@kvack.org \
    --cc=lixinhai.lxh@gmail.com \
    --cc=riel@redhat.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.