All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH 09/16] efi_loader: imply FAT, FAT_WRITE
Date: Thu, 2 Apr 2020 15:33:25 +0300	[thread overview]
Message-ID: <20200402123325.GA371904@apalos.home> (raw)
In-Reply-To: <20200401070403.GU11504@linaro.org>

On Wed, Apr 01, 2020 at 04:04:04PM +0900, AKASHI Takahiro wrote:
> > 
[...]
> > Yes, we may add further stores later on.
> 
> Why not now?
> How will you generalize it?
> 
> > Ilias wants to use the RPMB
> > area of eMMC devices.
> 
> I think that he plans to use RPMB as secure storage for Standalone MM.

Sorry for my really delayed replies, but I was over my head with EDK2 and RPMB
indeed :)
So my implementation is orthogonal to this patchset and I do have some code that
write UEFI variables on an RPMB via OP-TEE. 
> 
> > As an EFI system partition exists on any UEFI
> > compatible device I think implementing this first is a valid approach.
> 
> I don't deny your approach here, but
> I expect that more generic framework for back storage be
> implemented and FAT driver be on top of that.
> 
Akashi has a point here. On the other hand can't we just make the store a
callback in the future?
So for example is FAT_FS support is not included, we write the data into raw
flash sectors or a file.
That being said EDK2 uses Fvb and Fault Tolerant Writes to write the actual UEFI
variables. So you end up needing 3 partitions for the actual storage.  The
question here is should we implement something similar to u-boot EFI code since
this is only supposed to serve as a 'fallback'? If the board has OP-TEE then
that will be responsible for writing the variables (and it will use whatever
EDK2 uses).

I'll have a closer look to the patchset and try to give some feedback.

Regards
/Ilias
> -Takahiro Akashi
> 
> > 
> > Best regards
> > 
> > Heinrich
> > 
> > >
> > > -Takahiro Akashi
> > >
> > >> -Takahiro Akashi
> > >>
> > >>> Best regards
> > >>>
> > >>> Heinrich
> > >>>
> > >>>>
> > >>>>>>
> > >>>>>> In addition, why do you treat FAT specifically here?
> > >>>>>> I remember that you insisted that other file system should be
> > >>>>>> allowed on U-Boot when I posted some patch.
> > >>>>>
> > >>>>> An EFI system partition is always FAT formatted. So if we want to safe
> > >>>>> U-Boot variables to the EFI system partition we require FAT.
> > >>>>
> > >>>> As system partition is required to be in FAT, file system used on
> > >>>> other partitions must also be in FAT since, as I said before,
> > >>>> UEFI specification clearly defines its file system format based on FAT.
> > >>>> See section 13.3.
> > >>>>
> > >>>> So,
> > >>>>
> > >>>>>> I remember that you insisted that other file system should be
> > >>>>>> allowed on U-Boot when I posted some patch.
> > >>>>
> > >>>> You reverted your statement above here.
> > >>>> That is my point.
> > >>>>
> > >>>> -Takahiro Akashi
> > >>>>
> > >>>>> Best regards
> > >>>>>
> > >>>>> Heinrich
> > >>>>>
> > >>>>>>
> > >>>>>> -Takahiro Akashi
> > >>>>>>
> > >>>>>>
> > >>>>>>>  	imply USB_KEYBOARD_FN_KEYS
> > >>>>>>>  	imply VIDEO_ANSI
> > >>>>>>>  	help
> > >>>>>>> --
> > >>>>>>> 2.25.1
> > >>>
> > 

  reply	other threads:[~2020-04-02 12:33 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  5:27 [PATCH 00/16] efi_loader: non-volatile and runtime variables Heinrich Schuchardt
2020-03-27  5:27 ` [PATCH 01/16] cmd: efidebug: fix int to pointer cast Heinrich Schuchardt
2020-03-27  5:27 ` [PATCH 02/16] efi_loader: only reserve memory if fdt node enabled Heinrich Schuchardt
2020-03-27  5:27 ` [PATCH 03/16] efi_loader: eliminate EFI_CALL() for variable access Heinrich Schuchardt
2020-03-27  5:27 ` [PATCH 04/16] part: detect EFI system partition Heinrich Schuchardt
2020-03-27  6:35   ` Punit Agrawal
2020-03-27  7:21     ` Heinrich Schuchardt
2020-03-27  5:27 ` [PATCH 05/16] efi_loader: identify " Heinrich Schuchardt
2020-03-27  5:27 ` [PATCH 06/16] efi_loader: keep attributes in efi_set_variable_int() Heinrich Schuchardt
2020-03-27  5:27 ` [PATCH 07/16] efi_loader: export initialization state Heinrich Schuchardt
2020-03-27  5:27 ` [PATCH 08/16] efi_loader: change setup sequence Heinrich Schuchardt
2020-03-27  5:27 ` [PATCH 09/16] efi_loader: imply FAT, FAT_WRITE Heinrich Schuchardt
2020-03-31  5:28   ` AKASHI Takahiro
2020-03-31  6:44   ` Heinrich Schuchardt
2020-03-31  7:44     ` AKASHI Takahiro
2020-03-31  8:20       ` Mark Kettenis
2020-04-01  0:31         ` AKASHI Takahiro
2020-04-01  6:43           ` Heinrich Schuchardt
2020-04-01 17:56           ` Mark Kettenis
2020-04-02  1:34             ` AKASHI Takahiro
2020-03-31 13:08       ` Heinrich Schuchardt
2020-03-31 23:57         ` AKASHI Takahiro
2020-04-01  1:14           ` AKASHI Takahiro
2020-04-01  6:31             ` Heinrich Schuchardt
2020-04-01  7:04               ` AKASHI Takahiro
2020-04-02 12:33                 ` Ilias Apalodimas [this message]
2020-03-27  5:27 ` [PATCH 10/16] efi_loader: UEFI variable persistence Heinrich Schuchardt
2020-03-27  8:07   ` Punit Agrawal
2020-03-27 10:30     ` Heinrich Schuchardt
2020-03-30 10:03       ` Punit Agrawal
2020-04-06 16:06       ` Ilias Apalodimas
2021-01-02 22:15   ` Peter Robinson
2020-03-27  5:27 ` [PATCH 11/16] efi_loader: export efi_convert_pointer() Heinrich Schuchardt
2020-03-27  5:27 ` [PATCH 12/16] efi_loader: optional pointer for ConvertPointer Heinrich Schuchardt
2020-03-31  5:23   ` AKASHI Takahiro
2020-03-31  6:52   ` Heinrich Schuchardt
2020-03-31  7:51     ` AKASHI Takahiro
2020-03-27  5:27 ` [PATCH 13/16] efi_loader: memory buffer for variables Heinrich Schuchardt
2020-03-27  8:09   ` Punit Agrawal
2020-03-27 10:45     ` Heinrich Schuchardt
2020-03-30 10:50       ` Punit Agrawal
2020-03-27  5:27 ` [PATCH 14/16] efi_loader: use memory based variable storage Heinrich Schuchardt
2020-03-27 19:44 ` [PATCH 00/16] efi_loader: non-volatile and runtime variables Simon Glass
2020-03-28  6:42   ` Heinrich Schuchardt
2020-03-31  6:05 ` [PATCH 15/16] efi_loader: enable UEFI variables at runtime Heinrich Schuchardt
2020-03-31  6:05   ` [PATCH 15/16] efi_selftest: adjust runtime test for variables Heinrich Schuchardt
2020-04-01  1:41   ` [PATCH 15/16] efi_loader: enable UEFI variables at runtime AKASHI Takahiro
2020-04-01  6:26     ` Heinrich Schuchardt
2020-04-01  6:51       ` AKASHI Takahiro
2020-03-31  6:07 ` [PATCH 16/16] efi_selftest: adjust runtime test for variables Heinrich Schuchardt
2020-04-01  1:05   ` AKASHI Takahiro
2020-04-01  6:37     ` Heinrich Schuchardt
2020-04-01  7:27       ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200402123325.GA371904@apalos.home \
    --to=ilias.apalodimas@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.