From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1505BC2D0F3 for ; Thu, 2 Apr 2020 15:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDF262072E for ; Thu, 2 Apr 2020 15:10:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jqLjXF3t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389136AbgDBPKQ (ORCPT ); Thu, 2 Apr 2020 11:10:16 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50006 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388960AbgDBPKP (ORCPT ); Thu, 2 Apr 2020 11:10:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+Mc5VxCSGR+ubhm7i2F7LBlTvaw0U2gf84ze2KV8ksk=; b=jqLjXF3tryBZRU1qNEFnLPACgH JJUS86PBhx7pCgipML92RZPuTpPYE1wBAQItbKLYVQ0nwO/Qc9By0XjkVONtwu1tOK801b/87Zs6b kHsD3IooG1pb8lKmjpPnYrmtokCzK5dVMKIT5FShuZTQwSqSNqz4Tl4bkR7X9PyHvrZa5Rz3upoCx V2zWVU3DpZ3KX2wOzoazENtezwpU4rtUoP8Sjb/crJe2+JihHbb1cxFN+h9XFd7uuTPbJXJXa/Bbq jsiNdY/f51g0+/KSQ7ibDrmznxRk6dPDPXGs0tJ/fXqkSX+LSgU3O0fpJHoDNH+exeH3uv2w5hI3D v7QnHmuA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jK1Tt-0000xm-N8; Thu, 02 Apr 2020 15:10:09 +0000 Date: Thu, 2 Apr 2020 08:10:09 -0700 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , "Anna.Schumaker@Netapp.com" , Andrew Morton , Jan Kara , linux-mm@kvack.org, linux-nfs@vger.kernel.org, LKML Subject: Re: [PATCH 2/2] Deprecate NR_UNSTABLE_NFS, use NR_WRITEBACK Message-ID: <20200402151009.GA14130@infradead.org> References: <87tv2b7q72.fsf@notabene.neil.brown.name> <87v9miydai.fsf@notabene.neil.brown.name> <87sghmyd8v.fsf@notabene.neil.brown.name> <87pncqyd7k.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pncqyd7k.fsf@notabene.neil.brown.name> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2020 at 10:54:07AM +1100, NeilBrown wrote: > > After an NFS page has been written it is considered "unstable" until a > COMMIT request succeeds. If the COMMIT fails, the page will be > re-written. > > These "unstable" pages are currently accounted as "reclaimable", > either in WB_RECLAIMABLE, or in NR_UNSTABLE_NFS which is included in a > 'reclaimable' count. This might have made sense when sending the COMMIT > required a separate action by the VFS/MM (e.g. releasepage() used to > send a COMMIT). However now that all writes generated by ->writepages() > will automatically be followed by a COMMIT, it makes more sense to > treat them as writeback pages. > > So this page deprecates NR_UNSTABLE_NFS and accounts unstable pages in > NR_WRITEBACK and WB_WRITEBACK. Please remove it entirely if it isn't used any more.