Re: [PATCH 05/33] drm/panel-leadtek-ltk500hd1829: Fix dotclock

From: Sam Ravnborg <sam@ravnborg.org>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 05/33] drm/panel-leadtek-ltk500hd1829: Fix dotclock
Date: Thu, 2 Apr 2020 17:49:13 +0200	[thread overview]
Message-ID: <20200402154913.GA6048@ravnborg.org> (raw)
In-Reply-To: <20200402131310.GU13686@intel.com>

Hi Ville.

On Thu, Apr 02, 2020 at 04:13:10PM +0300, Ville Syrjälä wrote:
> On Tue, Mar 03, 2020 at 01:52:27PM +0100, Heiko Stuebner wrote:
> > Hi,
> > 
> > Am Montag, 2. März 2020, 21:34:24 CET schrieb Ville Syrjala:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > 
> > > The currently listed dotclock disagrees with the currently
> > > listed vrefresh rate. Change the dotclock to match the vrefresh.
> > > 
> > > Someone tell me which (if either) of the dotclock or vreresh is
> > > correct?
> > 
> > The values came that way from the vendor .
> > And lookin at other Leadtek display datasheets, 60Hz should be the
> > correct refresh rate.
> > 
> > The display is also running happily at the 69MHz of
> > your patch, so
> > 
> > Tested-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> 
> Thanks for confirming.
> 
> I think this patch the last one with a huge difference between
> vrefresh and clock. So once this goes in I'm thinking of declaring
> the remaining patches as not important and pushing ahead with the
> mode dieting. Can someone ack this so I can get it in?

You have done a very good job following up on the individual panels and
the above seems like a good plan moving forward.
So for the remaining patches:

Acked-by: Sam Ravnborg <sam@ravnborg.org>

	Sam
> 
> > Heiko
> > 
> > > 
> > > Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > > Cc: Sam Ravnborg <sam@ravnborg.org>
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > >  drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c
> > > index 76ecf2de9c44..113ab9c0396b 100644
> > > --- a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c
> > > +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c
> > > @@ -377,7 +377,7 @@ static const struct drm_display_mode default_mode = {
> > >  	.vsync_end	= 1280 + 30 + 4,
> > >  	.vtotal		= 1280 + 30 + 4 + 12,
> > >  	.vrefresh	= 60,
> > > -	.clock		= 41600,
> > > +	.clock		= 69217,
> > >  	.width_mm	= 62,
> > >  	.height_mm	= 110,
> > >  };
> > > 
> > 
> > 
> > 
> 
> -- 
> Ville Syrjälä
> Intel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel