From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-integrity@vger.kernel.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org,
Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH v3] acpi: Extend TPM2 ACPI table with missing log fields
Date: Thu, 2 Apr 2020 22:21:57 +0300 [thread overview]
Message-ID: <20200402192145.GB10314@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0gQ04h1+zN4wHj1vkwPvqu3RPfsY60VJ+GOtgUrvWuxLQ@mail.gmail.com>
On Wed, Apr 01, 2020 at 11:05:36AM +0200, Rafael J. Wysocki wrote:
> On Wed, Apr 1, 2020 at 10:37 AM Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> >
> > On Tue, Mar 31, 2020 at 05:49:49PM -0400, Stefan Berger wrote:
> > > From: Stefan Berger <stefanb@linux.ibm.com>
> > >
> > > Recent extensions of the TPM2 ACPI table added 3 more fields
> > > including 12 bytes of start method specific parameters and Log Area
> > > Minimum Length (u32) and Log Area Start Address (u64). So, we extend
> > > the existing structure with these fields to allow non-UEFI systems
> > > to access the TPM2's log.
> > >
> > > The specification that has the new fields is the following:
> > > TCG ACPI Specification
> > > Family "1.2" and "2.0"
> > > Version 1.2, Revision 8
> > >
> > > Adapt all existing table size calculations to use
> > > offsetof(struct acpi_table_tpm2, start_method_specific)
> > > [where start_method_specific is a newly added field]
> > > rather than sizeof(struct acpi_table_tpm2) so that the addition
> > > of the new fields does not affect current systems that may not
> > > have them.
> > >
> > > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> > > Cc: linux-acpi@vger.kernel.org
> >
> > I think I'm cool with this but needs an ack from ACPI maintainer.
> >
> > Rafael, given that this not an intrusive change in any possible means,
> > can I pick this patch and put it to my next pull request?
>
> Yes, please.
>
> Thanks!
Great, thanks Rafael.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Do you mind if I add your ack to the commit?
/Jarkko
next prev parent reply other threads:[~2020-04-02 19:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 21:49 [PATCH v3] acpi: Extend TPM2 ACPI table with missing log fields Stefan Berger
2020-04-01 8:37 ` Jarkko Sakkinen
2020-04-01 9:05 ` Rafael J. Wysocki
2020-04-02 19:21 ` Jarkko Sakkinen [this message]
2020-06-19 15:14 ` Stefan Berger
2020-06-19 15:55 ` Rafael J. Wysocki
2020-06-23 0:57 ` Jarkko Sakkinen
2020-06-23 0:56 ` Jarkko Sakkinen
2020-06-23 1:01 ` Jarkko Sakkinen
2020-06-23 11:27 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402192145.GB10314@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.