Re: [Outreachy kernel] Re: [Outreachy] [PATCH 0/3] staging: qlge: Resolve various warnings issued by checkpatch.pl

[Stefano Brivio <sbrivio@redhat.com>]

On Thu, 2 Apr 2020 18:13:12 +0530
Soumyajit Deb <debsoumyajit100@gmail.com> wrote:

> On Wed, Apr 01, 2020 at 10:58:30PM +0200, Stefano Brivio wrote:
> > Hi Soumyajit,
> > 
> > On Wed, 1 Apr 2020 14:28:12 +0530
> > Soumyajit Deb <debsoumyajit100@gmail.com> wrote:
> >   
> > > On Sat, Mar 28, 2020 at 01:32:51PM +0530, Soumyajit Deb wrote:  
> > > > This patchset resolve coding style and indentation issues reported by
> > > > checkpatch.pl
> > > > This patchset add space around various binary operators, remove extra
> > > > unnecessary blank lines and properly indent a multiline comment for the
> > > > same file qlge_main.c present under drivers/staging/qlge directory.
> > > > 
> > > > Soumyajit Deb (3):
> > > >   staging: qlge: Add space around operators
> > > >   staging: qlge: Remove extra blank lines
> > > >   staging: qlge: Properly indent a multiline comment
> > > > 
> > > >  drivers/staging/qlge/qlge_main.c | 30 +++++++++++-------------------
> > > >  1 file changed, 11 insertions(+), 19 deletions(-)
> > > > 
> > > > -- 
> > > > 2.17.1    
> > > 
> > > I have submitted this patcset on 28 March but I haven't recieved any
> > > review on this.
> > > Is there anything wrong with this patchset?
> > > 
> > > Please let me know, so I can correct them and resend the patches if
> > > needed.  
> > 
> > I haven't reviewed this series because I'm confused. You later sent a
> > series:
> > 
> > Subject: [Outreachy kernel] [Outreachy] [PATCH 0/2] staging: qlge: Resolve  various warnings reported by checkpatch.pl
> > Date: Wed,  1 Apr 2020 12:21:18 +0530
> > Message-Id: <20200401065120.17459-1-debsoumyajit100@gmail.com>
> > 
> > ...how are those different? Which one should I review?
> > 
> > -- 
> > Stefano
> >  
> Hii Stefano,
> 
> Both patch series are different. The patch series which was sent on 28th March was for the file qlge_main.c
> in the qlge driver. While the patch series sent on 1st April is the
> patch series which was formed by clustering previous individual patches
> for the file qlge_mpi.c in the same qlge driver as suggested by you
> eariler.
>
> So, both the patch series are different and they effect different files
> in the same driver.

Okay, but in general, that's not a good reason to have separate
patchsets. The difference should be in the topic of the series.

At this point there are three "active" patchsets for qlge from you:

[PATCH 0/3] staging: qlge: Resolve  various warnings issued by checkpatch.pl
[PATCH] staging: qlge: Properly indent  the multiline comments
[PATCH 0/2] staging: qlge: Resolve  various warnings reported by checkpatch.pl

"issued" and "reported" are synonyms, which would seem to indicate
those are conceptually the same type of changes.

I think the second patchset (with one single patch) was then
incorporated into the third one, but the third one doesn't mention it
in the changelog, and you didn't explicitly say it should be discarded.

Mind that reviewers are people and, while we can use some
interpretation, things need to be sufficiently clear. Given the
subjects of the active series, I'm really lost. I could decide to
review first and third patchsets, but still I don't understand why they
are separated.

-- 
Stefano