From: Christian Brauner <christian.brauner@ubuntu.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Dmitry Safonov <dima@arista.com>, Andrei Vagin <avagin@openvz.or>,
Adrian Reber <adrian@lisas.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrei Vagin <avagin@gmail.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Dmitry Safonov <0x7f454c46@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Andy Lutomirski <luto@kernel.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH] ns: Fix time_for_children symlink
Date: Fri, 3 Apr 2020 14:34:31 +0200 [thread overview]
Message-ID: <20200403123431.tsvj6alagg3ee356@wittgenstein> (raw)
In-Reply-To: <a2418c48-ed80-3afe-116e-6611cb799557@gmail.com>
On Fri, Apr 03, 2020 at 02:11:39PM +0200, Michael Kerrisk (man-pages) wrote:
> Dmitry, Andrei,
>
> Looking at the contents of the /proc/PID/ns/time_for_children
> symlink shows an anomaly:
>
> $ ls -l /proc/self/ns/* |awk '{print $9, $10, $11}'
> ...
> /proc/self/ns/pid -> pid:[4026531836]
> /proc/self/ns/pid_for_children -> pid:[4026531836]
> /proc/self/ns/time -> time:[4026531834]
> /proc/self/ns/time_for_children -> time_for_children:[4026531834]
> /proc/self/ns/user -> user:[4026531837]
> ...
>
> The reference for 'time_for_children' should be a 'time' namespace,
> just as the reference for 'pid_for_children' is a 'pid' namespace.
> In other words, I think the above time_for_children link should read:
>
> /proc/self/ns/time_for_children -> time:[4026531834]
>
> If you agree with this patch, then it should be marked for
> stable@vger.kernel.org.
>
> Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
Yeah, that just seems like an oversight.
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
next prev parent reply other threads:[~2020-04-03 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 12:11 [PATCH] ns: Fix time_for_children symlink Michael Kerrisk (man-pages)
2020-04-03 12:34 ` Christian Brauner [this message]
2020-04-03 12:49 ` Dmitry Safonov
2020-04-07 3:33 ` Andrei Vagin
2020-04-07 10:42 ` [tip: timers/urgent] time/namespace: " tip-bot2 for Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403123431.tsvj6alagg3ee356@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=0x7f454c46@gmail.com \
--cc=adrian@lisas.de \
--cc=avagin@gmail.com \
--cc=avagin@openvz.or \
--cc=containers@lists.linux-foundation.org \
--cc=dima@arista.com \
--cc=ebiederm@xmission.com \
--cc=gorcunov@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.