From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Fri, 3 Apr 2020 15:51:18 +0300
Subject: [PATCH v3 15/29] acpi: Add a simple sandbox test
In-Reply-To: <20200330171226.v3.15.Ife90d6e6cfa90e642e73328168a00804b1dc6fd4@changeid>
References: <20200330231305.130488-1-sjg@chromium.org>
 <20200330171226.v3.15.Ife90d6e6cfa90e642e73328168a00804b1dc6fd4@changeid>
Message-ID: <20200403125118.GB3676135@smile.fi.intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, Mar 30, 2020 at 05:12:51PM -0600, Simon Glass wrote:
> Add a sandbox test for the basic ACPI functionality we have so far.

> +U_BOOT_DRIVER(testacpi_drv) = {
> +	.name	= "testacpi_drv",
> +	.of_match	= testacpi_ids,
> +	.id	= UCLASS_TEST_ACPI,

> +	acpi_ops_ptr(&testacpi_ops)

I have noticed that this is not obvious why no comma here.
Perhaps, since apci_ops_ptr is a macro, you should upper case it.

> +};

-- 
With Best Regards,
Andy Shevchenko