From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1519BC2BA1E for ; Sun, 5 Apr 2020 23:55:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC17520678 for ; Sun, 5 Apr 2020 23:55:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="COrJ+AE2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727742AbgDEXzk (ORCPT ); Sun, 5 Apr 2020 19:55:40 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:34894 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727254AbgDEXzk (ORCPT ); Sun, 5 Apr 2020 19:55:40 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B24F6312; Mon, 6 Apr 2020 01:55:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586130938; bh=34CMyMXa9DAX8P73HGBIeopwz1xWQ67Fo3EBeVw2LnY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=COrJ+AE2hzHNEXM7qCBYS5QKRh+nFglEhf9nTTN6T2i5tm0pTrYWRXKx/0elhbxUz A6e2OFpGdjO4J/aDt6TNW3qfepysUEyebu2zWF8TxxW90/CD/JLznQQqqtdpzwaW25 Cjk/H9j3ST0OgH6OUkEZfpfCqDtvsLaZ3W/p+xsc= Date: Mon, 6 Apr 2020 02:55:21 +0300 From: Laurent Pinchart To: Laurent Pinchart Cc: devicetree@vger.kernel.org, Sandy Huang , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Maxime Ripard , Mark Yao , Heiko =?utf-8?Q?St=C3=BCbner?= Subject: Re: [PATCH/RFC 0/6] dt-bindings: display: Convert DWC HDMI TX bindings to YAML Message-ID: <20200405235521.GA27695@pendragon.ideasonboard.com> References: <20200405233935.27599-1-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200405233935.27599-1-laurent.pinchart+renesas@ideasonboard.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Apr 06, 2020 at 02:39:29AM +0300, Laurent Pinchart wrote: > Hello, > > This patch series attempts a conversion of the DWC HDMI TX DT bindings > to YAML. I've marked it as RFC as the base schema doesn't work is > intended in this (naive) approach, and I'm not sure how to fix it > properly. > > The DWC HDMI TX is an HDMI transmitter IP core from Synopsys, integrated > in various SoCs with different glue layers. As such, some properties are > defined in a common document, but sometimes need to be overridden by > platform-specific bindings. > > Patch 1/6 adds a base schema for the common properties, based on the > existing dw_hdmi.txt document. Patches 2/6 to 4/6 then convert the > platformspecific bindings for Renesas, NXP and Rockchip SoCs. Patch 5/6 > replaces the reference to dw_hdmi.txt in the Allwinner bindings with a > reference to the YAML base schema, and patch 6/6 drops dw_hdmi.txt. > > My attempts at defining properties in the base schema, including it in > the platform-specific schema with an allOf: $ref..., and overridding > properties didn't work, as DT schemas don't define properties in a way > that can be overridden, but instead define validation rules that are all > considered. Both the rules in the base schema and in the > platform-specific schemas are evaluated. > > One possible way around this would be to not pull in the whole base > schema, but specific rules. This is however a bit cumbersome to use in > my opinion. Is there a better way to achieve this ? > > I have volunteered Philipp Zabel and Mark Yao as maintainers for the > i.MX6 and Rockchip bindings respectively. Please let me know if you > would prefer a different maintainer, or ack the respective patch if this > is fine with you. Given that bounced, I may already have an answer to part of that question :-) I've CC'ed Mark's gmail address, as well as Sandy and Heiko who maintain the Rockchip DRM driver. > Laurent Pinchart (6): > dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI > dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML > dt-bindings: display: imx: hdmi: Convert binding to YAML > dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML > dt-bindings: display: sun8i-a83t-dw-hdmi: Reference dw-hdmi YAML > schema > dt-bindings: display: bridge: Remove deprecated dw_hdmi.txt > > .../display/allwinner,sun8i-a83t-dw-hdmi.yaml | 4 +- > .../bindings/display/bridge/dw_hdmi.txt | 33 ---- > .../display/bridge/renesas,dw-hdmi.txt | 86 --------- > .../display/bridge/renesas,dw-hdmi.yaml | 142 ++++++++++++++ > .../display/bridge/synopsys,dw-hdmi.yaml | 68 +++++++ > .../bindings/display/imx/fsl,imx6-hdmi.yaml | 143 ++++++++++++++ > .../devicetree/bindings/display/imx/hdmi.txt | 65 ------- > .../display/rockchip/dw_hdmi-rockchip.txt | 74 -------- > .../display/rockchip/rockchip,dw-hdmi.yaml | 178 ++++++++++++++++++ > 9 files changed, 533 insertions(+), 260 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/dw_hdmi.txt > delete mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > create mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > create mode 100644 Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > delete mode 100644 Documentation/devicetree/bindings/display/imx/hdmi.txt > delete mode 100644 Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA31C2BA2B for ; Sun, 5 Apr 2020 23:55:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12C0220678 for ; Sun, 5 Apr 2020 23:55:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="COrJ+AE2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12C0220678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AD0B6E29B; Sun, 5 Apr 2020 23:55:41 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85C566E29B for ; Sun, 5 Apr 2020 23:55:39 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B24F6312; Mon, 6 Apr 2020 01:55:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586130938; bh=34CMyMXa9DAX8P73HGBIeopwz1xWQ67Fo3EBeVw2LnY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=COrJ+AE2hzHNEXM7qCBYS5QKRh+nFglEhf9nTTN6T2i5tm0pTrYWRXKx/0elhbxUz A6e2OFpGdjO4J/aDt6TNW3qfepysUEyebu2zWF8TxxW90/CD/JLznQQqqtdpzwaW25 Cjk/H9j3ST0OgH6OUkEZfpfCqDtvsLaZ3W/p+xsc= Date: Mon, 6 Apr 2020 02:55:21 +0300 From: Laurent Pinchart To: Laurent Pinchart Subject: Re: [PATCH/RFC 0/6] dt-bindings: display: Convert DWC HDMI TX bindings to YAML Message-ID: <20200405235521.GA27695@pendragon.ideasonboard.com> References: <20200405233935.27599-1-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200405233935.27599-1-laurent.pinchart+renesas@ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sandy Huang , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Maxime Ripard , Mark Yao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Apr 06, 2020 at 02:39:29AM +0300, Laurent Pinchart wrote: > Hello, > > This patch series attempts a conversion of the DWC HDMI TX DT bindings > to YAML. I've marked it as RFC as the base schema doesn't work is > intended in this (naive) approach, and I'm not sure how to fix it > properly. > > The DWC HDMI TX is an HDMI transmitter IP core from Synopsys, integrated > in various SoCs with different glue layers. As such, some properties are > defined in a common document, but sometimes need to be overridden by > platform-specific bindings. > > Patch 1/6 adds a base schema for the common properties, based on the > existing dw_hdmi.txt document. Patches 2/6 to 4/6 then convert the > platformspecific bindings for Renesas, NXP and Rockchip SoCs. Patch 5/6 > replaces the reference to dw_hdmi.txt in the Allwinner bindings with a > reference to the YAML base schema, and patch 6/6 drops dw_hdmi.txt. > > My attempts at defining properties in the base schema, including it in > the platform-specific schema with an allOf: $ref..., and overridding > properties didn't work, as DT schemas don't define properties in a way > that can be overridden, but instead define validation rules that are all > considered. Both the rules in the base schema and in the > platform-specific schemas are evaluated. > > One possible way around this would be to not pull in the whole base > schema, but specific rules. This is however a bit cumbersome to use in > my opinion. Is there a better way to achieve this ? > > I have volunteered Philipp Zabel and Mark Yao as maintainers for the > i.MX6 and Rockchip bindings respectively. Please let me know if you > would prefer a different maintainer, or ack the respective patch if this > is fine with you. Given that bounced, I may already have an answer to part of that question :-) I've CC'ed Mark's gmail address, as well as Sandy and Heiko who maintain the Rockchip DRM driver. > Laurent Pinchart (6): > dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI > dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML > dt-bindings: display: imx: hdmi: Convert binding to YAML > dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML > dt-bindings: display: sun8i-a83t-dw-hdmi: Reference dw-hdmi YAML > schema > dt-bindings: display: bridge: Remove deprecated dw_hdmi.txt > > .../display/allwinner,sun8i-a83t-dw-hdmi.yaml | 4 +- > .../bindings/display/bridge/dw_hdmi.txt | 33 ---- > .../display/bridge/renesas,dw-hdmi.txt | 86 --------- > .../display/bridge/renesas,dw-hdmi.yaml | 142 ++++++++++++++ > .../display/bridge/synopsys,dw-hdmi.yaml | 68 +++++++ > .../bindings/display/imx/fsl,imx6-hdmi.yaml | 143 ++++++++++++++ > .../devicetree/bindings/display/imx/hdmi.txt | 65 ------- > .../display/rockchip/dw_hdmi-rockchip.txt | 74 -------- > .../display/rockchip/rockchip,dw-hdmi.yaml | 178 ++++++++++++++++++ > 9 files changed, 533 insertions(+), 260 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/dw_hdmi.txt > delete mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > create mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > create mode 100644 Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > delete mode 100644 Documentation/devicetree/bindings/display/imx/hdmi.txt > delete mode 100644 Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel