All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dcaratti@redhat.com
Cc: antoine.tenart@bootlin.com, dbogdanov@marvell.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net] macsec: fix NULL dereference in macsec_upd_offload()
Date: Mon, 06 Apr 2020 10:26:24 -0700 (PDT)	[thread overview]
Message-ID: <20200406.102624.1004066216541067473.davem@davemloft.net> (raw)
In-Reply-To: <74490212072a970d0b65114644f90b1c06c68402.1586165752.git.dcaratti@redhat.com>

From: Davide Caratti <dcaratti@redhat.com>
Date: Mon,  6 Apr 2020 11:38:29 +0200

> macsec_upd_offload() gets the value of MACSEC_OFFLOAD_ATTR_TYPE
> without checking its presence in the request message, and this causes
> a NULL dereference. Fix it rejecting any configuration that does not
> include this attribute.
> 
> Reported-and-tested-by: syzbot+7022ab7c383875c17eff@syzkaller.appspotmail.com
> Fixes: dcb780fb2795 ("net: macsec: add nla support for changing the offloading selection")
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>

Applied.

      reply	other threads:[~2020-04-06 17:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06  9:38 [PATCH net] macsec: fix NULL dereference in macsec_upd_offload() Davide Caratti
2020-04-06 17:26 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406.102624.1004066216541067473.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=antoine.tenart@bootlin.com \
    --cc=dbogdanov@marvell.com \
    --cc=dcaratti@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.