From: Soumyajit Deb <debsoumyajit100@gmail.com>
To: gregkh@linuxfoundation.org
Cc: outreachy-kernel@googlegroups.com, sbrivio@redhat.com,
julia.lawall@inria.fr, Larry.Finger@lwfinger.net,
Soumyajit Deb <debsoumyajit100@gmail.com>
Subject: [Outreachy] [PATCH v4 0/3] staging: rtl8188eu: Resolve various warnings reported by checkpatch.pl
Date: Mon, 6 Apr 2020 16:47:03 +0530 [thread overview]
Message-ID: <20200406111706.25957-1-debsoumyajit100@gmail.com> (raw)
This patchset resolves coding style and indentation issues reported by
checkpatch.pl
This patchset properly structures a multiline comment by adding "*" at
the start of every line of the comment and also break lines into
multiple lines to respect the 80 character width limit. Also, as
suggested by Stefano Brivio <sbrivio@redhat.com>, this patchset also
removes extra unnecessary parentheses to improve code readability, all
for the same file rtw_ap.c present under drivers/staging/rtl8188eu/core
directory.
Changes in v4:
-PATCH 1/3: Add ' ' character right after '*' character at the start
of each line of the multiline comment as suggested by
Greg KH <gregkh@linuxfoundation.org>
-PATCH 2/3: No change
-PATCH 3/3: Remove unrelated changes as suggested by Julia Lawall
<julia.lawall@inria.fr>
Changes in v3:
-PATCH 1/3: No change
-PATCH 2/3: Replace PATCH 2/3 with PATCH 3/3, as suggested by Stefano
Brivio <sbrivio@redhat.com>
-PATCH 3/3: Replace PATCH 3/3 with PATCH 2/3 as suggested by Stefano
Brivio <sbrivio@redhat.com>. Also, align 0x3f below the
left end of the function call as suggested by Julia Lawall
<julia.lawall@inria.fr>
Changes in v2:
-PATCH 1/3: No change
-PATCH 2/3: Add curly brackets in conditional statements to improve
code readability and properly align the lines of a
function call as suggested by Stefano Brivio.
-PATCH 3/3: Remove extra unnecessary parentheses to improve code
readability as suggested by Stefano Brivio
<sbrivio@redhat.com>
Soumyajit Deb (3):
staging: rtl8188eu: Properly structure the multiline comment
staging: rtl8188eu: Remove unnecessary extra parentheses
staging: rtl8188eu: Line over 80 characters
drivers/staging/rtl8188eu/core/rtw_ap.c | 99 +++++++++++++++----------
1 file changed, 61 insertions(+), 38 deletions(-)
--
2.17.1
next reply other threads:[~2020-04-06 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 11:17 Soumyajit Deb [this message]
2020-04-06 11:17 ` [Outreachy] [PATCH v4 1/3] staging: rtl8188eu: Properly structure the multiline comment Soumyajit Deb
2020-04-06 11:17 ` [Outreachy] [PATCH v4 2/3] staging: rtl8188eu: Remove unnecessary extra parentheses Soumyajit Deb
2020-04-07 3:48 ` [Outreachy kernel] " Stefano Brivio
2020-04-06 11:17 ` [Outreachy] [PATCH v4 3/3] staging: rtl8188eu: Line over 80 characters Soumyajit Deb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406111706.25957-1-debsoumyajit100@gmail.com \
--to=debsoumyajit100@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.