* [PATCH] ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT
@ 2020-04-02 16:53 Marek Vasut
2020-04-05 14:05 ` Manivannan Sadhasivam
2020-04-06 11:28 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2020-04-02 16:53 UTC (permalink / raw)
To: u-boot
The card-detect GPIO and any other GPIO access currently doesn't work in
U-Boot SPL on any STM32 platform and crashes the SPL. To work around this
problem on AV96 right before release, remove the cd-gpios from DT. This
patch must be reverted right after release, once the proper fix for the
GPIO driver, "gpio: stm32: support gpio ops in SPL", is applied.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Tom Rini <trini@konsulko.com>
---
NOTE: I think it's OK if Tom picks this one directly to reduce load on
the ST people, since this is isolated to a single board.
---
arch/arm/dts/stm32mp157a-avenger96.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/dts/stm32mp157a-avenger96.dts b/arch/arm/dts/stm32mp157a-avenger96.dts
index 1f32395e71..b23fa6dee0 100644
--- a/arch/arm/dts/stm32mp157a-avenger96.dts
+++ b/arch/arm/dts/stm32mp157a-avenger96.dts
@@ -353,7 +353,6 @@
pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>;
pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_dir_pins_b>;
pinctrl-2 = <&sdmmc1_b4_sleep_pins_a &sdmmc1_dir_sleep_pins_b>;
- cd-gpios = <&gpioi 8 GPIO_ACTIVE_LOW>;
disable-wp;
st,sig-dir;
st,neg-edge;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT
2020-04-02 16:53 [PATCH] ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT Marek Vasut
@ 2020-04-05 14:05 ` Manivannan Sadhasivam
2020-04-06 11:28 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2020-04-05 14:05 UTC (permalink / raw)
To: u-boot
On Thu, Apr 02, 2020 at 06:53:41PM +0200, Marek Vasut wrote:
> The card-detect GPIO and any other GPIO access currently doesn't work in
> U-Boot SPL on any STM32 platform and crashes the SPL. To work around this
> problem on AV96 right before release, remove the cd-gpios from DT. This
> patch must be reverted right after release, once the proper fix for the
> GPIO driver, "gpio: stm32: support gpio ops in SPL", is applied.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> NOTE: I think it's OK if Tom picks this one directly to reduce load on
> the ST people, since this is isolated to a single board.
> ---
> arch/arm/dts/stm32mp157a-avenger96.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/dts/stm32mp157a-avenger96.dts b/arch/arm/dts/stm32mp157a-avenger96.dts
> index 1f32395e71..b23fa6dee0 100644
> --- a/arch/arm/dts/stm32mp157a-avenger96.dts
> +++ b/arch/arm/dts/stm32mp157a-avenger96.dts
> @@ -353,7 +353,6 @@
> pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>;
> pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_dir_pins_b>;
> pinctrl-2 = <&sdmmc1_b4_sleep_pins_a &sdmmc1_dir_sleep_pins_b>;
> - cd-gpios = <&gpioi 8 GPIO_ACTIVE_LOW>;
> disable-wp;
> st,sig-dir;
> st,neg-edge;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT
2020-04-02 16:53 [PATCH] ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT Marek Vasut
2020-04-05 14:05 ` Manivannan Sadhasivam
@ 2020-04-06 11:28 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-04-06 11:28 UTC (permalink / raw)
To: u-boot
On Thu, Apr 02, 2020 at 06:53:41PM +0200, Marek Vasut wrote:
> The card-detect GPIO and any other GPIO access currently doesn't work in
> U-Boot SPL on any STM32 platform and crashes the SPL. To work around this
> problem on AV96 right before release, remove the cd-gpios from DT. This
> patch must be reverted right after release, once the proper fix for the
> GPIO driver, "gpio: stm32: support gpio ops in SPL", is applied.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Tom Rini <trini@konsulko.com>
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200406/38828296/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-06 11:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 16:53 [PATCH] ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT Marek Vasut
2020-04-05 14:05 ` Manivannan Sadhasivam
2020-04-06 11:28 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.