From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: Questionable aspects of QEMU Error's design
Date: Mon, 6 Apr 2020 15:10:19 +0100 [thread overview]
Message-ID: <20200406141019.GQ794362@redhat.com> (raw)
In-Reply-To: <87sghjfre8.fsf@dusky.pond.sub.org>
On Sat, Apr 04, 2020 at 12:59:27PM +0200, Markus Armbruster wrote:
> Paolo, Daniel, Eduardo,
>
> Please pick one for QOM:
> * Return true on success, false on error. Looks like
>
> if (!object_property_set_bool(..., errp)) {
> return;
> }
My preference is this one, since it aligns with GLib recommendations
for error reporting & is simple & concise.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-04-06 14:11 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 9:02 Questionable aspects of QEMU Error's design Markus Armbruster
2020-04-01 12:10 ` Vladimir Sementsov-Ogievskiy
2020-04-01 12:14 ` Vladimir Sementsov-Ogievskiy
2020-04-01 14:01 ` Alex Bennée
2020-04-01 15:49 ` Markus Armbruster
2020-04-01 15:05 ` Markus Armbruster
2020-04-01 12:44 ` Daniel P. Berrangé
2020-04-01 12:47 ` Vladimir Sementsov-Ogievskiy
2020-04-01 15:34 ` Markus Armbruster
2020-04-01 20:15 ` Peter Maydell
2020-04-02 5:31 ` Vladimir Sementsov-Ogievskiy
2020-04-02 9:36 ` BALATON Zoltan
2020-04-02 14:11 ` Vladimir Sementsov-Ogievskiy
2020-04-02 14:34 ` Markus Armbruster
2020-04-02 15:28 ` BALATON Zoltan
2020-04-03 7:09 ` Markus Armbruster
2020-04-02 5:54 ` Markus Armbruster
2020-04-02 6:11 ` Vladimir Sementsov-Ogievskiy
2020-04-02 8:11 ` Peter Maydell
2020-04-02 8:49 ` Daniel P. Berrangé
2020-04-02 8:55 ` Markus Armbruster
2020-04-02 14:35 ` Vladimir Sementsov-Ogievskiy
2020-04-02 15:06 ` Markus Armbruster
2020-04-02 17:17 ` Vladimir Sementsov-Ogievskiy
2020-04-03 7:48 ` Markus Armbruster
2020-04-02 18:57 ` Paolo Bonzini
2020-04-02 8:47 ` Daniel P. Berrangé
2020-04-02 9:19 ` Alex Bennée
2020-04-02 14:33 ` Eric Blake
2020-04-04 7:59 ` Markus Armbruster
2020-04-04 10:59 ` Markus Armbruster
2020-04-06 14:05 ` Eduardo Habkost
2020-04-06 14:38 ` Eduardo Habkost
2020-04-06 14:10 ` Daniel P. Berrangé [this message]
2020-04-27 15:36 ` Markus Armbruster
2020-04-28 5:20 ` Vladimir Sementsov-Ogievskiy
2020-05-14 7:59 ` Vladimir Sementsov-Ogievskiy
2020-05-15 4:28 ` Markus Armbruster
2020-07-03 7:38 ` Markus Armbruster
2020-07-03 9:07 ` Vladimir Sementsov-Ogievskiy
2020-07-03 12:21 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406141019.GQ794362@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.