From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 321A3C2BA1E for ; Mon, 6 Apr 2020 17:06:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06242249B9 for ; Mon, 6 Apr 2020 17:06:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="lf6JNRUW"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jwqO12Z5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729370AbgDFRGV (ORCPT ); Mon, 6 Apr 2020 13:06:21 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39419 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729369AbgDFRGV (ORCPT ); Mon, 6 Apr 2020 13:06:21 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 325775C00DE; Mon, 6 Apr 2020 13:06:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 06 Apr 2020 13:06:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=/Lzv8kkLpHF7KEkC03gWCBEbGdy eh40gc5Bji/fWTYM=; b=lf6JNRUWHYlCTNX5iy9Mbg+XEr5qr5VldpB/VuvIeKW s9Hn5kGcNgqErjar6SUGDb2J6W5Y3qI/atzOtjuBhbXITtBjWdI8Nl9G2vdlWL4j p5xYCHKYHyw70nxA17ggAK1umqbQcxpBKSIPiMIsimi5m7iRf2mfyuzl7hxjqhQ+ SQQl3Vf/TM2smq5gpRA/acnfchho2DlvJDpptESqcH2sG51b3/x1T6f8Bk0rWKDZ fUJAXAtDPi9x1GW7EtgdrtGb+PL9E2zHfVqPsO/9LviQA759NcfvD1UZffNQIizq VuNo/CQqN+5PX4tCzp6eJ1LzwDbkqF/XnkcRizWH9QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/Lzv8k kLpHF7KEkC03gWCBEbGdyeh40gc5Bji/fWTYM=; b=jwqO12Z59Car32DsUVCZ8b Z8wKdBVb8oQTe+4JvDe3Iqm2UBXVlv3ZU/XQqLPhy7e+qQtoJWMGyznzLulAxBRf TpSYLizrvQ7XzKr0tnQTVOsFhLGSaJvaJjCIDrl2ZXcENsA+7XjMeA+4+32UpJOf Ulb7+Qf7Nj0RtZSxOn8hcPv3xUcraxXb7Ifukx4dEhx1RV6BbWAPmRWMqzCF9VR3 QPktvECIIb5cEJqy9K9UkeO13KOre6aK4PrPGvXe4YHSQMIZxjiDT1ZVYu6tfGj1 CjBQTF8tY4KeR4Xd/wP3P9PsTncdYrUfDlflMjxVkq+bBiiipyqb0VYR9kERUnWw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefgddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecukfhppeeltd drkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghi lhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id C9373306D44A; Mon, 6 Apr 2020 13:06:18 -0400 (EDT) Date: Mon, 6 Apr 2020 19:06:17 +0200 From: Maxime Ripard To: Laurent Pinchart Cc: Laurent Pinchart , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Philipp Zabel , Mark Yao , Sandy Huang , Chen-Yu Tsai Subject: Re: [PATCH/RFC 2/6] dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML Message-ID: <20200406170617.uryn53wv62cbjwf5@gilmour.lan> References: <20200405233935.27599-1-laurent.pinchart+renesas@ideasonboard.com> <20200405233935.27599-3-laurent.pinchart+renesas@ideasonboard.com> <20200406075705.a67tjx7jamdvqpl3@gilmour.lan> <20200406112856.GE4757@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p57vkc2fwadv27ss" Content-Disposition: inline In-Reply-To: <20200406112856.GE4757@pendragon.ideasonboard.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --p57vkc2fwadv27ss Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 06, 2020 at 02:28:56PM +0300, Laurent Pinchart wrote: > > > + > > > + clock-names: > > > + items: > > > + - const: iahb > > > + - const: isfr > > > + > > > + interrupts: true > > > + > > > + ports: > > > + type: object > > > + description: | > > > + This device has three video ports. Their connections are modelled using the > > > + OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. > > > + Each port shall have a single endpoint. > > > + > > > + properties: > > > + '#address-cells': > > > + const: 1 > > > + > > > + '#size-cells': > > > + const: 0 > > > + > > > + port@0: > > > + type: object > > > + description: Parallel RGB input port > > > + > > > + port@1: > > > + type: object > > > + description: HDMI output port > > > + > > > + port@2: > > > + type: object > > > + description: Sound input port > > > + > > > + required: > > > + - port@0 > > > + - port@1 > > > + - port@2 > > > + > > > + additionalProperties: false > > > + > > > + power-domains: > > > + maxItems: 1 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - clocks > > > + - clock-names > > > + - interrupts > > > + - ports > > > + > > > +additionalProperties: false > > > > In the case where you have some kind of generic schema and then a more > > specific one like you have here, unevaluatedProperties make more sense > > that additionalProperties. > > > > additionalProperties checks that there are no extra properties on the > > current schema, which is a problem here since you have to duplicate > > the entire list of properties found in the generic schema, while > > unevaluatedProperties checks that there are no extra properties in the > > entire set of all schemas that apply to this node. > > > > This way, you can just put what is different from the generic schema, > > and you don't have to keep it in sync. > > > > It's a feature that has been added in the spec of the schemas that > > went on right after the one we support in the tools, so for now the > > kernel meta-schemas only allows that property to be there (just like > > deprecated) but won't do anything. > > > > This should be fixed quite soon however, the library we depend on > > has started to work on that spec apparently. > > Should I postpone this series until support for unevaluatedProperties is > available, to be able to test this ? There's no need to wait, just put it in and it will eventually be checked. And the time between now and then won't be worse than the current situation of not checking anything at all anyway :) Maxime --p57vkc2fwadv27ss Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXothiQAKCRDj7w1vZxhR xdVTAP4laC3rQPa7F72sLOS81gOVBqHyAuxuIZGWzQs1wG70swEAmG0Nph4gerBd OqkdNzncoK1Flv0SGeJ/D/eaJLhCWwg= =5keg -----END PGP SIGNATURE----- --p57vkc2fwadv27ss-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50B6BC2BA1B for ; Tue, 7 Apr 2020 08:10:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24370206F7 for ; Tue, 7 Apr 2020 08:10:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="lf6JNRUW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jwqO12Z5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24370206F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 695D56E5B4; Tue, 7 Apr 2020 08:09:36 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id D3A6D6E44E for ; Mon, 6 Apr 2020 17:06:20 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 325775C00DE; Mon, 6 Apr 2020 13:06:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 06 Apr 2020 13:06:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=/Lzv8kkLpHF7KEkC03gWCBEbGdy eh40gc5Bji/fWTYM=; b=lf6JNRUWHYlCTNX5iy9Mbg+XEr5qr5VldpB/VuvIeKW s9Hn5kGcNgqErjar6SUGDb2J6W5Y3qI/atzOtjuBhbXITtBjWdI8Nl9G2vdlWL4j p5xYCHKYHyw70nxA17ggAK1umqbQcxpBKSIPiMIsimi5m7iRf2mfyuzl7hxjqhQ+ SQQl3Vf/TM2smq5gpRA/acnfchho2DlvJDpptESqcH2sG51b3/x1T6f8Bk0rWKDZ fUJAXAtDPi9x1GW7EtgdrtGb+PL9E2zHfVqPsO/9LviQA759NcfvD1UZffNQIizq VuNo/CQqN+5PX4tCzp6eJ1LzwDbkqF/XnkcRizWH9QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/Lzv8k kLpHF7KEkC03gWCBEbGdyeh40gc5Bji/fWTYM=; b=jwqO12Z59Car32DsUVCZ8b Z8wKdBVb8oQTe+4JvDe3Iqm2UBXVlv3ZU/XQqLPhy7e+qQtoJWMGyznzLulAxBRf TpSYLizrvQ7XzKr0tnQTVOsFhLGSaJvaJjCIDrl2ZXcENsA+7XjMeA+4+32UpJOf Ulb7+Qf7Nj0RtZSxOn8hcPv3xUcraxXb7Ifukx4dEhx1RV6BbWAPmRWMqzCF9VR3 QPktvECIIb5cEJqy9K9UkeO13KOre6aK4PrPGvXe4YHSQMIZxjiDT1ZVYu6tfGj1 CjBQTF8tY4KeR4Xd/wP3P9PsTncdYrUfDlflMjxVkq+bBiiipyqb0VYR9kERUnWw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefgddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecukfhppeeltd drkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghi lhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id C9373306D44A; Mon, 6 Apr 2020 13:06:18 -0400 (EDT) Date: Mon, 6 Apr 2020 19:06:17 +0200 From: Maxime Ripard To: Laurent Pinchart Subject: Re: [PATCH/RFC 2/6] dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML Message-ID: <20200406170617.uryn53wv62cbjwf5@gilmour.lan> References: <20200405233935.27599-1-laurent.pinchart+renesas@ideasonboard.com> <20200405233935.27599-3-laurent.pinchart+renesas@ideasonboard.com> <20200406075705.a67tjx7jamdvqpl3@gilmour.lan> <20200406112856.GE4757@pendragon.ideasonboard.com> MIME-Version: 1.0 In-Reply-To: <20200406112856.GE4757@pendragon.ideasonboard.com> X-Mailman-Approved-At: Tue, 07 Apr 2020 08:09:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Laurent Pinchart , Sandy Huang , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Mark Yao Content-Type: multipart/mixed; boundary="===============1788004952==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1788004952== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p57vkc2fwadv27ss" Content-Disposition: inline --p57vkc2fwadv27ss Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 06, 2020 at 02:28:56PM +0300, Laurent Pinchart wrote: > > > + > > > + clock-names: > > > + items: > > > + - const: iahb > > > + - const: isfr > > > + > > > + interrupts: true > > > + > > > + ports: > > > + type: object > > > + description: | > > > + This device has three video ports. Their connections are modelled using the > > > + OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. > > > + Each port shall have a single endpoint. > > > + > > > + properties: > > > + '#address-cells': > > > + const: 1 > > > + > > > + '#size-cells': > > > + const: 0 > > > + > > > + port@0: > > > + type: object > > > + description: Parallel RGB input port > > > + > > > + port@1: > > > + type: object > > > + description: HDMI output port > > > + > > > + port@2: > > > + type: object > > > + description: Sound input port > > > + > > > + required: > > > + - port@0 > > > + - port@1 > > > + - port@2 > > > + > > > + additionalProperties: false > > > + > > > + power-domains: > > > + maxItems: 1 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - clocks > > > + - clock-names > > > + - interrupts > > > + - ports > > > + > > > +additionalProperties: false > > > > In the case where you have some kind of generic schema and then a more > > specific one like you have here, unevaluatedProperties make more sense > > that additionalProperties. > > > > additionalProperties checks that there are no extra properties on the > > current schema, which is a problem here since you have to duplicate > > the entire list of properties found in the generic schema, while > > unevaluatedProperties checks that there are no extra properties in the > > entire set of all schemas that apply to this node. > > > > This way, you can just put what is different from the generic schema, > > and you don't have to keep it in sync. > > > > It's a feature that has been added in the spec of the schemas that > > went on right after the one we support in the tools, so for now the > > kernel meta-schemas only allows that property to be there (just like > > deprecated) but won't do anything. > > > > This should be fixed quite soon however, the library we depend on > > has started to work on that spec apparently. > > Should I postpone this series until support for unevaluatedProperties is > available, to be able to test this ? There's no need to wait, just put it in and it will eventually be checked. And the time between now and then won't be worse than the current situation of not checking anything at all anyway :) Maxime --p57vkc2fwadv27ss Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXothiQAKCRDj7w1vZxhR xdVTAP4laC3rQPa7F72sLOS81gOVBqHyAuxuIZGWzQs1wG70swEAmG0Nph4gerBd OqkdNzncoK1Flv0SGeJ/D/eaJLhCWwg= =5keg -----END PGP SIGNATURE----- --p57vkc2fwadv27ss-- --===============1788004952== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1788004952==--