From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B63CCC2BA1B for ; Mon, 6 Apr 2020 17:58:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8083920719 for ; Mon, 6 Apr 2020 17:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586195893; bh=e06vrVeML9BgrogDrHrkIp58yEz5FUbz+0h5lORW6os=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Yq3zzvogP4oeyEnrUVs3yGn4zLUFgcycTzyl3o+YJcqply2B90BeqNSEbaYx7RrJa AS/p7VsNmS6xH1CvuU1Q0wPeyslTLxtJfB9DHJDlK1OzaEtABNIniKw2aP3CaUZMAu 2l7DOyXAsGX9vVMCdYxanrbzD1BAjIkDs5DFWHh4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbgDFR6M (ORCPT ); Mon, 6 Apr 2020 13:58:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:51084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbgDFR6M (ORCPT ); Mon, 6 Apr 2020 13:58:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1730D206F8; Mon, 6 Apr 2020 17:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586195891; bh=e06vrVeML9BgrogDrHrkIp58yEz5FUbz+0h5lORW6os=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X0Fr7y1LzcIEae6Qsb4GharopeCTFtdrHj4Qn6VPzfRayz6ZNT4l00fWUty2aW0g/ +ANDIgha7SuFM59OpjHfzpBhpn8VhhGc73P3D5yrkEvpyutNBWwcuRwJ5kTz42fAa1 8D2/Kgi9YmHFX4/sFIjHzGQYoAL3lCy5VvBr+64E= Date: Mon, 6 Apr 2020 19:58:08 +0200 From: Greg Kroah-Hartman To: Oscar Carter Cc: devel@driverdev.osuosl.org, Malcolm Priestley , linux-kernel@vger.kernel.org, Forest Bond , Dan Carpenter Subject: Re: [PATCH 2/3] staging: vt6656: Use define instead of magic number for tx_rate Message-ID: <20200406175808.GB167424@kroah.com> References: <20200404141400.3772-1-oscar.carter@gmx.com> <20200404141400.3772-3-oscar.carter@gmx.com> <20200406142212.GA48502@kroah.com> <20200406163835.GB3230@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200406163835.GB3230@ubuntu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 06, 2020 at 06:38:36PM +0200, Oscar Carter wrote: > On Mon, Apr 06, 2020 at 04:22:12PM +0200, Greg Kroah-Hartman wrote: > > On Sat, Apr 04, 2020 at 04:13:59PM +0200, Oscar Carter wrote: > > > Use the define RATE_11M present in the file "device.h" instead of the > > > magic number 3. So the code is more clear. > > > > > > Signed-off-by: Oscar Carter > > > Reviewed-by: Dan Carpenter > > > --- > > > drivers/staging/vt6656/baseband.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c > > > index 3e4bd637849a..a785f91c1566 100644 > > > --- a/drivers/staging/vt6656/baseband.c > > > +++ b/drivers/staging/vt6656/baseband.c > > > @@ -24,6 +24,7 @@ > > > > > > #include > > > #include > > > +#include "device.h" > > > #include "mac.h" > > > #include "baseband.h" > > > #include "rf.h" > > > @@ -141,7 +142,7 @@ unsigned int vnt_get_frame_time(u8 preamble_type, u8 pkt_type, > > > > > > rate = (unsigned int)vnt_frame_time[tx_rate]; > > > > > > - if (tx_rate <= 3) { > > > + if (tx_rate <= RATE_11M) { > > > if (preamble_type == 1) > > > preamble = 96; > > > else > > > -- > > > 2.20.1 > > > > This doesn't apply to my tree :( > > > Sorry, but I don't understand what it means. This meant that I need to rebase > this patch against your staging-next branch of your staging tree ? Yes, and 3/3 as well, because I dropped the 1/3 patch here. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE11BC2BA17 for ; Mon, 6 Apr 2020 17:58:17 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A71A1206F8 for ; Mon, 6 Apr 2020 17:58:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="X0Fr7y1L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A71A1206F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 532B887C2E; Mon, 6 Apr 2020 17:58:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id umjvU3fn5h6S; Mon, 6 Apr 2020 17:58:14 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 01CDF87B08; Mon, 6 Apr 2020 17:58:14 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 710281BF59C for ; Mon, 6 Apr 2020 17:58:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 6DBF787B08 for ; Mon, 6 Apr 2020 17:58:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MmbnI0qRthkS for ; Mon, 6 Apr 2020 17:58:11 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id BC39087AB1 for ; Mon, 6 Apr 2020 17:58:11 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1730D206F8; Mon, 6 Apr 2020 17:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586195891; bh=e06vrVeML9BgrogDrHrkIp58yEz5FUbz+0h5lORW6os=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X0Fr7y1LzcIEae6Qsb4GharopeCTFtdrHj4Qn6VPzfRayz6ZNT4l00fWUty2aW0g/ +ANDIgha7SuFM59OpjHfzpBhpn8VhhGc73P3D5yrkEvpyutNBWwcuRwJ5kTz42fAa1 8D2/Kgi9YmHFX4/sFIjHzGQYoAL3lCy5VvBr+64E= Date: Mon, 6 Apr 2020 19:58:08 +0200 From: Greg Kroah-Hartman To: Oscar Carter Subject: Re: [PATCH 2/3] staging: vt6656: Use define instead of magic number for tx_rate Message-ID: <20200406175808.GB167424@kroah.com> References: <20200404141400.3772-1-oscar.carter@gmx.com> <20200404141400.3772-3-oscar.carter@gmx.com> <20200406142212.GA48502@kroah.com> <20200406163835.GB3230@ubuntu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200406163835.GB3230@ubuntu> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Malcolm Priestley , linux-kernel@vger.kernel.org, Dan Carpenter , Forest Bond Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, Apr 06, 2020 at 06:38:36PM +0200, Oscar Carter wrote: > On Mon, Apr 06, 2020 at 04:22:12PM +0200, Greg Kroah-Hartman wrote: > > On Sat, Apr 04, 2020 at 04:13:59PM +0200, Oscar Carter wrote: > > > Use the define RATE_11M present in the file "device.h" instead of the > > > magic number 3. So the code is more clear. > > > > > > Signed-off-by: Oscar Carter > > > Reviewed-by: Dan Carpenter > > > --- > > > drivers/staging/vt6656/baseband.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c > > > index 3e4bd637849a..a785f91c1566 100644 > > > --- a/drivers/staging/vt6656/baseband.c > > > +++ b/drivers/staging/vt6656/baseband.c > > > @@ -24,6 +24,7 @@ > > > > > > #include > > > #include > > > +#include "device.h" > > > #include "mac.h" > > > #include "baseband.h" > > > #include "rf.h" > > > @@ -141,7 +142,7 @@ unsigned int vnt_get_frame_time(u8 preamble_type, u8 pkt_type, > > > > > > rate = (unsigned int)vnt_frame_time[tx_rate]; > > > > > > - if (tx_rate <= 3) { > > > + if (tx_rate <= RATE_11M) { > > > if (preamble_type == 1) > > > preamble = 96; > > > else > > > -- > > > 2.20.1 > > > > This doesn't apply to my tree :( > > > Sorry, but I don't understand what it means. This meant that I need to rebase > this patch against your staging-next branch of your staging tree ? Yes, and 3/3 as well, because I dropped the 1/3 patch here. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel