From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D166C2BA80 for ; Mon, 6 Apr 2020 23:19:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FD25206C3 for ; Mon, 6 Apr 2020 23:19:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wh907092" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbgDFXTp (ORCPT ); Mon, 6 Apr 2020 19:19:45 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:38478 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgDFXTp (ORCPT ); Mon, 6 Apr 2020 19:19:45 -0400 Received: by mail-pj1-f66.google.com with SMTP id m15so578641pje.3; Mon, 06 Apr 2020 16:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qiEMQ3MnZPBtfcN59NTsvK6kDONkxcqt/LljkK1BS58=; b=Wh9070924djEGtjlOfMWm3UFGyjc2B4vmxZxdcBAFkiAc1QiSjxqTx9d0m8DBopdP7 HuDT/VhNJC+8tM727HYCqdlOtJZVUQ8xhLKP2twBf5CUd4KQ15FMv7A9rkzcX3JPOUpe MV6It+FIRA2BIRSbq/bI6iw3+sXW8cqRPbwa7Y9KrRro2K3Nv0TiNBsKtmLZ2SErQfJl YJcpMjKVh/0EVzznKwspgZgcDJLvG/D4bnd9eBi1I62eZKe5iKtbub4+5EnPwyRRTtC5 TIZskK/zQ/mhyIhM7l8BYnFwGJTpp6KELsy9FFTvN0Uq67B2kLRPOSKlceAnBHUE/iAw sPGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qiEMQ3MnZPBtfcN59NTsvK6kDONkxcqt/LljkK1BS58=; b=TSh3PiWv1LzwJqWZsgj28/aMCpuG8lHq+uBmARDvGVrIXTaYUW9ykXVZVFFX/N9N1J uo8bys8HfdJzBJQ/qWOaFqgEuhRTpyH8EFuuguqq52kZVCLCzs7po+R6xf66nDPW6y2R 6of6x+gNxY8H8DTdxzPqQPfXWAbf47mOxwqxkWlmHKvmams+9stpLrM+/EW/ncnjqE3I SGrhiXj6bUsiEK7GVXOSp33Y7PCdW5sCxWGYfh1ZplOszxMdGny+W1cnk63U7JjjqpEp Pm6I1EfcwV4soqCFjwN78PUBqK8mQLUcAH9cFT2RyB3QgXRYfECz+jqVs5jWvP2bNeiF BEIQ== X-Gm-Message-State: AGi0Puak77a+QwFBIjD2VOAWde+5uj74a0OxLc2Uagy5rtiRT40nuJhf E/z4nwngd3eOJR0dDZT1eJ4= X-Google-Smtp-Source: APiQypKNp8VZ9mr4GVNmcAt4ce9e6kNxf3ZHvIuLkebI0RqZykks7BQ7hyl/mOXDC3laCG4n/sp25w== X-Received: by 2002:a17:90a:324b:: with SMTP id k69mr1963136pjb.50.1586215183169; Mon, 06 Apr 2020 16:19:43 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id c126sm12625459pfb.83.2020.04.06.16.19.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Apr 2020 16:19:43 -0700 (PDT) Date: Mon, 6 Apr 2020 16:19:45 -0700 From: Nicolin Chen To: Shengjiu Wang Cc: timur@kernel.org, Xiubo.Lee@gmail.com, festevam@gmail.com, broonie@kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 4/7] ASoC: fsl_asrc: Support new property fsl,asrc-format Message-ID: <20200406231945.GA20945@Asurada-Nvidia.nvidia.com> References: <496f49f1fe20b969f4456b591f62223d430c6d74.1585726761.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <496f49f1fe20b969f4456b591f62223d430c6d74.1585726761.git.shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just some small comments. On Wed, Apr 01, 2020 at 04:45:37PM +0800, Shengjiu Wang wrote: > In order to align with new ESARC, we add new property fsl,asrc-format. > The fsl,asrc-format can replace the fsl,asrc-width, driver > can accept format from devicetree, don't need to convert it to > format through width. > > Signed-off-by: Shengjiu Wang > --- > sound/soc/fsl/fsl_asrc.c | 40 ++++++++++++++++++++++-------------- > sound/soc/fsl/fsl_asrc.h | 4 ++-- > sound/soc/fsl/fsl_asrc_dma.c | 15 +++++++++++--- > 3 files changed, 39 insertions(+), 20 deletions(-) > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c > index 4d3e51bfa949..eea19e2b723b 100644 > --- a/sound/soc/fsl/fsl_asrc.c > +++ b/sound/soc/fsl/fsl_asrc.c > @@ -1052,16 +1047,31 @@ static int fsl_asrc_probe(struct platform_device *pdev) > return ret; > } > > - ret = of_property_read_u32(np, "fsl,asrc-width", > - &asrc->asrc_width); > + ret = of_property_read_u32(np, "fsl,asrc-format", &asrc->asrc_format); > if (ret) { > - dev_err(&pdev->dev, "failed to get output width\n"); > - return ret; > + ret = of_property_read_u32(np, "fsl,asrc-width", &width); > + if (ret) { > + dev_err(&pdev->dev, "failed to get output width\n"); Similar to the comments against sound card driver: "failed to decide output format" > + return ret; > + } > + > + switch (width) { > + case 16: > + asrc->asrc_format = SNDRV_PCM_FORMAT_S16_LE; > + break; > + case 24: > + asrc->asrc_format = SNDRV_PCM_FORMAT_S24_LE; > + break; > + default: > + dev_warn(&pdev->dev, "unsupported width, switching to 24bit\n"); Should match what the code does after the change: + dev_warn(&pdev->dev, + "unsupported width, use default S24_LE\n"); > + asrc->asrc_format = SNDRV_PCM_FORMAT_S24_LE; > + break; > + } > } > > - if (asrc->asrc_width != 16 && asrc->asrc_width != 24) { > - dev_warn(&pdev->dev, "unsupported width, switching to 24bit\n"); > - asrc->asrc_width = 24; > + if (!(FSL_ASRC_FORMATS & (1ULL << asrc->asrc_format))) { > + dev_warn(&pdev->dev, "unsupported format, switching to S24_LE\n"); Could fit 80 characters: + dev_warn(&pdev->dev, "unsupported width, use default S24_LE\n"); > diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c > index 5fe83aece25b..b15946e03380 100644 > --- a/sound/soc/fsl/fsl_asrc_dma.c > +++ b/sound/soc/fsl/fsl_asrc_dma.c > @@ -230,10 +230,19 @@ static int fsl_asrc_dma_hw_params(struct snd_soc_component *component, > return -EINVAL; > } > > - if (asrc->asrc_width == 16) > + bits = snd_pcm_format_physical_width(asrc->asrc_format); Can we just use 'width' to match the function name? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00816C2BB1D for ; Mon, 6 Apr 2020 23:20:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53397206C3 for ; Mon, 6 Apr 2020 23:20:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Sep6/Ha0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wh907092" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53397206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 949E6825; Tue, 7 Apr 2020 01:19:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 949E6825 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586215241; bh=gbIM8AmWdapqTdTlPUqtZqzGyitGX4Y8s6y5mUsVmww=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Sep6/Ha0Cm1aneB/bATy1Z513LfWp/J9UicNYu1/aa3+zNcRq9FVfwYvVT3CF3CY6 OXc0qnmQsiRbYz4AAGxfGcOLZtngck/fr8jTCum29oevtTwy6zClzDCQkGW+WFo+8a KKPOcoe1H72YPqgFNWWrH46ab1Uns1e9Qhe0ftd4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D66FBF80142; Tue, 7 Apr 2020 01:19:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 28494F80143; Tue, 7 Apr 2020 01:19:49 +0200 (CEST) Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 56900F80121 for ; Tue, 7 Apr 2020 01:19:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 56900F80121 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wh907092" Received: by mail-pj1-x1044.google.com with SMTP id z3so574276pjr.4 for ; Mon, 06 Apr 2020 16:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qiEMQ3MnZPBtfcN59NTsvK6kDONkxcqt/LljkK1BS58=; b=Wh9070924djEGtjlOfMWm3UFGyjc2B4vmxZxdcBAFkiAc1QiSjxqTx9d0m8DBopdP7 HuDT/VhNJC+8tM727HYCqdlOtJZVUQ8xhLKP2twBf5CUd4KQ15FMv7A9rkzcX3JPOUpe MV6It+FIRA2BIRSbq/bI6iw3+sXW8cqRPbwa7Y9KrRro2K3Nv0TiNBsKtmLZ2SErQfJl YJcpMjKVh/0EVzznKwspgZgcDJLvG/D4bnd9eBi1I62eZKe5iKtbub4+5EnPwyRRTtC5 TIZskK/zQ/mhyIhM7l8BYnFwGJTpp6KELsy9FFTvN0Uq67B2kLRPOSKlceAnBHUE/iAw sPGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qiEMQ3MnZPBtfcN59NTsvK6kDONkxcqt/LljkK1BS58=; b=iU3kfXR8pyVXCLQfGVenL3//LrNCPMFLGv7j5U1ySGaGLPT4+E9fa4C0Dt6LUfkwen MMdzPCqz2UNqQ+vWoxGLxK31YcCtPDHZ1LEVn4VMXFXHhqjRvO7p2v6k6zgBSU3NBr8s 04n2YZQqVlz4e2FH8bf5UabtAxhMWEzk4ZdvdxxTZBP/pTsuYdLfRYLcyigWWaMWRjz6 8apGRGV6Mb4JDOp/rX7jxofglnbWYlFYvf+RSZoMKboCSub8HNDoYcZIrw2niaXtJQ10 u99Dl0itSVUOjkHN8W6biBmnGZaIEAmD9qtbPoMcmfA557AvFGlH3dvE6Nfvv8mlqGa/ V8RQ== X-Gm-Message-State: AGi0PuZm47vXTHoEyGg+74hKPtnVnUksQLyUT4VI7buSgVzFIXBK5ulc NwNSs+337Rz8Y4ICGqqREAY= X-Google-Smtp-Source: APiQypKNp8VZ9mr4GVNmcAt4ce9e6kNxf3ZHvIuLkebI0RqZykks7BQ7hyl/mOXDC3laCG4n/sp25w== X-Received: by 2002:a17:90a:324b:: with SMTP id k69mr1963136pjb.50.1586215183169; Mon, 06 Apr 2020 16:19:43 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id c126sm12625459pfb.83.2020.04.06.16.19.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Apr 2020 16:19:43 -0700 (PDT) Date: Mon, 6 Apr 2020 16:19:45 -0700 From: Nicolin Chen To: Shengjiu Wang Subject: Re: [PATCH v6 4/7] ASoC: fsl_asrc: Support new property fsl,asrc-format Message-ID: <20200406231945.GA20945@Asurada-Nvidia.nvidia.com> References: <496f49f1fe20b969f4456b591f62223d430c6d74.1585726761.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <496f49f1fe20b969f4456b591f62223d430c6d74.1585726761.git.shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, festevam@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Just some small comments. On Wed, Apr 01, 2020 at 04:45:37PM +0800, Shengjiu Wang wrote: > In order to align with new ESARC, we add new property fsl,asrc-format. > The fsl,asrc-format can replace the fsl,asrc-width, driver > can accept format from devicetree, don't need to convert it to > format through width. > > Signed-off-by: Shengjiu Wang > --- > sound/soc/fsl/fsl_asrc.c | 40 ++++++++++++++++++++++-------------- > sound/soc/fsl/fsl_asrc.h | 4 ++-- > sound/soc/fsl/fsl_asrc_dma.c | 15 +++++++++++--- > 3 files changed, 39 insertions(+), 20 deletions(-) > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c > index 4d3e51bfa949..eea19e2b723b 100644 > --- a/sound/soc/fsl/fsl_asrc.c > +++ b/sound/soc/fsl/fsl_asrc.c > @@ -1052,16 +1047,31 @@ static int fsl_asrc_probe(struct platform_device *pdev) > return ret; > } > > - ret = of_property_read_u32(np, "fsl,asrc-width", > - &asrc->asrc_width); > + ret = of_property_read_u32(np, "fsl,asrc-format", &asrc->asrc_format); > if (ret) { > - dev_err(&pdev->dev, "failed to get output width\n"); > - return ret; > + ret = of_property_read_u32(np, "fsl,asrc-width", &width); > + if (ret) { > + dev_err(&pdev->dev, "failed to get output width\n"); Similar to the comments against sound card driver: "failed to decide output format" > + return ret; > + } > + > + switch (width) { > + case 16: > + asrc->asrc_format = SNDRV_PCM_FORMAT_S16_LE; > + break; > + case 24: > + asrc->asrc_format = SNDRV_PCM_FORMAT_S24_LE; > + break; > + default: > + dev_warn(&pdev->dev, "unsupported width, switching to 24bit\n"); Should match what the code does after the change: + dev_warn(&pdev->dev, + "unsupported width, use default S24_LE\n"); > + asrc->asrc_format = SNDRV_PCM_FORMAT_S24_LE; > + break; > + } > } > > - if (asrc->asrc_width != 16 && asrc->asrc_width != 24) { > - dev_warn(&pdev->dev, "unsupported width, switching to 24bit\n"); > - asrc->asrc_width = 24; > + if (!(FSL_ASRC_FORMATS & (1ULL << asrc->asrc_format))) { > + dev_warn(&pdev->dev, "unsupported format, switching to S24_LE\n"); Could fit 80 characters: + dev_warn(&pdev->dev, "unsupported width, use default S24_LE\n"); > diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c > index 5fe83aece25b..b15946e03380 100644 > --- a/sound/soc/fsl/fsl_asrc_dma.c > +++ b/sound/soc/fsl/fsl_asrc_dma.c > @@ -230,10 +230,19 @@ static int fsl_asrc_dma_hw_params(struct snd_soc_component *component, > return -EINVAL; > } > > - if (asrc->asrc_width == 16) > + bits = snd_pcm_format_physical_width(asrc->asrc_format); Can we just use 'width' to match the function name? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB18DC2BA1A for ; Mon, 6 Apr 2020 23:22:28 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D21220753 for ; Mon, 6 Apr 2020 23:22:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wh907092" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D21220753 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48x65F22yfzDqLC for ; Tue, 7 Apr 2020 09:22:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::1042; helo=mail-pj1-x1042.google.com; envelope-from=nicoleotsuka@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Wh907092; dkim-atps=neutral Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48x62B1Sk0zDqpp for ; Tue, 7 Apr 2020 09:19:45 +1000 (AEST) Received: by mail-pj1-x1042.google.com with SMTP id k3so583634pjj.2 for ; Mon, 06 Apr 2020 16:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qiEMQ3MnZPBtfcN59NTsvK6kDONkxcqt/LljkK1BS58=; b=Wh9070924djEGtjlOfMWm3UFGyjc2B4vmxZxdcBAFkiAc1QiSjxqTx9d0m8DBopdP7 HuDT/VhNJC+8tM727HYCqdlOtJZVUQ8xhLKP2twBf5CUd4KQ15FMv7A9rkzcX3JPOUpe MV6It+FIRA2BIRSbq/bI6iw3+sXW8cqRPbwa7Y9KrRro2K3Nv0TiNBsKtmLZ2SErQfJl YJcpMjKVh/0EVzznKwspgZgcDJLvG/D4bnd9eBi1I62eZKe5iKtbub4+5EnPwyRRTtC5 TIZskK/zQ/mhyIhM7l8BYnFwGJTpp6KELsy9FFTvN0Uq67B2kLRPOSKlceAnBHUE/iAw sPGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qiEMQ3MnZPBtfcN59NTsvK6kDONkxcqt/LljkK1BS58=; b=a6vJ8P6qto7+vgrmtPTPCYsCoDiVadNIDOxblkVl02GImWj2MLtt4sT/NlUd9mHc+u BH2FTMQEJjZaQxlXWAIrWMuhcyU5nFOoM4/6Szl75Syf0v41S8JSIhQS1AGIxHAGQKUO qnZw1FHUIyWJ9Qha9xbR/2d65MrlOaDkmzkI0Kf5ixowbiJa7MIcVgL3SHdaEXGJuJAP hk8EE4Au+0DDLwUehew71nJ723pm0BkCME6FTFMbSFGDlDs3UN1H7vb4ViKIuGE5iUxb rfw4dOJHwc4vayQO5i1Sl4SreL6z6uAF51WJIoincK2W/fhjo/6f3U7Ambvu7q25AJsT vzUg== X-Gm-Message-State: AGi0PuZEQNYUUjUPEKu9pJ7mAC+V0EdL5uhWHSB7+P7kCypony4Lbl7r cxH/xJKmlC8dCfzaHI2MkkGYCwn8 X-Google-Smtp-Source: APiQypKNp8VZ9mr4GVNmcAt4ce9e6kNxf3ZHvIuLkebI0RqZykks7BQ7hyl/mOXDC3laCG4n/sp25w== X-Received: by 2002:a17:90a:324b:: with SMTP id k69mr1963136pjb.50.1586215183169; Mon, 06 Apr 2020 16:19:43 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id c126sm12625459pfb.83.2020.04.06.16.19.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Apr 2020 16:19:43 -0700 (PDT) Date: Mon, 6 Apr 2020 16:19:45 -0700 From: Nicolin Chen To: Shengjiu Wang Subject: Re: [PATCH v6 4/7] ASoC: fsl_asrc: Support new property fsl,asrc-format Message-ID: <20200406231945.GA20945@Asurada-Nvidia.nvidia.com> References: <496f49f1fe20b969f4456b591f62223d430c6d74.1585726761.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <496f49f1fe20b969f4456b591f62223d430c6d74.1585726761.git.shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org, perex@perex.cz, broonie@kernel.org, festevam@gmail.com, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Just some small comments. On Wed, Apr 01, 2020 at 04:45:37PM +0800, Shengjiu Wang wrote: > In order to align with new ESARC, we add new property fsl,asrc-format. > The fsl,asrc-format can replace the fsl,asrc-width, driver > can accept format from devicetree, don't need to convert it to > format through width. > > Signed-off-by: Shengjiu Wang > --- > sound/soc/fsl/fsl_asrc.c | 40 ++++++++++++++++++++++-------------- > sound/soc/fsl/fsl_asrc.h | 4 ++-- > sound/soc/fsl/fsl_asrc_dma.c | 15 +++++++++++--- > 3 files changed, 39 insertions(+), 20 deletions(-) > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c > index 4d3e51bfa949..eea19e2b723b 100644 > --- a/sound/soc/fsl/fsl_asrc.c > +++ b/sound/soc/fsl/fsl_asrc.c > @@ -1052,16 +1047,31 @@ static int fsl_asrc_probe(struct platform_device *pdev) > return ret; > } > > - ret = of_property_read_u32(np, "fsl,asrc-width", > - &asrc->asrc_width); > + ret = of_property_read_u32(np, "fsl,asrc-format", &asrc->asrc_format); > if (ret) { > - dev_err(&pdev->dev, "failed to get output width\n"); > - return ret; > + ret = of_property_read_u32(np, "fsl,asrc-width", &width); > + if (ret) { > + dev_err(&pdev->dev, "failed to get output width\n"); Similar to the comments against sound card driver: "failed to decide output format" > + return ret; > + } > + > + switch (width) { > + case 16: > + asrc->asrc_format = SNDRV_PCM_FORMAT_S16_LE; > + break; > + case 24: > + asrc->asrc_format = SNDRV_PCM_FORMAT_S24_LE; > + break; > + default: > + dev_warn(&pdev->dev, "unsupported width, switching to 24bit\n"); Should match what the code does after the change: + dev_warn(&pdev->dev, + "unsupported width, use default S24_LE\n"); > + asrc->asrc_format = SNDRV_PCM_FORMAT_S24_LE; > + break; > + } > } > > - if (asrc->asrc_width != 16 && asrc->asrc_width != 24) { > - dev_warn(&pdev->dev, "unsupported width, switching to 24bit\n"); > - asrc->asrc_width = 24; > + if (!(FSL_ASRC_FORMATS & (1ULL << asrc->asrc_format))) { > + dev_warn(&pdev->dev, "unsupported format, switching to S24_LE\n"); Could fit 80 characters: + dev_warn(&pdev->dev, "unsupported width, use default S24_LE\n"); > diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c > index 5fe83aece25b..b15946e03380 100644 > --- a/sound/soc/fsl/fsl_asrc_dma.c > +++ b/sound/soc/fsl/fsl_asrc_dma.c > @@ -230,10 +230,19 @@ static int fsl_asrc_dma_hw_params(struct snd_soc_component *component, > return -EINVAL; > } > > - if (asrc->asrc_width == 16) > + bits = snd_pcm_format_physical_width(asrc->asrc_format); Can we just use 'width' to match the function name?