All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sultan Alsawaf <sultan@kerneltoast.com>
To: stable@vger.kernel.org
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Sultan Alsawaf <sultan@kerneltoast.com>
Subject: [PATCH 0/1] drm/i915: Fix a deadlock that only affects 5.4
Date: Mon,  6 Apr 2020 23:26:21 -0700	[thread overview]
Message-ID: <20200407062622.6443-1-sultan@kerneltoast.com> (raw)

From: Sultan Alsawaf <sultan@kerneltoast.com>

Hi,

There's a mutex lock deadlock in i915 that only affects 5.4, but was fixed in
5.5. Normally, I would send a backport of the fix from 5.5, but the patch set
that fixes the deadlock involves massive changes that are neither feasible nor
desirable for backporting [1][2][3]. Therefore, I've made a small patch that
only addresses the deadlock specifically for 5.4.

Thanks,
Sultan

[1] 274cbf20fd10 ("drm/i915: Push the i915_active.retire into a worker")
[2] 093b92287363 ("drm/i915: Split i915_active.mutex into an irq-safe spinlock for the rbtree")
[3] 750bde2fd4ff ("drm/i915: Serialise with remote retirement")

Sultan Alsawaf (1):
  drm/i915: Fix ref->mutex deadlock in i915_active_wait()

 drivers/gpu/drm/i915/i915_active.c | 27 +++++++++++++++++++++++----
 drivers/gpu/drm/i915/i915_active.h |  4 ++--
 2 files changed, 25 insertions(+), 6 deletions(-)

-- 
2.26.0


             reply	other threads:[~2020-04-07  6:26 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  6:26 Sultan Alsawaf [this message]
2020-04-07  6:26 ` [PATCH 1/1] drm/i915: Fix ref->mutex deadlock in i915_active_wait() Sultan Alsawaf
2020-04-14  8:13   ` Chris Wilson
2020-04-14  8:13     ` [Intel-gfx] " Chris Wilson
2020-04-14  8:13     ` Chris Wilson
2020-04-14 14:52     ` Sultan Alsawaf
2020-04-14 14:52       ` [Intel-gfx] " Sultan Alsawaf
2020-04-14 14:52       ` Sultan Alsawaf
2020-04-07  6:52 ` [PATCH 0/1] drm/i915: Fix a deadlock that only affects 5.4 Greg KH
2020-04-07  6:52   ` [Intel-gfx] " Greg KH
2020-04-07  6:52   ` Greg KH
2020-04-07  7:18   ` [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait() Sultan Alsawaf
2020-04-07 20:32     ` [PATCH v3] " Sultan Alsawaf
2020-04-11 11:39       ` Patch "drm/i915: Fix ref->mutex deadlock in i915_active_wait()" has been added to the 5.4-stable tree gregkh
2020-04-11 11:39         ` [Intel-gfx] " gregkh
2020-04-11 11:59       ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Patch "drm/i915: Fix ref->mutex deadlock in i915_active_wait()" has been added to the 5.4-stable tree (rev2) Patchwork
2020-04-10  9:08     ` [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait() Greg KH
2020-04-10  9:08       ` [Intel-gfx] " Greg KH
2020-04-10  9:08       ` Greg KH
2020-04-10 14:15       ` Sultan Alsawaf
2020-04-10 14:15         ` [Intel-gfx] " Sultan Alsawaf
2020-04-10 14:15         ` Sultan Alsawaf
2020-04-10 14:17       ` Sultan Alsawaf
2020-04-10 14:17         ` [Intel-gfx] " Sultan Alsawaf
2020-04-10 14:17         ` Sultan Alsawaf
2020-04-11 11:39         ` Greg KH
2020-04-11 11:39           ` [Intel-gfx] " Greg KH
2020-04-11 11:39           ` Greg KH
2020-04-14  8:15           ` Chris Wilson
2020-04-14  8:15             ` [Intel-gfx] " Chris Wilson
2020-04-14  8:15             ` Chris Wilson
2020-04-14  8:23             ` Greg KH
2020-04-14  8:23               ` [Intel-gfx] " Greg KH
2020-04-14  8:23               ` Greg KH
2020-04-20  9:02               ` Joonas Lahtinen
2020-04-20  9:02                 ` [Intel-gfx] " Joonas Lahtinen
2020-04-20  9:02                 ` Joonas Lahtinen
2020-04-20 15:42                 ` Sultan Alsawaf
2020-04-20 15:42                   ` [Intel-gfx] " Sultan Alsawaf
2020-04-20 15:42                   ` Sultan Alsawaf
2020-04-21  8:04                   ` Joonas Lahtinen
2020-04-21  8:04                     ` [Intel-gfx] " Joonas Lahtinen
2020-04-21  8:04                     ` Joonas Lahtinen
2020-04-21 16:38                     ` Sultan Alsawaf
2020-04-21 16:38                       ` [Intel-gfx] " Sultan Alsawaf
2020-04-21 16:38                       ` Sultan Alsawaf
2020-04-21 20:55                       ` Jason A. Donenfeld
2020-04-21 20:55                         ` [Intel-gfx] " Jason A. Donenfeld
2020-04-21 20:55                         ` Jason A. Donenfeld
2020-04-14 14:35             ` Sultan Alsawaf
2020-04-14 14:35               ` [Intel-gfx] " Sultan Alsawaf
2020-04-14 14:35               ` Sultan Alsawaf
2020-04-10 11:46     ` Patch "drm/i915: Fix ref->mutex deadlock in i915_active_wait()" has been added to the 5.4-stable tree gregkh
2020-04-10 11:46       ` [Intel-gfx] " gregkh
2020-04-10 11:56     ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200407062622.6443-1-sultan@kerneltoast.com \
    --to=sultan@kerneltoast.com \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.