From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89162C2BB1D for ; Tue, 7 Apr 2020 11:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 398B1206F7 for ; Tue, 7 Apr 2020 11:06:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="HWFLQJXP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728331AbgDGLGE (ORCPT ); Tue, 7 Apr 2020 07:06:04 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:39084 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbgDGLGD (ORCPT ); Tue, 7 Apr 2020 07:06:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ELJ99tITBvhqYigpmJYU0Eq7MDv1Ib9ta9OZruxk3Zg=; b=HWFLQJXP/3Dv/I2y6UrSKLOOV c1pMolTgR+++g74RwnASHgtf2QboyHLiTuPO8Dn58QLJGJBVCtQZVlr+I//mlKfli4y5uJDWRTA8s JNRS/HAsiOD5+levYZzDnKj06Y/bRRCenktaIYQBHs9QrfqRPrMLh70/u0OyRskPfjeigjL/8aJw/ 9W5unwTDSPKfJeAR2G1O33lsBYBfBZNYkzL2W0n2XleWXt4OQPR9hiykqEJj6J1vvZmF0JvrNBkEg jByJqzpI7UFZ0V1Zgl24IrudM3xqjU2C3iHzD8Yy9/Ct1ycxu+5bsf44lnm8f7IyX9BanFEb8hovd cgNmeCeag==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46826) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jLm37-0007Wa-Mh; Tue, 07 Apr 2020 12:05:45 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jLm32-0007aa-Mp; Tue, 07 Apr 2020 12:05:40 +0100 Date: Tue, 7 Apr 2020 12:05:40 +0100 From: Russell King - ARM Linux admin To: Philippe Schenker Cc: "o.rempel@pengutronix.de" , "hkallweit1@gmail.com" , "f.fainelli@gmail.com" , "andrew@lunn.ch" , "kernel@pengutronix.de" , "davem@davemloft.net" , "david@protonic.nl" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY Message-ID: <20200407110540.GM25745@shell.armlinux.org.uk> References: <20200407093654.26095-1-o.rempel@pengutronix.de> <699bf716ce12178655b47ce77227e4e42b85de1b.camel@toradex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <699bf716ce12178655b47ce77227e4e42b85de1b.camel@toradex.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2020 at 10:57:07AM +0000, Philippe Schenker wrote: > On Tue, 2020-04-07 at 11:36 +0200, Oleksij Rempel wrote: > > Add support for following phy-modes: rgmii, rgmii-id, rgmii-txid, > > rgmii-rxid. > > > > This PHY has an internal RX delay of 1.2ns and no delay for TX. > > > > The pad skew registers allow to set the total TX delay to max 1.38ns > > and > > the total RX delay to max of 2.58ns (configurable 1.38ns + build in > > 1.2ns) and a minimal delay of 0ns. > > > > According to the RGMII v1.3 specification the delay provided by PCB > > traces > > should be between 1.5ns and 2.0ns. The RGMII v2.0 allows to provide > > this > > delay by MAC or PHY. So, we configure this PHY to the best values we > > can > > get by this HW: TX delay to 1.38ns (max supported value) and RX delay > > to > > 1.80ns (best calculated delay) > > > > The phy-modes can still be fine tuned/overwritten by *-skew-ps > > device tree properties described in: > > Documentation/devicetree/bindings/net/micrel-ksz90x1.txt > > > > Signed-off-by: Oleksij Rempel > > Make sure you do not exceet 80 chars with your phydev_warn. Besides > that: There are exceptions to the 80 column rule. From coding-style.rst: Statements longer than 80 columns will be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information. Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list. *However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them.* -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up