All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 12/13] configure: Add -Werror to PIE probe
Date: Tue,  7 Apr 2020 16:51:17 +0100	[thread overview]
Message-ID: <20200407155118.20139-13-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200407155118.20139-1-alex.bennee@linaro.org>

From: Richard Henderson <richard.henderson@linaro.org>

Without -Werror, the probe may succeed, but then compilation fails
later when -Werror is added for other reasons.  Shows up on windows,
where the compiler complains about -fPIC.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200401214756.6559-1-richard.henderson@linaro.org>
Message-Id: <20200403191150.863-13-alex.bennee@linaro.org>

diff --git a/configure b/configure
index 22870f38672..233c671aaa9 100755
--- a/configure
+++ b/configure
@@ -2119,7 +2119,7 @@ if compile_prog "-Werror -fno-pie" "-no-pie"; then
 fi
 
 if test "$static" = "yes"; then
-  if test "$pie" != "no" && compile_prog "-fPIE -DPIE" "-static-pie"; then
+  if test "$pie" != "no" && compile_prog "-Werror -fPIE -DPIE" "-static-pie"; then
     QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"
     QEMU_LDFLAGS="-static-pie $QEMU_LDFLAGS"
     pie="yes"
@@ -2132,7 +2132,7 @@ if test "$static" = "yes"; then
 elif test "$pie" = "no"; then
   QEMU_CFLAGS="$CFLAGS_NOPIE $QEMU_CFLAGS"
   QEMU_LDFLAGS="$LDFLAGS_NOPIE $QEMU_LDFLAGS"
-elif compile_prog "-fPIE -DPIE" "-pie"; then
+elif compile_prog "-Werror -fPIE -DPIE" "-pie"; then
   QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"
   QEMU_LDFLAGS="-pie $QEMU_LDFLAGS"
   pie="yes"
-- 
2.20.1



  parent reply	other threads:[~2020-04-07 15:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 15:51 [PULL for 5.0-rc2 00/13] various fixes Alex Bennée
2020-04-07 15:51 ` [PULL 01/13] .github: Enable repo-lockdown bot to refuse GitHub pull requests Alex Bennée
2020-04-07 15:51 ` [PULL 02/13] elf-ops: bail out if we have no function symbols Alex Bennée
2020-04-07 15:51 ` [PULL 03/13] linux-user: protect fcntl64 with an #ifdef Alex Bennée
2020-04-07 15:51 ` [PULL 04/13] tests/tcg: remove extraneous pasting macros Alex Bennée
2020-04-07 15:51 ` [PULL 05/13] linux-user: more debug for init_guest_space Alex Bennée
2020-04-07 15:51 ` [PULL 06/13] target/xtensa: add FIXME for translation memory leak Alex Bennée
2020-04-07 15:51 ` [PULL 07/13] gdbstub: fix compiler complaining Alex Bennée
2020-04-07 15:51 ` [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal Alex Bennée
2020-04-10  9:38   ` Aleksandar Markovic
2020-04-10 15:17     ` Richard Henderson
2020-04-10 15:54       ` Aleksandar Markovic
2020-04-10 16:13       ` Peter Maydell
2020-04-10 18:33         ` Aleksandar Markovic
2020-04-11 12:55         ` Alex Bennée
2020-04-07 15:51 ` [PULL 09/13] linux-user: factor out reading of /proc/self/maps Alex Bennée
2020-04-07 15:51 ` [PULL 10/13] linux-user: clean-up padding on /proc/self/maps Alex Bennée
2020-04-07 15:51 ` [PULL 11/13] hw/core: properly terminate loading .hex on EOF record Alex Bennée
2020-04-07 15:51 ` Alex Bennée [this message]
2020-04-07 16:08   ` [PULL 12/13] configure: Add -Werror to PIE probe Mark Cave-Ayland
2020-04-07 16:25     ` Richard Henderson
2020-04-07 15:51 ` [PULL 13/13] tcg/i386: Fix %r12 guest_base initialization Alex Bennée
2020-04-07 22:13 ` [PULL for 5.0-rc2 00/13] various fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200407155118.20139-13-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.