From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25E88C2BA1B for ; Wed, 8 Apr 2020 19:46:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E723820768 for ; Wed, 8 Apr 2020 19:46:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E723820768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 861E06EAC4; Wed, 8 Apr 2020 19:46:46 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8A3C86EAC4 for ; Wed, 8 Apr 2020 19:46:45 +0000 (UTC) IronPort-SDR: mlhyLOv7lACZ0FFVEHKcICkJGj6xXa4LVQxiTtAfNJ1Z7CYFBoS4M1oZu1WOGykPk3RfbbyN3c vgUTfwMV5JTg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2020 12:46:44 -0700 IronPort-SDR: /ssnNYJCmhhl+UKY7pjITYvW3ww3kpnGm3S0Gz2UKnElCgZ0vrjSKUO1vPhNuR528KCqbpgP1X snVm8qgDCdtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,359,1580803200"; d="scan'208";a="269853095" Received: from linux.fm.intel.com (HELO intel.com) ([10.1.27.42]) by orsmga002.jf.intel.com with ESMTP; 08 Apr 2020 12:46:44 -0700 Date: Wed, 8 Apr 2020 12:46:44 -0700 From: Venkata Sandeep Dhanalakota To: Chris Wilson Message-ID: <20200408194644.GB22556@intel.com> References: <20200403091300.14734-1-chris@chris-wilson.co.uk> <20200403091300.14734-4-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200403091300.14734-4-chris@chris-wilson.co.uk> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH 04/10] dma-buf: Report signaled links inside dma-fence-chain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 20/04/03 10:12, Chris Wilson wrote: > Whenever we walk along the dma-fence-chain, we prune signaled links to > keep the chain nice and tidy. This leads to situations where we can > prune a link and report the earlier fence as the target seqno -- > violating our own consistency checks that the seqno is not more advanced > than the last element in a dma-fence-chain. > > Report a NULL fence and success if the seqno has already been signaled. > > Signed-off-by: Chris Wilson > --- > drivers/dma-buf/dma-fence-chain.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c > index 3d123502ff12..c435bbba851c 100644 > --- a/drivers/dma-buf/dma-fence-chain.c > +++ b/drivers/dma-buf/dma-fence-chain.c > @@ -99,6 +99,12 @@ int dma_fence_chain_find_seqno(struct dma_fence **pfence, uint64_t seqno) > return -EINVAL; > > dma_fence_chain_for_each(*pfence, &chain->base) { > + if ((*pfence)->seqno < seqno) { /* already signaled */ > + dma_fence_put(*pfence); > + *pfence = NULL; > + break; > + } > + Looks good to me. Tested-by: Venkata Sandeep Dhanalakota Reviewed-by: Venkata Sandeep Dhanalakota > if ((*pfence)->context != chain->base.context || > to_dma_fence_chain(*pfence)->prev_seqno < seqno) > break; > @@ -222,6 +228,7 @@ EXPORT_SYMBOL(dma_fence_chain_ops); > * @chain: the chain node to initialize > * @prev: the previous fence > * @fence: the current fence > + * @seqno: the sequence number (syncpt) of the fence within the chain > * > * Initialize a new chain node and either start a new chain or add the node to > * the existing chain of the previous fence. > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx