From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71725C2D0F4 for ; Wed, 8 Apr 2020 21:58:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 331F820730 for ; Wed, 8 Apr 2020 21:58:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yadro.com header.i=@yadro.com header.b="H5n7gIe4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726641AbgDHV6A (ORCPT ); Wed, 8 Apr 2020 17:58:00 -0400 Received: from mta-02.yadro.com ([89.207.88.252]:33970 "EHLO mta-01.yadro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726608AbgDHV6A (ORCPT ); Wed, 8 Apr 2020 17:58:00 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 927784124F; Wed, 8 Apr 2020 21:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date:received:received:received; s=mta-01; t=1586383077; x=1588197478; bh=U8cClCXpNlo45zPq2gakiUTbKQK47yPMPXg6HCvlvwk=; b= H5n7gIe4ydnDQJXnpNC13t3QW8dXdWhECzgHNjhTWdJCUgbJNswweae3+GWEDoGY mUIZoRO94WjuXT7uvzawS7IeftOosNnI3XCVAS+l6AChELS2FWa76usuZS4igiBC woZ41GWTG2y5vb/0hKDx/TSnULg3ChK/IkJshDhTU8o= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RbOxFkkwUefS; Thu, 9 Apr 2020 00:57:57 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 8FC6241284; Thu, 9 Apr 2020 00:57:56 +0300 (MSK) Received: from localhost (172.17.204.212) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Thu, 9 Apr 2020 00:57:56 +0300 Date: Thu, 9 Apr 2020 00:57:56 +0300 From: Roman Bolshakov To: Bart Van Assche CC: "Martin K . Petersen" , "James E . J . Bottomley" , , Nilesh Javali , Himanshu Madhani , Quinn Tran , Martin Wilck , Daniel Wagner Subject: Re: [PATCH] qla2xxx: Split qla2x00_configure_local_loop() Message-ID: <20200408215756.GC17172@SPB-NB-133.local> References: <20200405225905.17171-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200405225905.17171-1-bvanassche@acm.org> X-Originating-IP: [172.17.204.212] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-02.corp.yadro.com (172.17.10.102) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Sun, Apr 05, 2020 at 03:59:05PM -0700, Bart Van Assche wrote: > The size of the function qla2x00_configure_local_loop() hurts its > readability. Hence split that function. This patch does not change > any functionality. > Hi Bart, Reviewed-by: Roman Bolshakov Thanks, Roman