Hi Jiaxun, I love your patch! Yet something to improve: [auto build test ERROR on driver-core/driver-core-testing] [also build test ERROR on linus/master next-20200408] [cannot apply to tip/perf/core tip/irq/core v5.6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jiaxun-Yang/MIPS-Topology-DeviceTree-CPU-rework/20200409-021602 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git a10c9c710f9ecea87b9f4bbb837467893b4bef01 config: mips-allnoconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.3.0 make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): In file included from arch/mips/include/asm/bug.h:42, from include/linux/bug.h:5, from arch/mips/include/asm/cmpxchg.h:11, from arch/mips/include/asm/atomic.h:22, from include/linux/atomic.h:7, from include/linux/cpumask.h:13, from include/linux/interrupt.h:8, from drivers/irqchip/irq-mips-cpu.c:26: drivers/irqchip/irq-mips-cpu.c: In function 'mips_mt_send_ipi': >> drivers/irqchip/irq-mips-cpu.c:100:11: error: implicit declaration of function 'cpus_are_siblings' [-Werror=implicit-function-declaration] 100 | WARN_ON(!cpus_are_siblings(smp_processor_id(), cpu)); | ^~~~~~~~~~~~~~~~~ include/asm-generic/bug.h:182:25: note: in definition of macro 'WARN_ON' 182 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ In file included from arch/mips/include/asm/mach-generic/spaces.h:15, from arch/mips/include/asm/addrspace.h:13, from arch/mips/include/asm/barrier.h:11, from include/linux/compiler.h:256, from include/linux/init.h:5, from drivers/irqchip/irq-mips-cpu.c:25: >> drivers/irqchip/irq-mips-cpu.c:103:8: error: implicit declaration of function 'cpu_vpe_id' [-Werror=implicit-function-declaration] 103 | settc(cpu_vpe_id(&cpu_data[cpu])); | ^~~~~~~~~~ arch/mips/include/asm/mipsregs.h:1411:29: note: in definition of macro '__write_32bit_c0_register' 1411 | : : "Jr" ((unsigned int)(value))); \ | ^~~~~ >> arch/mips/include/asm/mipsmtregs.h:369:2: note: in expansion of macro 'write_c0_vpecontrol' 369 | write_c0_vpecontrol((read_c0_vpecontrol()&~VPECONTROL_TARGTC) | (tc)); \ | ^~~~~~~~~~~~~~~~~~~ >> drivers/irqchip/irq-mips-cpu.c:103:2: note: in expansion of macro 'settc' 103 | settc(cpu_vpe_id(&cpu_data[cpu])); | ^~~~~ cc1: some warnings being treated as errors -- arch/mips/kernel/prom.c: In function 'mips_dt_init_cpu_maps': >> arch/mips/kernel/prom.c:178:3: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration] 178 | cpu_logical_map(i) = tmp_map[i]; | ^~~~~~~~~~~~~~~ >> arch/mips/kernel/prom.c:178:22: error: lvalue required as left operand of assignment 178 | cpu_logical_map(i) = tmp_map[i]; | ^ cc1: all warnings being treated as errors vim +/cpus_are_siblings +100 drivers/irqchip/irq-mips-cpu.c 3838a547fda22a Paul Burton 2017-03-30 90 3838a547fda22a Paul Burton 2017-03-30 91 static void mips_mt_send_ipi(struct irq_data *d, unsigned int cpu) 3838a547fda22a Paul Burton 2017-03-30 92 { 3838a547fda22a Paul Burton 2017-03-30 93 irq_hw_number_t hwirq = irqd_to_hwirq(d); 3838a547fda22a Paul Burton 2017-03-30 94 unsigned long flags; 3838a547fda22a Paul Burton 2017-03-30 95 int vpflags; 3838a547fda22a Paul Burton 2017-03-30 96 3838a547fda22a Paul Burton 2017-03-30 97 local_irq_save(flags); 3838a547fda22a Paul Burton 2017-03-30 98 3838a547fda22a Paul Burton 2017-03-30 99 /* We can only send IPIs to VPEs within the local core */ fe7a38c625a2ee Paul Burton 2017-08-12 @100 WARN_ON(!cpus_are_siblings(smp_processor_id(), cpu)); 3838a547fda22a Paul Burton 2017-03-30 101 3838a547fda22a Paul Burton 2017-03-30 102 vpflags = dvpe(); 3838a547fda22a Paul Burton 2017-03-30 @103 settc(cpu_vpe_id(&cpu_data[cpu])); 3838a547fda22a Paul Burton 2017-03-30 104 write_vpe_c0_cause(read_vpe_c0_cause() | (C_SW0 << hwirq)); 3838a547fda22a Paul Burton 2017-03-30 105 evpe(vpflags); 3838a547fda22a Paul Burton 2017-03-30 106 3838a547fda22a Paul Burton 2017-03-30 107 local_irq_restore(flags); 3838a547fda22a Paul Burton 2017-03-30 108 } 3838a547fda22a Paul Burton 2017-03-30 109 :::::: The code at line 100 was first introduced by commit :::::: fe7a38c625a2ee375870567c9fc8302e51e550f7 MIPS: Unify checks for sibling CPUs :::::: TO: Paul Burton :::::: CC: Ralf Baechle --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org