From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6643C2BB86 for ; Thu, 9 Apr 2020 13:42:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99301208FE for ; Thu, 9 Apr 2020 13:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726940AbgDINmt (ORCPT ); Thu, 9 Apr 2020 09:42:49 -0400 Received: from raptor.unsafe.ru ([5.9.43.93]:53632 "EHLO raptor.unsafe.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbgDINmt (ORCPT ); Thu, 9 Apr 2020 09:42:49 -0400 Received: from comp-core-i7-2640m-0182e6 (ip-89-102-33-211.net.upcbroadband.cz [89.102.33.211]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by raptor.unsafe.ru (Postfix) with ESMTPSA id 26602209C3; Thu, 9 Apr 2020 13:42:43 +0000 (UTC) Date: Thu, 9 Apr 2020 15:42:36 +0200 From: Alexey Gladkov To: "Eric W. Biederman" Cc: LKML , Kernel Hardening , Linux API , Linux FS Devel , Linux Security Module , Akinobu Mita , Alexander Viro , Alexey Dobriyan , Andrew Morton , Andy Lutomirski , Daniel Micay , Djalal Harouni , "Dmitry V . Levin" , Greg Kroah-Hartman , Ingo Molnar , "J . Bruce Fields" , Jeff Layton , Jonathan Corbet , Kees Cook , Linus Torvalds , Oleg Nesterov , David Howells Subject: Re: [PATCH RESEND v11 0/8] proc: modernize proc to support multiple private instances Message-ID: <20200409134236.mksvudaucp3jawf6@comp-core-i7-2640m-0182e6> References: <20200409123752.1070597-1-gladkov.alexey@gmail.com> <87y2r4vmpo.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y2r4vmpo.fsf@x220.int.ebiederm.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.1 (raptor.unsafe.ru [5.9.43.93]); Thu, 09 Apr 2020 13:42:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2020 at 07:59:47AM -0500, Eric W. Biederman wrote: > Alexey Gladkov writes: > > > Preface: > > -------- > > This is patchset v11 to modernize procfs and make it able to support multiple > > private instances per the same pid namespace. > > > > This patchset can be applied on top of: > > > > git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git > > 4b871ce26ab2 > > > > Why the resend? > > Nothing happens until the merge window closes with the release of -rc1 > (almost certainly on this coming Sunday). I goofed and did not act on > this faster, and so it is my fault this did not make it into linux-next > before the merge window. But I am not going to rush this forward. > > > > You also ignored my review and have not even descibed why it is safe > to change the type of a filesystem parameter. > > - fsparam_u32("hidepid", Opt_hidepid), > + fsparam_string("hidepid", Opt_hidepid), > > > Especially in light of people using fsconfig(fd, FSCONFIG_SET_...); > > All I need is someone to point out that fsparam_u32 does not use > FSCONFIG_SET_BINARY, but FSCONFIG_SET_STRING. I decided to resend again because I was not sure that the previous patchset was not lost. I also wanted to ask David to review and explain about the new API. I in any case did not ignore your question about changing the type of the parameter. I guess I was wrong when I sent the whole patchset again. Sorry. > My apologies for being grumpy but this feels like you are asking me to > go faster when it is totally inappropriate to do so, while busily > ignoring my feedback. > > I think this should happen. But I can't do anything until after -rc1. I think you misunderstood me. I didn't mean to rush you. -- Rgrds, legion