All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: <linux-block@vger.kernel.org>,
	Andreas Herrmann <aherrmann@suse.com>, Jan Kara <jack@suse.cz>
Subject: [PATCH 2/2] bfq: Allow short_ttime queues to have waker
Date: Thu,  9 Apr 2020 19:09:15 +0200	[thread overview]
Message-ID: <20200409170915.30570-3-jack@suse.cz> (raw)
In-Reply-To: <20200409170915.30570-1-jack@suse.cz>

Currently queues that have average think time shorter than slice_idle
cannot have waker. However this requirement is too strict. E.g. dbench
process always submits a one or two IOs (which is enough to pull its
average think time below slice_idle) and then blocks waiting for jbd2
thread to commit a transaction. Due to idling logic jbd2 thread is
often forced to wait for dbench's idle timer to trigger to be able to
submit its IO and this severely delays the overall benchmark progress.

E.g. on my test machine current dbench single-thread throughput is ~80
MB/s, with this patch it is ~200 MB/s.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 block/bfq-iosched.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index 18f85d474c9c..416473ba80c8 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -1928,7 +1928,6 @@ static void bfq_add_request(struct request *rq)
 		 * I/O-plugging interval for bfqq.
 		 */
 		if (bfqd->last_completed_rq_bfqq &&
-		    !bfq_bfqq_has_short_ttime(bfqq) &&
 		    ktime_get_ns() - bfqd->last_completion <
 		    200 * NSEC_PER_USEC) {
 			if (bfqd->last_completed_rq_bfqq != bfqq &&
-- 
2.16.4


  parent reply	other threads:[~2020-04-09 17:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 17:09 [PATCH 0/2 RFC] bfq: Waker logic tweaks for dbench performance Jan Kara
2020-04-09 17:09 ` [PATCH 1/2] bfq: Fix check detecting whether waker queue should be selected Jan Kara
2021-01-10  9:20   ` Paolo Valente
2021-01-13 13:09     ` Jan Kara
2021-01-13 13:11       ` Jan Kara
2020-04-09 17:09 ` Jan Kara [this message]
2021-01-10  9:20   ` [PATCH 2/2] bfq: Allow short_ttime queues to have waker Paolo Valente
2021-01-13 13:25     ` Jan Kara
2020-04-17  7:47 ` [PATCH 0/2 RFC] bfq: Waker logic tweaks for dbench performance Paolo Valente
2020-04-17  9:18   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409170915.30570-3-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=aherrmann@suse.com \
    --cc=linux-block@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.